Openembedded Core Discussions
 help / color / mirror / Atom feed
* Missing Upstream-Status tag in patch files.
@ 2013-04-11 14:40 Saul Wold
  2013-04-12 17:01 ` Phil Blundell
  0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2013-04-11 14:40 UTC (permalink / raw)
  To: Li Wang, Khem Raj, Andrei Dinu, Mark Hatle, Bogdan Marinescu,
	Constantin Musca, Joe Slater, Ashfield, Bruce,
	msm-oss@mcclintock.net, Phil Blundell, Phil Staub, Jim.Somerville
  Cc: 'Patches and discussions about the oe-core layer'



> Li Wang - meta/recipes-gnome/librsvg/librsvg-2.32.1/librsvg-CVE-2011-3146.patch
> Khem Raj - meta/recipes-core/eglibc/eglibc-2.17/eglibc-2.17-r22178.patch
> Khem Raj - meta/recipes-core/eglibc/eglibc-2.17/eglibc-2.17-PR15003-r22243.patch
> Li Wang - meta/recipes-core/libxml/libxml2/libxml2-CVE-2012-2871.patch
> Andrei Dinu - meta/recipes-connectivity/openssh/openssh-6.1p1/openssh-CVE-2011-4327.patch
> Jim Somerville -

Folks,

This is a reminder that patches need to have Upstream-Status and 
Signed-off-by tags in the patches themselves.

Please review this list below (I have most of the people on the To: line 
also) and fix these patches with the required tags.

We want these tags in order to get correct attribution of the patches 
along with how things are working with the Upstream Project itself, as 
we want to continue to reduce the number of patches we carry and help 
improve the upstream project stability.

Thanks for your help with this effort

Sau!


> Richard Purdie - meta/recipes-devtools/qemu/files/3f08ffb4a4741d147634761dc053ed386243a0de.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0001-bfd.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0017-ld-elf-comm-data.exp-Add-XFAIL-for-arm-targets-refer.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0013-gas-ChangeLog.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0003-Assemble-all-sources-files-in-each-test.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0010-bfd-ChangeLog.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0026-ld-testsuite.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0005-bfd.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0012-Fix-TLS-LD-to-LE-optimization-for-x32.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0018-bfd.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0014-Fix-opcode-for-64-bit-jecxz.patch
> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0024-bfd.patch
> Bruce Ashfield - meta/recipes-devtools/guilt/files/guilt-update-supported-git-versions-to-1.8.x.patch
> Mark Hatle - meta/recipes-devtools/rpm/rpm/rpm-debug-platform.patch
> Bogdan Marinescu - meta/recipes-devtools/rpm/rpm/rpm-remove-sykcparse-decl.patch
> Constantin Musca - meta/recipes-devtools/apt/apt-0.9.7.7/no-nls-dpkg.patch
> Constantin Musca - meta/recipes-devtools/apt/apt-0.9.7.7/use-host.patch
> Constantin Musca - meta/recipes-devtools/apt/apt-0.9.7.7/fix-gcc-4.6-null-not-defined.patch
> Joe Slater - meta/recipes-support/curl/curl/configure_ac.patch
> Matthew McClintock - meta/recipes-kernel/oprofile/oprofile/0001-Allow-ppc64-events-to-be-specified-with-or-without-_.patch
> Bogdan Marinescu - meta/recipes-kernel/oprofile/oprofile/opstart.patch
> Dexuan Cui - meta/recipes-kernel/oprofile/oprofile/opstart.patch
> Richard Purdie - meta/recipes-kernel/oprofile/oprofile/opstart.patch
> Matthew McClintock - meta/recipes-kernel/oprofile/oprofile/0001-Fix-PPC64-specific-libpfm-usage-so-it-doesn-t-break-.patch
> Matthew McClintock - meta/recipes-kernel/oprofile/oprofile/0001-ophelp-lists-events-Fix-doc-URL-for-ppc64-arch.patch
> Phil Staub - meta/recipes-extended/libaio/libaio/libaio_fix_for_mips_syscalls.patch

-- 
     Sau!

Saul Wold
Yocto Component Wrangler @ Intel
Yocto Project / Poky Build System




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Missing Upstream-Status tag in patch files.
  2013-04-11 14:40 Missing Upstream-Status tag in patch files Saul Wold
@ 2013-04-12 17:01 ` Phil Blundell
  2013-04-12 19:32   ` Saul Wold
  0 siblings, 1 reply; 3+ messages in thread
From: Phil Blundell @ 2013-04-12 17:01 UTC (permalink / raw)
  To: Saul Wold
  Cc: Jim.Somerville, Phil Staub,
	discussions about the oe-core layer', Ashfield, Bruce, Andrei,
	Phil Blundell, Joe Slater, Constantin Musca, 'Patches

On Thu, 2013-04-11 at 07:40 -0700, Saul Wold wrote:
> 
> > Li Wang - meta/recipes-gnome/librsvg/librsvg-2.32.1/librsvg-CVE-2011-3146.patch
> > Khem Raj - meta/recipes-core/eglibc/eglibc-2.17/eglibc-2.17-r22178.patch
> > Khem Raj - meta/recipes-core/eglibc/eglibc-2.17/eglibc-2.17-PR15003-r22243.patch
> > Li Wang - meta/recipes-core/libxml/libxml2/libxml2-CVE-2012-2871.patch
> > Andrei Dinu - meta/recipes-connectivity/openssh/openssh-6.1p1/openssh-CVE-2011-4327.patch
> > Jim Somerville -
> 
> Folks,
> 
> This is a reminder that patches need to have Upstream-Status and 
> Signed-off-by tags in the patches themselves.
> 
> Please review this list below (I have most of the people on the To: line 
> also) and fix these patches with the required tags.

Saul

You included me in the To: field but I can't see any patches listed
below with my name against them.  Can you be more specific about which
ones (if any) you want me to fix?

Also, I seem to recall that the actual rule is that the patch just needs
to contain details of who wrote it, not necessarily a Signed-off-by line
necessarily.  Has that policy changed?

thanks

p.

> 
> We want these tags in order to get correct attribution of the patches 
> along with how things are working with the Upstream Project itself, as 
> we want to continue to reduce the number of patches we carry and help 
> improve the upstream project stability.
> 
> Thanks for your help with this effort
> 
> Sau!
> 
> 
> > Richard Purdie - meta/recipes-devtools/qemu/files/3f08ffb4a4741d147634761dc053ed386243a0de.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0001-bfd.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0017-ld-elf-comm-data.exp-Add-XFAIL-for-arm-targets-refer.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0013-gas-ChangeLog.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0003-Assemble-all-sources-files-in-each-test.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0010-bfd-ChangeLog.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0026-ld-testsuite.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0005-bfd.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0012-Fix-TLS-LD-to-LE-optimization-for-x32.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0018-bfd.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0014-Fix-opcode-for-64-bit-jecxz.patch
> > Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0024-bfd.patch
> > Bruce Ashfield - meta/recipes-devtools/guilt/files/guilt-update-supported-git-versions-to-1.8.x.patch
> > Mark Hatle - meta/recipes-devtools/rpm/rpm/rpm-debug-platform.patch
> > Bogdan Marinescu - meta/recipes-devtools/rpm/rpm/rpm-remove-sykcparse-decl.patch
> > Constantin Musca - meta/recipes-devtools/apt/apt-0.9.7.7/no-nls-dpkg.patch
> > Constantin Musca - meta/recipes-devtools/apt/apt-0.9.7.7/use-host.patch
> > Constantin Musca - meta/recipes-devtools/apt/apt-0.9.7.7/fix-gcc-4.6-null-not-defined.patch
> > Joe Slater - meta/recipes-support/curl/curl/configure_ac.patch
> > Matthew McClintock - meta/recipes-kernel/oprofile/oprofile/0001-Allow-ppc64-events-to-be-specified-with-or-without-_.patch
> > Bogdan Marinescu - meta/recipes-kernel/oprofile/oprofile/opstart.patch
> > Dexuan Cui - meta/recipes-kernel/oprofile/oprofile/opstart.patch
> > Richard Purdie - meta/recipes-kernel/oprofile/oprofile/opstart.patch
> > Matthew McClintock - meta/recipes-kernel/oprofile/oprofile/0001-Fix-PPC64-specific-libpfm-usage-so-it-doesn-t-break-.patch
> > Matthew McClintock - meta/recipes-kernel/oprofile/oprofile/0001-ophelp-lists-events-Fix-doc-URL-for-ppc64-arch.patch
> > Phil Staub - meta/recipes-extended/libaio/libaio/libaio_fix_for_mips_syscalls.patch
> 





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Missing Upstream-Status tag in patch files.
  2013-04-12 17:01 ` Phil Blundell
@ 2013-04-12 19:32   ` Saul Wold
  0 siblings, 0 replies; 3+ messages in thread
From: Saul Wold @ 2013-04-12 19:32 UTC (permalink / raw)
  To: Phil Blundell
  Cc: Jim.Somerville, Phil Staub,
	'Patches and discussions about the oe-core layer',
	Ashfield, Bruce, Phil Blundell, Joe Slater, Constantin Musca

On 04/12/2013 10:01 AM, Phil Blundell wrote:
> On Thu, 2013-04-11 at 07:40 -0700, Saul Wold wrote:
>>
>>> Li Wang - meta/recipes-gnome/librsvg/librsvg-2.32.1/librsvg-CVE-2011-3146.patch
>>> Khem Raj - meta/recipes-core/eglibc/eglibc-2.17/eglibc-2.17-r22178.patch
>>> Khem Raj - meta/recipes-core/eglibc/eglibc-2.17/eglibc-2.17-PR15003-r22243.patch
>>> Li Wang - meta/recipes-core/libxml/libxml2/libxml2-CVE-2012-2871.patch
>>> Andrei Dinu - meta/recipes-connectivity/openssh/openssh-6.1p1/openssh-CVE-2011-4327.patch
>>> Jim Somerville -
>>
>> Folks,
>>
>> This is a reminder that patches need to have Upstream-Status and
>> Signed-off-by tags in the patches themselves.
>>
>> Please review this list below (I have most of the people on the To: line
>> also) and fix these patches with the required tags.
>
> Saul
>
> You included me in the To: field but I can't see any patches listed
> below with my name against them.  Can you be more specific about which
> ones (if any) you want me to fix?
>
I think it was likely a mistake based on thunderbird's autofill when I 
was adding Phil Staub.

> Also, I seem to recall that the actual rule is that the patch just needs
> to contain details of who wrote it, not necessarily a Signed-off-by line
> necessarily.  Has that policy changed?
>
Who wrote it, but also who Signed-off-by on including the patch into the 
releass. That removes the extra step of digging into git logs in the 
case of people using the tarball and not having the git history.


Sau!

> thanks
>
> p.
>
>>
>> We want these tags in order to get correct attribution of the patches
>> along with how things are working with the Upstream Project itself, as
>> we want to continue to reduce the number of patches we carry and help
>> improve the upstream project stability.
>>
>> Thanks for your help with this effort
>>
>> Sau!
>>
>>
>>> Richard Purdie - meta/recipes-devtools/qemu/files/3f08ffb4a4741d147634761dc053ed386243a0de.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0001-bfd.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0017-ld-elf-comm-data.exp-Add-XFAIL-for-arm-targets-refer.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0013-gas-ChangeLog.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0003-Assemble-all-sources-files-in-each-test.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0010-bfd-ChangeLog.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0026-ld-testsuite.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0005-bfd.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0012-Fix-TLS-LD-to-LE-optimization-for-x32.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0018-bfd.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0014-Fix-opcode-for-64-bit-jecxz.patch
>>> Khem Raj - meta/recipes-devtools/binutils/binutils-2.23.1/backport/0024-bfd.patch
>>> Bruce Ashfield - meta/recipes-devtools/guilt/files/guilt-update-supported-git-versions-to-1.8.x.patch
>>> Mark Hatle - meta/recipes-devtools/rpm/rpm/rpm-debug-platform.patch
>>> Bogdan Marinescu - meta/recipes-devtools/rpm/rpm/rpm-remove-sykcparse-decl.patch
>>> Constantin Musca - meta/recipes-devtools/apt/apt-0.9.7.7/no-nls-dpkg.patch
>>> Constantin Musca - meta/recipes-devtools/apt/apt-0.9.7.7/use-host.patch
>>> Constantin Musca - meta/recipes-devtools/apt/apt-0.9.7.7/fix-gcc-4.6-null-not-defined.patch
>>> Joe Slater - meta/recipes-support/curl/curl/configure_ac.patch
>>> Matthew McClintock - meta/recipes-kernel/oprofile/oprofile/0001-Allow-ppc64-events-to-be-specified-with-or-without-_.patch
>>> Bogdan Marinescu - meta/recipes-kernel/oprofile/oprofile/opstart.patch
>>> Dexuan Cui - meta/recipes-kernel/oprofile/oprofile/opstart.patch
>>> Richard Purdie - meta/recipes-kernel/oprofile/oprofile/opstart.patch
>>> Matthew McClintock - meta/recipes-kernel/oprofile/oprofile/0001-Fix-PPC64-specific-libpfm-usage-so-it-doesn-t-break-.patch
>>> Matthew McClintock - meta/recipes-kernel/oprofile/oprofile/0001-ophelp-lists-events-Fix-doc-URL-for-ppc64-arch.patch
>>> Phil Staub - meta/recipes-extended/libaio/libaio/libaio_fix_for_mips_syscalls.patch
>>
>
>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-12 19:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-11 14:40 Missing Upstream-Status tag in patch files Saul Wold
2013-04-12 17:01 ` Phil Blundell
2013-04-12 19:32   ` Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox