Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] hello-mod: Ensure the produced package name begins with kernel-module-
@ 2013-04-12 19:42 Mark Hatle
  2013-04-12 20:06 ` Bruce Ashfield
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Hatle @ 2013-04-12 19:42 UTC (permalink / raw)
  To: openembedded-core

The special key kernel-module- is necessary for the system to avoid a package
rename when installing a multilib image.  For example:

local.conf: IMAGE_INSTALL_append = " hello-mod"

bitbake lib32-core-image-minimal

The system will translate names and prepend 'lib32-', unless the package
begins with kernel-module-.

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
 meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb b/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
index 64a6dda..621f700 100644
--- a/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
+++ b/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
@@ -13,3 +13,11 @@ SRC_URI = "file://Makefile \
           "
 
 S = "${WORKDIR}"
+
+# Kernel module packages MUST begin with 'kernel-module-', otherwise
+# multilib image generation can fail.
+#
+# The following line is only necessary if the recipe name does not begin
+# with kernel-module-.
+#
+PKG_${PN} = "kernel-module-${PN}"
-- 
1.8.1.2.545.g2f19ada




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] hello-mod: Ensure the produced package name begins with kernel-module-
  2013-04-12 19:42 [PATCH] hello-mod: Ensure the produced package name begins with kernel-module- Mark Hatle
@ 2013-04-12 20:06 ` Bruce Ashfield
  2013-04-12 20:11   ` Mark Hatle
  2013-04-12 20:41   ` Martin Jansa
  0 siblings, 2 replies; 4+ messages in thread
From: Bruce Ashfield @ 2013-04-12 20:06 UTC (permalink / raw)
  To: Mark Hatle; +Cc: Patches and discussions about the oe-core layer

On Fri, Apr 12, 2013 at 3:42 PM, Mark Hatle <mark.hatle@windriver.com> wrote:
> The special key kernel-module- is necessary for the system to avoid a package
> rename when installing a multilib image.  For example:
>
> local.conf: IMAGE_INSTALL_append = " hello-mod"
>
> bitbake lib32-core-image-minimal
>
> The system will translate names and prepend 'lib32-', unless the package
> begins with kernel-module-.

Mark and I were talking about this, and since this is something that is required
in a multlib system, and an external module has gone to the trouble of
inheriting
module.bbclass, and we have the kernel-module-split.bbclass, that this
is something
we should be able to programatically do and generate the package names that
meet the expectations of the system.

I suggested a bugzilla and we can tackle this at the front end of the upcoming
dev cycle.

I think that's reasonable, if anyone knows of a reason why this absolutely can't
be done automatically .. or I'm out to lunch, I'm happy to have my
redirect, NAK'd :)

Cheers,

Bruce


>
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> ---
>  meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb b/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
> index 64a6dda..621f700 100644
> --- a/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
> +++ b/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
> @@ -13,3 +13,11 @@ SRC_URI = "file://Makefile \
>            "
>
>  S = "${WORKDIR}"
> +
> +# Kernel module packages MUST begin with 'kernel-module-', otherwise
> +# multilib image generation can fail.
> +#
> +# The following line is only necessary if the recipe name does not begin
> +# with kernel-module-.
> +#
> +PKG_${PN} = "kernel-module-${PN}"
> --
> 1.8.1.2.545.g2f19ada
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hello-mod: Ensure the produced package name begins with kernel-module-
  2013-04-12 20:06 ` Bruce Ashfield
@ 2013-04-12 20:11   ` Mark Hatle
  2013-04-12 20:41   ` Martin Jansa
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Hatle @ 2013-04-12 20:11 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer

On 4/12/13 3:06 PM, Bruce Ashfield wrote:
> On Fri, Apr 12, 2013 at 3:42 PM, Mark Hatle <mark.hatle@windriver.com> wrote:
>> The special key kernel-module- is necessary for the system to avoid a package
>> rename when installing a multilib image.  For example:
>>
>> local.conf: IMAGE_INSTALL_append = " hello-mod"
>>
>> bitbake lib32-core-image-minimal
>>
>> The system will translate names and prepend 'lib32-', unless the package
>> begins with kernel-module-.
>
> Mark and I were talking about this, and since this is something that is required
> in a multlib system, and an external module has gone to the trouble of
> inheriting
> module.bbclass, and we have the kernel-module-split.bbclass, that this
> is something
> we should be able to programatically do and generate the package names that
> meet the expectations of the system.
>
> I suggested a bugzilla and we can tackle this at the front end of the upcoming
> dev cycle.

YP bugzilla # 4286

> I think that's reasonable, if anyone knows of a reason why this absolutely can't
> be done automatically .. or I'm out to lunch, I'm happy to have my
> redirect, NAK'd :)
>
> Cheers,
>
> Bruce
>
>
>>
>> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
>> ---
>>   meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb b/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
>> index 64a6dda..621f700 100644
>> --- a/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
>> +++ b/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
>> @@ -13,3 +13,11 @@ SRC_URI = "file://Makefile \
>>             "
>>
>>   S = "${WORKDIR}"
>> +
>> +# Kernel module packages MUST begin with 'kernel-module-', otherwise
>> +# multilib image generation can fail.
>> +#
>> +# The following line is only necessary if the recipe name does not begin
>> +# with kernel-module-.
>> +#
>> +PKG_${PN} = "kernel-module-${PN}"
>> --
>> 1.8.1.2.545.g2f19ada
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"
>




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hello-mod: Ensure the produced package name begins with kernel-module-
  2013-04-12 20:06 ` Bruce Ashfield
  2013-04-12 20:11   ` Mark Hatle
@ 2013-04-12 20:41   ` Martin Jansa
  1 sibling, 0 replies; 4+ messages in thread
From: Martin Jansa @ 2013-04-12 20:41 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 2786 bytes --]

On Fri, Apr 12, 2013 at 04:06:56PM -0400, Bruce Ashfield wrote:
> On Fri, Apr 12, 2013 at 3:42 PM, Mark Hatle <mark.hatle@windriver.com> wrote:
> > The special key kernel-module- is necessary for the system to avoid a package
> > rename when installing a multilib image.  For example:
> >
> > local.conf: IMAGE_INSTALL_append = " hello-mod"
> >
> > bitbake lib32-core-image-minimal
> >
> > The system will translate names and prepend 'lib32-', unless the package
> > begins with kernel-module-.
> 
> Mark and I were talking about this, and since this is something that is required
> in a multlib system, and an external module has gone to the trouble of
> inheriting
> module.bbclass, and we have the kernel-module-split.bbclass, that this
> is something
> we should be able to programatically do and generate the package names that
> meet the expectations of the system.
> 
> I suggested a bugzilla and we can tackle this at the front end of the upcoming
> dev cycle.
> 
> I think that's reasonable, if anyone knows of a reason why this absolutely can't
> be done automatically .. or I'm out to lunch, I'm happy to have my
> redirect, NAK'd :)

Agreed, hello-mod should give good example and 
inherit kernel-module-split

if it does not work as-is now then we should improve kernel-module-split and
hello-mod.

> >  meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb b/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
> > index 64a6dda..621f700 100644
> > --- a/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
> > +++ b/meta-skeleton/recipes-kernel/hello-mod/hello-mod_0.1.bb
> > @@ -13,3 +13,11 @@ SRC_URI = "file://Makefile \
> >            "
> >
> >  S = "${WORKDIR}"
> > +
> > +# Kernel module packages MUST begin with 'kernel-module-', otherwise
> > +# multilib image generation can fail.
> > +#
> > +# The following line is only necessary if the recipe name does not begin
> > +# with kernel-module-.
> > +#
> > +PKG_${PN} = "kernel-module-${PN}"
> > --
> > 1.8.1.2.545.g2f19ada
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> 
> 
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-04-12 20:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-12 19:42 [PATCH] hello-mod: Ensure the produced package name begins with kernel-module- Mark Hatle
2013-04-12 20:06 ` Bruce Ashfield
2013-04-12 20:11   ` Mark Hatle
2013-04-12 20:41   ` Martin Jansa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox