From: Jack Mitchell <ml@communistcode.co.uk>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] connman: make tist functionallity a PACKAGECONFIG option
Date: Fri, 26 Apr 2013 11:26:15 +0100 [thread overview]
Message-ID: <517A5647.5000800@communistcode.co.uk> (raw)
In-Reply-To: <20130426101627.GM5538@jama.dyndns-home.com>
On 26/04/13 11:16, Martin Jansa wrote:
> On Fri, Apr 26, 2013 at 11:06:11AM +0100, Jack Mitchell wrote:
>> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>>
>> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>> ---
>>
>> Runtime tested on beaglebone armv7a, with and without tist PACKAGECONFIG
>>
>> meta/recipes-connectivity/connman/connman.inc | 13 +++++++------
>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
>> index 589ece8..eb9d145 100644
>> --- a/meta/recipes-connectivity/connman/connman.inc
>> +++ b/meta/recipes-connectivity/connman/connman.inc
>> @@ -20,10 +20,7 @@ DEPENDS = "dbus glib-2.0 ppp iptables gnutls \
>> ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
>> "
>>
>> -INC_PR = "r19"
>> -
>> -TIST = "--enable-tist"
>> -TIST_powerpc = ""
>> +INC_PR = "r20"
>>
>> EXTRA_OECONF += "\
>> ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
>> @@ -32,8 +29,8 @@ EXTRA_OECONF += "\
>> --enable-threads \
>> --enable-loopback \
>> --enable-ethernet \
>> - ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
>> - ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
>> + ${@base_contains('DISTRO_FEATURES', 'wifi', '--enable-wifi', '--disable-wifi', d)} \
>> + ${@base_contains('DISTRO_FEATURES', 'bluetooth', '--enable-bluetooth', '--disable-bluetooth', d)} \
>> ${@base_contains('DISTRO_FEATURES', '3g', '--enable-ofono', '--disable-ofono', d)} \
>> --enable-tools \
>> --enable-test \
>> @@ -43,6 +40,10 @@ EXTRA_OECONF += "\
>> ${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemdunitdir=${systemd_unitdir}/system/', '--with-systemdunitdir=', d)} \
>> "
>>
>> +PACKAGECONFIG ??= ""
>> +
>> +PACKAGECONFIG[tist] = "--enable-tist,,"
> would you mind to convert wifi, bluetooth and 3g also to PACKAGECONFIGs?
>
>> +
>> INITSCRIPT_NAME = "connman"
>> INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
>>
>> --
>> 1.8.2.1
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Something like:
PACKAGECONFIG ??= " \
${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)}\
"
PACKAGECONFIG[wifi] = "--enable-wifi,--disable-wifi,"
Or were you thinking of another method?
--
Jack Mitchell (jack@embed.me.uk)
Embedded Systems Engineer
http://www.embed.me.uk
--
next prev parent reply other threads:[~2013-04-26 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 10:06 [PATCH] connman: make tist functionallity a PACKAGECONFIG option Jack Mitchell
2013-04-26 10:16 ` Martin Jansa
2013-04-26 10:26 ` Jack Mitchell [this message]
2013-04-26 10:37 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517A5647.5000800@communistcode.co.uk \
--to=ml@communistcode.co.uk \
--cc=jack.mitchell@dbbroadcast.co.uk \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox