* [PATCH] connman: make tist functionallity a PACKAGECONFIG option
@ 2013-04-26 10:06 Jack Mitchell
2013-04-26 10:16 ` Martin Jansa
0 siblings, 1 reply; 4+ messages in thread
From: Jack Mitchell @ 2013-04-26 10:06 UTC (permalink / raw)
To: openembedded-core; +Cc: Jack Mitchell
From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
---
Runtime tested on beaglebone armv7a, with and without tist PACKAGECONFIG
meta/recipes-connectivity/connman/connman.inc | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index 589ece8..eb9d145 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -20,10 +20,7 @@ DEPENDS = "dbus glib-2.0 ppp iptables gnutls \
${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
"
-INC_PR = "r19"
-
-TIST = "--enable-tist"
-TIST_powerpc = ""
+INC_PR = "r20"
EXTRA_OECONF += "\
ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
@@ -32,8 +29,8 @@ EXTRA_OECONF += "\
--enable-threads \
--enable-loopback \
--enable-ethernet \
- ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
- ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
+ ${@base_contains('DISTRO_FEATURES', 'wifi', '--enable-wifi', '--disable-wifi', d)} \
+ ${@base_contains('DISTRO_FEATURES', 'bluetooth', '--enable-bluetooth', '--disable-bluetooth', d)} \
${@base_contains('DISTRO_FEATURES', '3g', '--enable-ofono', '--disable-ofono', d)} \
--enable-tools \
--enable-test \
@@ -43,6 +40,10 @@ EXTRA_OECONF += "\
${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemdunitdir=${systemd_unitdir}/system/', '--with-systemdunitdir=', d)} \
"
+PACKAGECONFIG ??= ""
+
+PACKAGECONFIG[tist] = "--enable-tist,,"
+
INITSCRIPT_NAME = "connman"
INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
--
1.8.2.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] connman: make tist functionallity a PACKAGECONFIG option
2013-04-26 10:06 [PATCH] connman: make tist functionallity a PACKAGECONFIG option Jack Mitchell
@ 2013-04-26 10:16 ` Martin Jansa
2013-04-26 10:26 ` Jack Mitchell
0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2013-04-26 10:16 UTC (permalink / raw)
To: Jack Mitchell; +Cc: Jack Mitchell, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2426 bytes --]
On Fri, Apr 26, 2013 at 11:06:11AM +0100, Jack Mitchell wrote:
> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>
> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> ---
>
> Runtime tested on beaglebone armv7a, with and without tist PACKAGECONFIG
>
> meta/recipes-connectivity/connman/connman.inc | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index 589ece8..eb9d145 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -20,10 +20,7 @@ DEPENDS = "dbus glib-2.0 ppp iptables gnutls \
> ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
> "
>
> -INC_PR = "r19"
> -
> -TIST = "--enable-tist"
> -TIST_powerpc = ""
> +INC_PR = "r20"
>
> EXTRA_OECONF += "\
> ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
> @@ -32,8 +29,8 @@ EXTRA_OECONF += "\
> --enable-threads \
> --enable-loopback \
> --enable-ethernet \
> - ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
> - ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'wifi', '--enable-wifi', '--disable-wifi', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'bluetooth', '--enable-bluetooth', '--disable-bluetooth', d)} \
> ${@base_contains('DISTRO_FEATURES', '3g', '--enable-ofono', '--disable-ofono', d)} \
> --enable-tools \
> --enable-test \
> @@ -43,6 +40,10 @@ EXTRA_OECONF += "\
> ${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemdunitdir=${systemd_unitdir}/system/', '--with-systemdunitdir=', d)} \
> "
>
> +PACKAGECONFIG ??= ""
> +
> +PACKAGECONFIG[tist] = "--enable-tist,,"
would you mind to convert wifi, bluetooth and 3g also to PACKAGECONFIGs?
> +
> INITSCRIPT_NAME = "connman"
> INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
>
> --
> 1.8.2.1
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] connman: make tist functionallity a PACKAGECONFIG option
2013-04-26 10:16 ` Martin Jansa
@ 2013-04-26 10:26 ` Jack Mitchell
2013-04-26 10:37 ` Burton, Ross
0 siblings, 1 reply; 4+ messages in thread
From: Jack Mitchell @ 2013-04-26 10:26 UTC (permalink / raw)
To: Martin Jansa; +Cc: Jack Mitchell, openembedded-core
On 26/04/13 11:16, Martin Jansa wrote:
> On Fri, Apr 26, 2013 at 11:06:11AM +0100, Jack Mitchell wrote:
>> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>>
>> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>> ---
>>
>> Runtime tested on beaglebone armv7a, with and without tist PACKAGECONFIG
>>
>> meta/recipes-connectivity/connman/connman.inc | 13 +++++++------
>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
>> index 589ece8..eb9d145 100644
>> --- a/meta/recipes-connectivity/connman/connman.inc
>> +++ b/meta/recipes-connectivity/connman/connman.inc
>> @@ -20,10 +20,7 @@ DEPENDS = "dbus glib-2.0 ppp iptables gnutls \
>> ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
>> "
>>
>> -INC_PR = "r19"
>> -
>> -TIST = "--enable-tist"
>> -TIST_powerpc = ""
>> +INC_PR = "r20"
>>
>> EXTRA_OECONF += "\
>> ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
>> @@ -32,8 +29,8 @@ EXTRA_OECONF += "\
>> --enable-threads \
>> --enable-loopback \
>> --enable-ethernet \
>> - ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
>> - ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
>> + ${@base_contains('DISTRO_FEATURES', 'wifi', '--enable-wifi', '--disable-wifi', d)} \
>> + ${@base_contains('DISTRO_FEATURES', 'bluetooth', '--enable-bluetooth', '--disable-bluetooth', d)} \
>> ${@base_contains('DISTRO_FEATURES', '3g', '--enable-ofono', '--disable-ofono', d)} \
>> --enable-tools \
>> --enable-test \
>> @@ -43,6 +40,10 @@ EXTRA_OECONF += "\
>> ${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemdunitdir=${systemd_unitdir}/system/', '--with-systemdunitdir=', d)} \
>> "
>>
>> +PACKAGECONFIG ??= ""
>> +
>> +PACKAGECONFIG[tist] = "--enable-tist,,"
> would you mind to convert wifi, bluetooth and 3g also to PACKAGECONFIGs?
>
>> +
>> INITSCRIPT_NAME = "connman"
>> INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
>>
>> --
>> 1.8.2.1
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Something like:
PACKAGECONFIG ??= " \
${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)}\
"
PACKAGECONFIG[wifi] = "--enable-wifi,--disable-wifi,"
Or were you thinking of another method?
--
Jack Mitchell (jack@embed.me.uk)
Embedded Systems Engineer
http://www.embed.me.uk
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] connman: make tist functionallity a PACKAGECONFIG option
2013-04-26 10:26 ` Jack Mitchell
@ 2013-04-26 10:37 ` Burton, Ross
0 siblings, 0 replies; 4+ messages in thread
From: Burton, Ross @ 2013-04-26 10:37 UTC (permalink / raw)
To: ml; +Cc: Jack Mitchell, Martin Jansa, openembedded-core
On 26 April 2013 11:26, Jack Mitchell <ml@communistcode.co.uk> wrote:
> Something like:
>
> PACKAGECONFIG ??= " \
> ${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)}\
> "
>
> PACKAGECONFIG[wifi] = "--enable-wifi,--disable-wifi,"
>
> Or were you thinking of another method?
That's right. Would be nice if we had a more concise method, but
that's idiomatic at least.
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-26 10:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-26 10:06 [PATCH] connman: make tist functionallity a PACKAGECONFIG option Jack Mitchell
2013-04-26 10:16 ` Martin Jansa
2013-04-26 10:26 ` Jack Mitchell
2013-04-26 10:37 ` Burton, Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox