From: Darren Hart <dvhart@linux.intel.com>
To: Tomas Frydrych <tf+lists.yocto@r-finger.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] ia32-base.inc: remove inapropriate grub dependency
Date: Wed, 01 May 2013 13:56:36 -0700 [thread overview]
Message-ID: <51818184.4000301@linux.intel.com> (raw)
In-Reply-To: <5181806C.4070708@r-finger.com>
On 05/01/2013 01:51 PM, Tomas Frydrych wrote:
> On 01/05/13 21:25, Darren Hart wrote:
>>
>>
>> On 04/27/2013 01:52 AM, tf+lists.yocto@r-finger.com wrote:
>>> From: Tomas Frydrych <tomas@sleepfive.com>
>>>
>>> There is no good reason for ia32 machines to have hard dependency on grub,
>>> as there are other bootloaders available for ia32 platforms.
>>>
>>> Signed-off-by: Tomas Frydrych <tomas@sleepfive.com>
>>> ---
>>> meta/conf/machine/include/ia32-base.inc | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/meta/conf/machine/include/ia32-base.inc b/meta/conf/machine/include/ia32-base.inc
>>> index 921c740..cb542a5 100644
>>> --- a/meta/conf/machine/include/ia32-base.inc
>>> +++ b/meta/conf/machine/include/ia32-base.inc
>>> @@ -9,7 +9,6 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \
>>> acpi serial usbgadget alsa"
>>>
>>> MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
>>> -MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
>>
>> Agreed - but do the images still build as currently written after you
>> remove it here?
>
> I have not tested the efi path, though I think the grub-efi.bbclass
> takes care of the grub dependency. In the non-efi case the grub
> dependency is taken care of by initramfs-live-install.bb.
grub-efi is properly managed via the bootimg.bbclass and
MACHINE_FEATURES ~= efi.
Acked-by: Darren Hart <dvhart@linux.intel.com>
Thanks Tomas!
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
prev parent reply other threads:[~2013-05-01 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 15:50 [PATCH] ia32-base.inc: remove inapropriate grub dependency tf+lists.yocto
2013-04-27 8:52 ` tf+lists.yocto
2013-05-01 20:25 ` Darren Hart
2013-05-01 20:51 ` Tomas Frydrych
2013-05-01 20:56 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51818184.4000301@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=tf+lists.yocto@r-finger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox