Re: [PATCH 0/5] Enable VPN support in ConnMan

[Saul Wold <sgw@linux.intel.com>]

On 05/12/2013 10:55 PM, Paul Eggleton wrote:
> On Sunday 12 May 2013 19:54:50 Phil Blundell wrote:
>> On Sun, 2013-05-12 at 08:40 -0700, Saul Wold wrote:
>>> On 05/12/2013 06:27 AM, Otavio Salvador wrote:
>>>> I think so, it'd be good to have it in oe-core and allow use of vpn :)
>>>
>>> I would like to see what the full dependency set looks like for these,
>>> clearly there is the vpnc, openvpn, l2tp and pptp recipes, but what else
>>> and what licenses are they under.
>>
>> I don't think we necessarily want openvpn, l2tpd and suchlike in
>> oe-core.  None of those things seem very "core" to me (in an embedded
>> context) and testing them seems like it would be a bit of a challenge.
>
> I agree, these don't belong in OE-Core. We already have them in meta-
> networking.
>
This is what I get for replying to an email while traveling overseas and 
not being 100% clear about my points.

I was more interested in the dependencies then actually thinking about 
including them in OE-Core,that was not my intent.

This would would allow us to better understand if those recipes not in 
meta-networking could be moved from meta-oe to meta-networking. 
Currently, I think vpnc and pptp are in meta-networking, not the other 2.

>> Equally, we certainly don't want to have dependencies in oe-core
>> pointing to packages in meta-oe or any other layer, since this would
>> make it impossible to test oe-core in isolation.  So I would be inclined
>> to say that the right way to deal with this is for those connman bits to
>> go in a .bbappend which lives in the same layer as the recipes in
>> question.
>
> That doesn't work well for software layers - it is not a good thing for
> various recipes to get rebuilt just because you add meta-oe to your
> configuration for example.
>
> The protocol we've established is to add PACKAGECONFIG options to enable the
> dependencies but have them disabled by default; these can be enabled as
> desired in distro or local configuration when the layer satisfying the
> dependency is also enabled.
>
This is correct and I talked with RP about this to verify, having these 
kind of dependencies use PACKAGECONFIG and being disabled by default in 
OE-Core make sense and is vaild recipe, a Distro or local configuration 
can then enable and require the additional layers whether it's meta-oe 
or meta-networking as needed.

Sau!

> Cheers,
> Paul
>