* [PATCH 0/1] image_types.bbclass: remove the obsolete images
@ 2013-05-07 10:26 Robert Yang
2013-05-07 10:26 ` [PATCH 1/1] " Robert Yang
2013-05-17 2:14 ` [PATCH 0/1] " Robert Yang
0 siblings, 2 replies; 6+ messages in thread
From: Robert Yang @ 2013-05-07 10:26 UTC (permalink / raw)
To: openembedded-core
The following changes since commit 3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:
grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/rm_old
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/rm_old
Robert Yang (1):
image_types.bbclass: remove the obsolete images
meta/classes/image_types.bbclass | 6 +++++-
meta/conf/local.conf.sample.extended | 3 +++
2 files changed, 8 insertions(+), 1 deletion(-)
--
1.8.1.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] image_types.bbclass: remove the obsolete images
2013-05-07 10:26 [PATCH 0/1] image_types.bbclass: remove the obsolete images Robert Yang
@ 2013-05-07 10:26 ` Robert Yang
2013-05-07 10:32 ` Paul Eggleton
2013-05-17 2:14 ` [PATCH 0/1] " Robert Yang
1 sibling, 1 reply; 6+ messages in thread
From: Robert Yang @ 2013-05-07 10:26 UTC (permalink / raw)
To: openembedded-core
Remove the obsolete image before the new one generated to save disk
space when RM_OBSOLETE_IMAGE is set to 1, this is an easy way to keep
the DEPLOY_DIR_IMAGE clean.
[YOCTO #4391]
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
meta/classes/image_types.bbclass | 6 +++++-
meta/conf/local.conf.sample.extended | 3 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index 94837ae..27f232e 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -51,7 +51,11 @@ def get_imagecmds(d):
types.remove("live")
if d.getVar('IMAGE_LINK_NAME', True):
- cmds += "\trm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.*"
+ if d.getVar('RM_OBSOLETE_IMAGE', True) == "1":
+ # Remove the obsolete image
+ cmds += "\trm -f `find ${DEPLOY_DIR_IMAGE} -maxdepth 1 -type l -name ${IMAGE_LINK_NAME}'.*' -exec readlink -f {} \;`"
+ # Remove the symlink
+ cmds += "\n\trm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.*"
for type in types:
ccmd = []
diff --git a/meta/conf/local.conf.sample.extended b/meta/conf/local.conf.sample.extended
index 1d1a8ec..efe0804 100644
--- a/meta/conf/local.conf.sample.extended
+++ b/meta/conf/local.conf.sample.extended
@@ -207,3 +207,6 @@
#ARCHIVER_MODE[filter] ?= "no"
#ARCHIVER_CLASS = "${@'archive-${ARCHIVER_MODE}-source' if ARCHIVER_MODE != 'none' else ''}"
#INHERIT += "${ARCHIVER_CLASS}"
+
+# Remove the obsolete image before the new one generated to save disk space
+#RM_OBSOLETE_IMAGE = "1"
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] image_types.bbclass: remove the obsolete images
2013-05-07 10:26 ` [PATCH 1/1] " Robert Yang
@ 2013-05-07 10:32 ` Paul Eggleton
2013-05-07 10:41 ` Robert Yang
0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2013-05-07 10:32 UTC (permalink / raw)
To: Robert Yang; +Cc: openembedded-core
On Tuesday 07 May 2013 18:26:59 Robert Yang wrote:
> Remove the obsolete image before the new one generated to save disk
> space when RM_OBSOLETE_IMAGE is set to 1, this is an easy way to keep
> the DEPLOY_DIR_IMAGE clean.
>
> [YOCTO #4391]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/classes/image_types.bbclass | 6 +++++-
> meta/conf/local.conf.sample.extended | 3 +++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/image_types.bbclass
> b/meta/classes/image_types.bbclass index 94837ae..27f232e 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -51,7 +51,11 @@ def get_imagecmds(d):
> types.remove("live")
>
> if d.getVar('IMAGE_LINK_NAME', True):
> - cmds += "\trm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.*"
> + if d.getVar('RM_OBSOLETE_IMAGE', True) == "1":
> + # Remove the obsolete image
> + cmds += "\trm -f `find ${DEPLOY_DIR_IMAGE} -maxdepth 1 -type l
> -name ${IMAGE_LINK_NAME}'.*' -exec readlink -f {} \;`" + # Remove
> the symlink
> + cmds += "\n\trm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.*"
>
> for type in types:
> ccmd = []
> diff --git a/meta/conf/local.conf.sample.extended
> b/meta/conf/local.conf.sample.extended index 1d1a8ec..efe0804 100644
> --- a/meta/conf/local.conf.sample.extended
> +++ b/meta/conf/local.conf.sample.extended
> @@ -207,3 +207,6 @@
> #ARCHIVER_MODE[filter] ?= "no"
> #ARCHIVER_CLASS = "${@'archive-${ARCHIVER_MODE}-source' if ARCHIVER_MODE !=
> 'none' else ''}" #INHERIT += "${ARCHIVER_CLASS}"
> +
> +# Remove the obsolete image before the new one generated to save disk space
> +#RM_OBSOLETE_IMAGE = "1"
Rather than "obsolete" I would have said "old" would be the preferred
terminology here, i.e. RM_OLD_IMAGE.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] image_types.bbclass: remove the obsolete images
2013-05-07 10:32 ` Paul Eggleton
@ 2013-05-07 10:41 ` Robert Yang
0 siblings, 0 replies; 6+ messages in thread
From: Robert Yang @ 2013-05-07 10:41 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On 05/07/2013 06:32 PM, Paul Eggleton wrote:
> On Tuesday 07 May 2013 18:26:59 Robert Yang wrote:
>> Remove the obsolete image before the new one generated to save disk
>> space when RM_OBSOLETE_IMAGE is set to 1, this is an easy way to keep
>> the DEPLOY_DIR_IMAGE clean.
>>
>> [YOCTO #4391]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>> meta/classes/image_types.bbclass | 6 +++++-
>> meta/conf/local.conf.sample.extended | 3 +++
>> 2 files changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/image_types.bbclass
>> b/meta/classes/image_types.bbclass index 94837ae..27f232e 100644
>> --- a/meta/classes/image_types.bbclass
>> +++ b/meta/classes/image_types.bbclass
>> @@ -51,7 +51,11 @@ def get_imagecmds(d):
>> types.remove("live")
>>
>> if d.getVar('IMAGE_LINK_NAME', True):
>> - cmds += "\trm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.*"
>> + if d.getVar('RM_OBSOLETE_IMAGE', True) == "1":
>> + # Remove the obsolete image
>> + cmds += "\trm -f `find ${DEPLOY_DIR_IMAGE} -maxdepth 1 -type l
>> -name ${IMAGE_LINK_NAME}'.*' -exec readlink -f {} \;`" + # Remove
>> the symlink
>> + cmds += "\n\trm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.*"
>>
>> for type in types:
>> ccmd = []
>> diff --git a/meta/conf/local.conf.sample.extended
>> b/meta/conf/local.conf.sample.extended index 1d1a8ec..efe0804 100644
>> --- a/meta/conf/local.conf.sample.extended
>> +++ b/meta/conf/local.conf.sample.extended
>> @@ -207,3 +207,6 @@
>> #ARCHIVER_MODE[filter] ?= "no"
>> #ARCHIVER_CLASS = "${@'archive-${ARCHIVER_MODE}-source' if ARCHIVER_MODE !=
>> 'none' else ''}" #INHERIT += "${ARCHIVER_CLASS}"
>> +
>> +# Remove the obsolete image before the new one generated to save disk space
>> +#RM_OBSOLETE_IMAGE = "1"
>
> Rather than "obsolete" I would have said "old" would be the preferred
> terminology here, i.e. RM_OLD_IMAGE.
>
Thanks, I've updated the git repo:
git://git.pokylinux.org/poky-contrib robert/rm_old
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/rm_old
// Robert
> Cheers,
> Paul
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/1] image_types.bbclass: remove the obsolete images
2013-05-07 10:26 [PATCH 0/1] image_types.bbclass: remove the obsolete images Robert Yang
2013-05-07 10:26 ` [PATCH 1/1] " Robert Yang
@ 2013-05-17 2:14 ` Robert Yang
2013-05-17 2:39 ` Khem Raj
1 sibling, 1 reply; 6+ messages in thread
From: Robert Yang @ 2013-05-17 2:14 UTC (permalink / raw)
To: openembedded-core
Ping.
// Robert
On 05/07/2013 06:26 PM, Robert Yang wrote:
> The following changes since commit 3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:
>
> grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)
>
> are available in the git repository at:
>
> git://git.pokylinux.org/poky-contrib robert/rm_old
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/rm_old
>
> Robert Yang (1):
> image_types.bbclass: remove the obsolete images
>
> meta/classes/image_types.bbclass | 6 +++++-
> meta/conf/local.conf.sample.extended | 3 +++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-17 2:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 10:26 [PATCH 0/1] image_types.bbclass: remove the obsolete images Robert Yang
2013-05-07 10:26 ` [PATCH 1/1] " Robert Yang
2013-05-07 10:32 ` Paul Eggleton
2013-05-07 10:41 ` Robert Yang
2013-05-17 2:14 ` [PATCH 0/1] " Robert Yang
2013-05-17 2:39 ` Khem Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox