gst-plugins-base tremor build time dependence?

gst-plugins-base tremor build time dependence?

[Javier Viguera]

Hi all,

In gst-plugins-base package there is a patch that explicitly removes the 
'-DTREMOR' symbol so the package compiles without that support:

<http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia/gstreamer/gst-plugins-base-0.10.36/gst-plugins-base-tremor.patch>

But then the gst-plugins-base bitbake recipe has a build-time dependence 
on tremor:

<http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.36.bb>

DEPENDS += "alsa-lib freetype liboil libogg libvorbis libtheora 
util-linux *tremor*"

Is this expected?
Can tremor build-time dependence be removed?

If this is the case i can cook up a patch, but I'm not sure if I'm 
missing something else.

-
Javier Viguera
Software Engineer
Digi International® Spain S.A.U.

Re: gst-plugins-base tremor build time dependence?

[Paul Eggleton]

Hi Javier,

On Monday 20 May 2013 14:47:38 Javier Viguera wrote:
> In gst-plugins-base package there is a patch that explicitly removes the
> '-DTREMOR' symbol so the package compiles without that support:
> 
> <http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia
> /gstreamer/gst-plugins-base-0.10.36/gst-plugins-base-tremor.patch>
> 
> But then the gst-plugins-base bitbake recipe has a build-time dependence
> on tremor:
> 
> <http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia
> /gstreamer/gst-plugins-base_0.10.36.bb>
> 
> DEPENDS += "alsa-lib freetype liboil libogg libvorbis libtheora
> util-linux *tremor*"
> 
> Is this expected?
> Can tremor build-time dependence be removed?
> 
> If this is the case i can cook up a patch, but I'm not sure if I'm
> missing something else.

I just had a look at this. It's not at all clear from the commit message that 
added this patch (which was quite a long time ago) but I don't think it can be 
removed outright; without tremor the ivorbisdec plugin won't be built, so 
despite the removal of -DTREMOR, tremor still appears to be being used. If 
this is something you don't want then it's probably more a case of needing to 
introduce a PACKAGECONFIG option to disable it.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre