* [PATCH] patch: diable xattr as default @ 2013-05-21 23:54 Saul Wold 2013-05-22 0:20 ` Mark Hatle 0 siblings, 1 reply; 4+ messages in thread From: Saul Wold @ 2013-05-21 23:54 UTC (permalink / raw) To: openembedded-core There is a optional dependency on xattr (and thus the attr package), disable it by default, to ensure it builds correctly. Signed-off-by: Saul Wold <sgw@linux.intel.com> --- meta/recipes-devtools/patch/patch_2.7.1.bb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/recipes-devtools/patch/patch_2.7.1.bb b/meta/recipes-devtools/patch/patch_2.7.1.bb index 38df034..b131204 100644 --- a/meta/recipes-devtools/patch/patch_2.7.1.bb +++ b/meta/recipes-devtools/patch/patch_2.7.1.bb @@ -9,3 +9,5 @@ SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504" acpaths = "-I ${S}/m4 " + +EXTRA_OECONF += "--disable-xattr" -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] patch: diable xattr as default 2013-05-21 23:54 [PATCH] patch: diable xattr as default Saul Wold @ 2013-05-22 0:20 ` Mark Hatle 2013-05-22 0:23 ` Mark Hatle 0 siblings, 1 reply; 4+ messages in thread From: Mark Hatle @ 2013-05-22 0:20 UTC (permalink / raw) To: openembedded-core On 5/21/13 6:54 PM, Saul Wold wrote: > There is a optional dependency on xattr (and thus the attr package), > disable it by default, to ensure it builds correctly. > > Signed-off-by: Saul Wold <sgw@linux.intel.com> > --- > meta/recipes-devtools/patch/patch_2.7.1.bb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/recipes-devtools/patch/patch_2.7.1.bb b/meta/recipes-devtools/patch/patch_2.7.1.bb > index 38df034..b131204 100644 > --- a/meta/recipes-devtools/patch/patch_2.7.1.bb > +++ b/meta/recipes-devtools/patch/patch_2.7.1.bb > @@ -9,3 +9,5 @@ SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6 > LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504" > > acpaths = "-I ${S}/m4 " > + > +EXTRA_OECONF += "--disable-xattr" There is an xattr distro feature. It would be better to use: ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr', '--enable-xattr', '--disable-xattr', d)}" EXTRA_OECONF += "${ENABLE_XATTR}" (Might need a -native/-nativesdk version?) > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] patch: diable xattr as default 2013-05-22 0:20 ` Mark Hatle @ 2013-05-22 0:23 ` Mark Hatle 2013-05-22 0:43 ` Saul Wold 0 siblings, 1 reply; 4+ messages in thread From: Mark Hatle @ 2013-05-22 0:23 UTC (permalink / raw) To: openembedded-core On 5/21/13 7:20 PM, Mark Hatle wrote: > On 5/21/13 6:54 PM, Saul Wold wrote: >> There is a optional dependency on xattr (and thus the attr package), >> disable it by default, to ensure it builds correctly. >> >> Signed-off-by: Saul Wold <sgw@linux.intel.com> >> --- >> meta/recipes-devtools/patch/patch_2.7.1.bb | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta/recipes-devtools/patch/patch_2.7.1.bb b/meta/recipes-devtools/patch/patch_2.7.1.bb >> index 38df034..b131204 100644 >> --- a/meta/recipes-devtools/patch/patch_2.7.1.bb >> +++ b/meta/recipes-devtools/patch/patch_2.7.1.bb >> @@ -9,3 +9,5 @@ SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6 >> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504" >> >> acpaths = "-I ${S}/m4 " >> + >> +EXTRA_OECONF += "--disable-xattr" > > There is an xattr distro feature. It would be better to use: > > ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr', '--enable-xattr', > '--disable-xattr', d)}" > > EXTRA_OECONF += "${ENABLE_XATTR}" > > (Might need a -native/-nativesdk version?) I forgot, PACKAGECONFIG might be better to use.... then the attr package dependencies can more easily be added. PACKAGECONFIG ?= "${@base_contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}" PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr," --Mark >> > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] patch: diable xattr as default 2013-05-22 0:23 ` Mark Hatle @ 2013-05-22 0:43 ` Saul Wold 0 siblings, 0 replies; 4+ messages in thread From: Saul Wold @ 2013-05-22 0:43 UTC (permalink / raw) To: Mark Hatle; +Cc: openembedded-core On 05/21/2013 05:23 PM, Mark Hatle wrote: > On 5/21/13 7:20 PM, Mark Hatle wrote: >> On 5/21/13 6:54 PM, Saul Wold wrote: >>> There is a optional dependency on xattr (and thus the attr package), >>> disable it by default, to ensure it builds correctly. >>> >>> Signed-off-by: Saul Wold <sgw@linux.intel.com> >>> --- >>> meta/recipes-devtools/patch/patch_2.7.1.bb | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/meta/recipes-devtools/patch/patch_2.7.1.bb >>> b/meta/recipes-devtools/patch/patch_2.7.1.bb >>> index 38df034..b131204 100644 >>> --- a/meta/recipes-devtools/patch/patch_2.7.1.bb >>> +++ b/meta/recipes-devtools/patch/patch_2.7.1.bb >>> @@ -9,3 +9,5 @@ SRC_URI[sha256sum] = >>> "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6 >>> LIC_FILES_CHKSUM = >>> "file://COPYING;md5=d32239bcb673463ab874e80d47fae504" >>> >>> acpaths = "-I ${S}/m4 " >>> + >>> +EXTRA_OECONF += "--disable-xattr" >> >> There is an xattr distro feature. It would be better to use: >> >> ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr', >> '--enable-xattr', >> '--disable-xattr', d)}" >> >> EXTRA_OECONF += "${ENABLE_XATTR}" >> >> (Might need a -native/-nativesdk version?) > > I forgot, PACKAGECONFIG might be better to use.... then the attr > package dependencies can more easily be added. > > PACKAGECONFIG ?= "${@base_contains('DISTRO_FEATURES', 'xattr', 'xattr', > '', d)}" > PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr," > Yup, this is more correct and slap my hand for forgetting the xattr DISTO_FEATURE! V2 coming after some tests. Sau! > --Mark > >>> >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-22 0:43 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-05-21 23:54 [PATCH] patch: diable xattr as default Saul Wold 2013-05-22 0:20 ` Mark Hatle 2013-05-22 0:23 ` Mark Hatle 2013-05-22 0:43 ` Saul Wold
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox