* [PATCH] siteinfo: add existiance check for site config file
@ 2013-05-23 14:37 Saul Wold
2013-05-23 15:51 ` Saul Wold
0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2013-05-23 14:37 UTC (permalink / raw)
To: openembedded-core
There is a condition where ncurses adds a site config file to CONFIG_SITE list
and then binutils configure tries to use the siteinfo list before ncurses has
installed the file. The existance test is there in the BBPATH search, but not
in the SYSROOTCACHE check, so add it here.
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
meta/classes/siteinfo.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/siteinfo.bbclass b/meta/classes/siteinfo.bbclass
index 09f88c6..87a4225 100644
--- a/meta/classes/siteinfo.bbclass
+++ b/meta/classes/siteinfo.bbclass
@@ -139,7 +139,8 @@ def siteinfo_get_files(d, no_cache = False):
if os.path.isdir(path_siteconfig):
for i in os.listdir(path_siteconfig):
filename = os.path.join(path_siteconfig, i)
- sitefiles += filename + " "
+ if os.path.exists(filename):
+ sitefiles += filename + " "
return sitefiles
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] siteinfo: add existiance check for site config file
2013-05-23 14:37 [PATCH] siteinfo: add existiance check for site config file Saul Wold
@ 2013-05-23 15:51 ` Saul Wold
2013-05-23 16:08 ` Mark Hatle
0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2013-05-23 15:51 UTC (permalink / raw)
Cc: openembedded-core
Ignore this patch, I was quick on the draw and did not notice the
listdir which means the file is there,
Sau!
On 05/23/2013 07:37 AM, Saul Wold wrote:
> There is a condition where ncurses adds a site config file to CONFIG_SITE list
> and then binutils configure tries to use the siteinfo list before ncurses has
> installed the file. The existance test is there in the BBPATH search, but not
> in the SYSROOTCACHE check, so add it here.
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> meta/classes/siteinfo.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/siteinfo.bbclass b/meta/classes/siteinfo.bbclass
> index 09f88c6..87a4225 100644
> --- a/meta/classes/siteinfo.bbclass
> +++ b/meta/classes/siteinfo.bbclass
> @@ -139,7 +139,8 @@ def siteinfo_get_files(d, no_cache = False):
> if os.path.isdir(path_siteconfig):
> for i in os.listdir(path_siteconfig):
> filename = os.path.join(path_siteconfig, i)
> - sitefiles += filename + " "
> + if os.path.exists(filename):
> + sitefiles += filename + " "
>
> return sitefiles
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] siteinfo: add existiance check for site config file
2013-05-23 15:51 ` Saul Wold
@ 2013-05-23 16:08 ` Mark Hatle
0 siblings, 0 replies; 3+ messages in thread
From: Mark Hatle @ 2013-05-23 16:08 UTC (permalink / raw)
To: openembedded-core
On 5/23/13 10:51 AM, Saul Wold wrote:
>
>
> Ignore this patch, I was quick on the draw and did not notice the
> listdir which means the file is there,
Could the issue be that the file -was- there, then we ncurses updated it and now
it's no longer there? (or in the process of being written?)
I've definitely seen this failure before.. so there is some kind of race.
--Mark
> Sau!
>
> On 05/23/2013 07:37 AM, Saul Wold wrote:
>> There is a condition where ncurses adds a site config file to CONFIG_SITE list
>> and then binutils configure tries to use the siteinfo list before ncurses has
>> installed the file. The existance test is there in the BBPATH search, but not
>> in the SYSROOTCACHE check, so add it here.
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>> meta/classes/siteinfo.bbclass | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/siteinfo.bbclass b/meta/classes/siteinfo.bbclass
>> index 09f88c6..87a4225 100644
>> --- a/meta/classes/siteinfo.bbclass
>> +++ b/meta/classes/siteinfo.bbclass
>> @@ -139,7 +139,8 @@ def siteinfo_get_files(d, no_cache = False):
>> if os.path.isdir(path_siteconfig):
>> for i in os.listdir(path_siteconfig):
>> filename = os.path.join(path_siteconfig, i)
>> - sitefiles += filename + " "
>> + if os.path.exists(filename):
>> + sitefiles += filename + " "
>>
>> return sitefiles
>>
>>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-23 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 14:37 [PATCH] siteinfo: add existiance check for site config file Saul Wold
2013-05-23 15:51 ` Saul Wold
2013-05-23 16:08 ` Mark Hatle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox