Re: [PATCH] tune-cortexa5.inc: add tune file for cortex-a5, based on a7

[Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>]

W dniu 03.06.2013 18:40, Andy Voltz pisze:
> Signed-off-by: Andy Voltz <andy.voltz@timesys.com>
> ---
>  meta/conf/machine/include/tune-cortexa5.inc |   36 +++++++++++++++++++++++++++

I think that it is time to create simple tune-cortex.inc which would be
used by cores tunes to set all of it.

So tune-cortexa5.inc would be:

----
CORTEX_ID   = "a5"
CORTEX_NAME = "A5"

require conf/machine/include/arm/tune-cortex.inc
----

and tune-cortex.inc will have things like:

----
DEFAULTTUNE ?= "armv7a-neon"

require conf/machine/include/arm/arch-armv7a.inc

TUNEVALID[cortex${CORTEX_ID}] = "Enable Cortex-${CORTEX_NAME} specific
processor optimizations"
TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES",
"cortex${CORTEX_ID}", " -mtune=cortex-${CORTEX_ID}", "", d)}"

# Little Endian base configs
AVAILTUNES += "cortex${CORTEX_ID} cortex${CORTEX_ID}t
cortex${CORTEX_ID}-neon cortex${CORTEX_ID}t-neon"
ARMPKGARCH_tune-cortex${CORTEX_ID} = "cortex${CORTEX_ID}"
ARMPKGARCH_tune-cortex${CORTEX_ID}t = "cortex${CORTEX_ID}"
ARMPKGARCH_tune-cortex${CORTEX_ID}-neon = "cortex${CORTEX_ID}"
ARMPKGARCH_tune-cortex${CORTEX_ID}t-neon = "cortex${CORTEX_ID}"
TUNE_FEATURES_tune-cortex${CORTEX_ID} = "${TUNE_FEATURES_tune-armv7a}
cortex${CORTEX_ID}"
TUNE_FEATURES_tune-cortex${CORTEX_ID}t = "${TUNE_FEATURES_tune-armv7at}
cortex${CORTEX_ID}"
TUNE_FEATURES_tune-cortex${CORTEX_ID}-neon =
"${TUNE_FEATURES_tune-armv7a-neon} cortex${CORTEX_ID}"
TUNE_FEATURES_tune-cortex${CORTEX_ID}t-neon =
"${TUNE_FEATURES_tune-armv7at-neon} cortex${CORTEX_ID}"
PACKAGE_EXTRA_ARCHS_tune-cortex${CORTEX_ID} =
"${PACKAGE_EXTRA_ARCHS_tune-armv7a} cortex${CORTEX_ID}-vfp"
PACKAGE_EXTRA_ARCHS_tune-cortex${CORTEX_ID}t =
"${PACKAGE_EXTRA_ARCHS_tune-armv7at} cortex${CORTEX_ID}-vfp
cortex${CORTEX_ID}t2-vfp"
PACKAGE_EXTRA_ARCHS_tune-cortex${CORTEX_ID}-neon =
"${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon} cortex${CORTEX_ID}-vfp
cortex${CORTEX_ID}-vfp-neon"
PACKAGE_EXTRA_ARCHS_tune-cortex${CORTEX_ID}t-neon =
"${PACKAGE_EXTRA_ARCHS_tune-armv7at-neon} cortex${CORTEX_ID}-vfp
cortex${CORTEX_ID}-vfp-neon cortex${CORTEX_ID}t2-vfp
cortex${CORTEX_ID}t2-vfp-neon"

[..]
-----

What do you think?