From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] tune-cortexa5.inc: add tune file for cortex-a5, based on a7
Date: Tue, 4 Jun 2013 16:01:52 -0500 [thread overview]
Message-ID: <51AE55C0.7010703@windriver.com> (raw)
In-Reply-To: <51AE4820.5010606@juszkiewicz.com.pl>
On 6/4/13 3:03 PM, Marcin Juszkiewicz wrote:
> W dniu 04.06.2013 21:57, Andy Voltz pisze:
>
>> I just tried this solution with my vybrid cortex-a5 build. The only issue is a
>> parse error on ${CORTEX_ID} here:
>>
>> TUNEVALID[cortex${CORTEX_ID}] = "Enable Cortex-${CORTEX_NAME} specific
>>
>> I amended the changes so that each tune-cortexa5.inc (for example) looks like:
>>
>> +CORTEX_ID = "a5"
>> +
>> +TUNEVALID[cortexa5] = "Enable Cortex-A5 specific processor optimizations"
>> +
>> +require conf/machine/include/tune-cortex.inc
>>
>> I didn't think it was worth having a CORTEX_NAME if TUNEVALID does not parse..
>
> Agree.
I had forgotten about this limitation. In a variable's [...] variable elements
are not extracted.
>> My only other thought is perhaps tune-cortex.inc should be called
>> tune-cortexa.inc? It seems like the m series is a different animal.
>
> Agree as well. M/R to be exact.
>
>> What do you think?
This seems reasonable to me.
--Mark
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2013-06-04 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.5041.1370320509.3521.openembedded-core@lists.openembedded.org>
2013-06-04 19:57 ` [PATCH] tune-cortexa5.inc: add tune file for cortex-a5, based on a7 Andy Voltz
2013-06-04 20:03 ` Marcin Juszkiewicz
2013-06-04 21:01 ` Mark Hatle [this message]
2013-06-03 16:40 Andy Voltz
2013-06-03 16:51 ` Otavio Salvador
2013-06-03 21:18 ` Marcin Juszkiewicz
2013-06-03 21:51 ` Otavio Salvador
2013-06-03 22:09 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AE55C0.7010703@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox