From: Saul Wold <sgw@linux.intel.com>
To: Nicolas Dechesne <nicolas.dechesne@linaro.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH dylan, master] Fix meta-toolchain-qte SDK build for x11-less DISTRO
Date: Wed, 05 Jun 2013 09:30:48 -0700 [thread overview]
Message-ID: <51AF67B8.20502@linux.intel.com> (raw)
In-Reply-To: <1370417067-30166-1-git-send-email-nicolas.dechesne@linaro.org>
On 06/05/2013 12:24 AM, Nicolas Dechesne wrote:
> When building QTe SDK for a DISTRO that does not have x11 FEATURES,
> building meta-toolchain-qte failed because it unconditionally pulls in
> nativesdk-libx11. The 'culprit' is meta/recipes-qt/qt4/nativesdk-qt4-tools.inc.
>
> The fix is inspired from the following commits:
>
> abf2ab7 dbus: only use x11 if DISTRO_FEATURES has selected it
> ba22cfa cairo: only use x11 if selected in DISTRO_FEATURES
>
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> ---
> meta/recipes-qt/qt4/nativesdk-qt4-tools.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> index cfc6fd8..3725cac 100644
> --- a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> +++ b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> @@ -1,5 +1,6 @@
> DESCRIPTION = "SDK tools for Qt/[X11|Mac|Embedded] version 4.x"
> -DEPENDS = "nativesdk-zlib nativesdk-dbus nativesdk-libx11 qt4-native"
> +X11DEPENDS = "nativesdk-libx11"
> +DEPENDS = "nativesdk-zlib nativesdk-dbus qt4-native ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
You could just directly put the nativesdk-libx11 in place of the
variable, no need to have the variable there.
Sau!
> SECTION = "libs"
> HOMEPAGE = "http://qt.nokia.com"
> LICENSE = "LGPLv2.1 | GPLv3"
>
next prev parent reply other threads:[~2013-06-05 16:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 7:24 [PATCH dylan, master] Fix meta-toolchain-qte SDK build for x11-less DISTRO Nicolas Dechesne
2013-06-05 16:30 ` Saul Wold [this message]
2013-06-05 16:32 ` Nicolas Dechesne
2013-06-05 16:58 ` Saul Wold
2013-06-05 17:12 ` Otavio Salvador
2013-06-05 17:19 ` Saul Wold
2013-06-05 17:23 ` Nicolas Dechesne
2013-06-05 17:43 ` Otavio Salvador
2013-06-05 20:07 ` Denys Dmytriyenko
2013-06-05 20:10 ` Otavio Salvador
2013-06-05 20:53 ` Saul Wold
2013-06-05 20:56 ` Otavio Salvador
2013-06-05 20:58 ` Denys Dmytriyenko
2013-06-06 15:46 ` Richard Purdie
2013-06-06 16:28 ` Otavio Salvador
2013-06-07 12:19 ` Nicolas Dechesne
2013-06-05 16:40 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF67B8.20502@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=nicolas.dechesne@linaro.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox