Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Jonathan Liu <net147@gmail.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] qmake2.bbclass: export OE_QMAKE_QT_CONFIG
Date: Wed, 12 Jun 2013 09:46:22 +1000	[thread overview]
Message-ID: <51B7B6CE.8040301@gmail.com> (raw)
In-Reply-To: <2653566.bBSFCXsGIZ@helios>

On 6/06/2013 3:04 AM, Paul Eggleton wrote:
> On Wednesday 05 June 2013 17:57:32 Paul Eggleton wrote:
>> On Wednesday 05 June 2013 09:46:49 Saul Wold wrote:
>>> On 06/05/2013 02:30 AM, Martin Jansa wrote:
>>>> On Wed, Jun 05, 2013 at 07:01:50PM +1000, Jonathan Liu wrote:
>>>>> qconfig.pri was not being loaded by qmake properly. This means Qt
>>>>> qmake projects are unable to query QT_ARCH, QT_VERSION and other
>>>>> variables defined in qconfig.pri.
>>>>>
>>>>> Export OE_QMAKE_QT_CONFIG, setting it to the location of qconfig.pri
>>>>> so that it can be located by qmake.
>>>> There is such patch already:
>>>> http://lists.openembedded.org/pipermail/openembedded-core/2013-May/07831
>>>> 4.
>>>> html
>>> Got lost in my queue, adding it for the next MUT.
>> FWIW I am still concerned by the assertion in the commit message about it
>> causing undesirable behaviour. I'd want that checked out and the note
>> removed before we look at merging this.
> (I mean undesirable behaviour on rebuild after applying this patch; I should
> mention I'm testing this at the moment.)
>
> Cheers,
> Paul
>
Looks like this was missed in the last pull.

Regards,
Jonathan


  parent reply	other threads:[~2013-06-11 23:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05  9:01 [PATCH] qmake2.bbclass: export OE_QMAKE_QT_CONFIG Jonathan Liu
2013-06-05  9:30 ` Martin Jansa
2013-06-05 16:46   ` Saul Wold
2013-06-05 16:57     ` Paul Eggleton
2013-06-05 17:01       ` Saul Wold
2013-06-06  9:54         ` Paul Eggleton
2013-06-06 19:18           ` Felipe Tonello
2013-06-06 20:06             ` Saul Wold
2013-06-06 23:17               ` Jonathan Liu
2013-06-06 23:31                 ` Martin Jansa
2013-06-10  5:09                   ` Jonathan Liu
2013-06-05 17:04       ` Paul Eggleton
2013-06-06  3:11         ` Jonathan Liu
2013-06-06 12:23           ` Otavio Salvador
2013-06-11 23:46         ` Jonathan Liu [this message]
2013-06-13 15:20           ` Saul Wold
2013-06-13 23:35             ` Jonathan Liu
2013-06-13 23:51               ` Saul Wold
2013-06-14 18:15                 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B7B6CE.8040301@gmail.com \
    --to=net147@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox