Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: Paul Barker <paul@paulbarker.me.uk>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/3 v2] sanity.bbclass: Check for the known broken version of make
Date: Fri, 28 Jun 2013 08:13:55 -0500	[thread overview]
Message-ID: <51CD8C13.2070409@windriver.com> (raw)
In-Reply-To: <CANyK_8eBqvC7nSKzE8Dg2imQ31+_9RdGqB5_GbuKB6YSaHw04w@mail.gmail.com>

On 6/28/13 5:20 AM, Paul Barker wrote:
> On 27 June 2013 15:21, Burton, Ross <ross.burton@intel.com> wrote:
>> On 27 June 2013 15:08, Mark Hatle <mark.hatle@windriver.com> wrote:
>>> See GNU Savannah bug 30612 -- make 3.82 is known to be broken.
>>>
>>> A number of vendors are providing a modified version, so checking
>>> for just the version string is not enough.  We also need to check
>>> if the patch for the issue has been applied.  We use a modified
>>> version of the reproduced to check for the issue.
>>>
>>> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
>>
>> Verified that this detects the 3.82 in Debian's experimental
>> repository that is well and truly broken.
>>
>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>>
>
> This picks out the current version of make in Arch Linux as broken
> despite it having a patch for bug #30612. I'm not sure if this is
> intended, could be that the applied patch isn't a complete fix. I
> don't have time to dig into this, just thought it'd be useful to you
> to know.

This is exactly why the check is being done.  From what I found there are a 
number of make versions on various distros that only have partial fixes for bug 
30612.

For the RedHat/Fedora bug I filed, see:
  https://bugzilla.redhat.com/show_bug.cgi?id=975597

The test case, and a patch to the missing commit are listed.

 
http://git.savannah.gnu.org/cgit/make.git/commit/?id=b06b8c64a29a5ba3a8daecd829fa2f98d42cb285

> If you know what fix you're looking for, the applied patches and build
> script can be seen at
> https://projects.archlinux.org/svntogit/packages.git/tree/trunk?h=packages/make

Looking at that list, it appears the commit referenced above is indeed the one 
missing.

--Mark

> Thanks,
>
> --
> Paul Barker
>
> Email: paul@paulbarker.me.uk
> http://www.paulbarker.me.uk
>



  reply	other threads:[~2013-06-28 13:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 14:08 [PATCH 1/3 v2] sanity.bbclass: Check for the known broken version of make Mark Hatle
2013-06-27 14:21 ` Burton, Ross
2013-06-28 10:20   ` Paul Barker
2013-06-28 13:13     ` Mark Hatle [this message]
2013-06-28 15:11       ` Paul Barker
2013-06-28 18:22         ` Paul Barker
2013-06-30 15:56 ` Trevor Woerner
2013-06-30 16:02   ` Philip Balister
2013-06-30 22:55     ` Trevor Woerner
2013-07-08 16:55     ` Mark Hatle
2013-07-09 15:14       ` Trevor Woerner
2013-07-19  9:41         ` Paul Eggleton
2013-07-21 13:27           ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CD8C13.2070409@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul@paulbarker.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox