From: Saul Wold <sgw@linux.intel.com>
To: "Shakeel, Muhammad" <muhammad_shakeel@mentor.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof
Date: Thu, 25 Jul 2013 09:43:43 -0700 [thread overview]
Message-ID: <51F155BF.8040301@linux.intel.com> (raw)
In-Reply-To: <1374746524-18179-1-git-send-email-muhammad_shakeel@mentor.com>
On 07/25/2013 03:02 AM, Shakeel, Muhammad wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> 'pidof' is alternatively coming from busybox so no need for avahi to explicitly
> rdepend on sysvinit-pidof. This unnecessarily includes sysvinit in systemd only
> build.
>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> ---
> meta/recipes-connectivity/avahi/avahi.inc | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/meta/recipes-connectivity/avahi/avahi.inc b/meta/recipes-connectivity/avahi/avahi.inc
> index c302f87..7bb5381 100644
> --- a/meta/recipes-connectivity/avahi/avahi.inc
> +++ b/meta/recipes-connectivity/avahi/avahi.inc
> @@ -96,8 +96,6 @@ FILES_libavahi-glib = "${libdir}/libavahi-glib.so.*"
> FILES_libavahi-gobject = "${libdir}/libavahi-gobject.so.*"
> FILES_avahi-utils = "${bindir}/avahi-*"
>
> -RDEPENDS_avahi-daemon = "sysvinit-pidof"
> -
I am sure there was a reason that the sysvinit version of pidof was
required over the busybox, did you test that the busybox version works
correctly in both systemd and sysvinit usages?
It maybe that the busybox version now work correctly.
Also as Paul pointed out, this is an RDEPENDS on a single package not
all the sysvinit packages.
Sau!
> # uclibc has no nss
> RRECOMMENDS_avahi-daemon_append_libc-glibc = "libnss-mdns"
> RRECOMMENDS_${PN}_append_libc-glibc = "libnss-mdns"
>
next prev parent reply other threads:[~2013-07-25 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 10:02 [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof Shakeel, Muhammad
2013-07-25 11:08 ` Paul Eggleton
2013-07-25 16:43 ` Saul Wold [this message]
2013-07-30 7:58 ` Muhammad Shakeel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F155BF.8040301@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=muhammad_shakeel@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox