From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof
Date: Tue, 30 Jul 2013 12:58:06 +0500 [thread overview]
Message-ID: <51F7720E.2000206@mentor.com> (raw)
In-Reply-To: <51F155BF.8040301@linux.intel.com>
On 07/25/2013 09:43 PM, Saul Wold wrote:
> On 07/25/2013 03:02 AM, Shakeel, Muhammad wrote:
>> -RDEPENDS_avahi-daemon = "sysvinit-pidof"
>> -
> I am sure there was a reason that the sysvinit version of pidof was
> required over the busybox, did you test that the busybox version works
> correctly in both systemd and sysvinit usages?
>
> It maybe that the busybox version now work correctly.
>
> Also as Paul pointed out, this is an RDEPENDS on a single package not
> all the sysvinit packages.
>
> Sau!
>
I have tested that pidof from busybox works fine for both systemd and
sysvinit and also avahi-daemon works fine with this.
Also sysvinit is rdepending on 'sysvinit-pidof' and for sysvinit systems
pidof will always come from inside it. It is only systemd enabled
systems which will get pidof from busybox and it seems to be working fine.
I have tried to track it that why this rdepend was added for avahi
daemon. It was added back in May 2007 but commit
(1641c2bd2c71bb08de7057b052ae74c00eedb330) message doesn't have any more
detail. I am sure that pidof from busybox is much more stable now.
This is definitely installing only 'sysvinit-pidof' but I was of the
opinion that if we can avoid all of sysvinit for systemd only build,
given that it is not impacting any of the functionality, then it will be
nice. IMHO, we should try to prevent as many unnecessary bits from
build/image as possible.
Regards,
Shakeel
prev parent reply other threads:[~2013-07-30 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 10:02 [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof Shakeel, Muhammad
2013-07-25 11:08 ` Paul Eggleton
2013-07-25 16:43 ` Saul Wold
2013-07-30 7:58 ` Muhammad Shakeel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7720E.2000206@mentor.com \
--to=muhammad_shakeel@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox