Re: [PATCH 3/3] ofono: Enable test scripts by default

[Saul Wold <sgw@linux.intel.com>]

On 07/26/2013 05:35 AM, Jukka Rissanen wrote:
> oFono test scripts are very useful so enable those by default.
>
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> ---
>   meta/recipes-connectivity/ofono/ofono.inc     | 3 ++-
>   meta/recipes-connectivity/ofono/ofono_1.12.bb | 3 ---
>   2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-connectivity/ofono/ofono.inc b/meta/recipes-connectivity/ofono/ofono.inc
> index d825496..c5bd4d0 100644
> --- a/meta/recipes-connectivity/ofono/ofono.inc
> +++ b/meta/recipes-connectivity/ofono/ofono.inc
> @@ -15,6 +15,7 @@ INITSCRIPT_PARAMS = "defaults 22"
>   EXTRA_OECONF += "\
>       ${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemdunitdir=${systemd_unitdir}/system/', '--with-systemdunitdir=', d)} \
>       ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth', '--disable-bluetooth', d)} \
> +    --enable-test \
>   "
>   SYSTEMD_SERVICE_${PN} = "ofono.service"
>
> @@ -30,5 +31,5 @@ PACKAGES =+ "${PN}-tests"
>   RDEPENDS_${PN} += "dbus"
>
>   FILES_${PN} += "${base_libdir}/udev ${systemd_unitdir}"
> -FILES_${PN}-tests = "${libdir}/ofono"
> +FILES_${PN}-tests = "${libdir}/${BPN}/test"
I think you should be using the ptest here instead of test and inherit 
ptest, please see the ptest.bbclass.

I realize that this is not new code, but if we are going to changes this 
we should use the new ptest mechanism.

Sau!

>   RDEPENDS_${PN}-tests = "python python-pygobject python-dbus"
> diff --git a/meta/recipes-connectivity/ofono/ofono_1.12.bb b/meta/recipes-connectivity/ofono/ofono_1.12.bb
> index 32c8bc2..ad524a0 100644
> --- a/meta/recipes-connectivity/ofono/ofono_1.12.bb
> +++ b/meta/recipes-connectivity/ofono/ofono_1.12.bb
> @@ -12,7 +12,4 @@ PR = "r2"
>   SRC_URI[md5sum] = "aa8924c0e8de3ec7ac5e41fe7df4cb99"
>   SRC_URI[sha256sum] = "733b75bfd1b2a1925b6de532989c496b8ae17a746691120ef64cceb00b3ef751"
>
> -EXTRA_OECONF += "\
> -    --enable-test \
> -"
>   CFLAGS_append_libc-uclibc = " -D_GNU_SOURCE"
>