From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
To: Muhammad Shakeel <muhammad_shakeel@mentor.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] ofono: Add systemd support
Date: Tue, 30 Jul 2013 13:30:00 +0300 [thread overview]
Message-ID: <51F795A8.1060207@linux.intel.com> (raw)
In-Reply-To: <51F6392F.60004@mentor.com>
On 29.07.2013 12:43, Muhammad Shakeel wrote:
> On 07/26/2013 05:35 PM, Jukka Rissanen wrote:
>> do_install_append() {
>> - install -d ${D}${sysconfdir}/init.d/
>> - install -m 0755 ${WORKDIR}/ofono ${D}${sysconfdir}/init.d/ofono
>> + if
>> ${@base_contains('DISTRO_FEATURES','sysvinit','true','false',d)}; then
>> + install -d ${D}${sysconfdir}/init.d/
>> + install -m 0755 ${WORKDIR}/ofono ${D}${sysconfdir}/init.d/ofono
>> + fi
>> }
>> PACKAGES =+ "${PN}-tests"
> We won't need above 'sysvinit' check as we are trying to implement this
> for all packages through systemd class. Please see this:
> http://patches.openembedded.org/patch/54671/
There is an issue here as I am using ofono.inc in separate ofono recipe
where I do not have ofono init script.
In that case I need to move the do_install_append() from ofono.inc to
ofono_1.12.bb file in order to reuse the ofono.inc.
I will send v2 after your patchset is committed.
Cheers,
Jukka
next prev parent reply other threads:[~2013-07-30 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 12:35 [PATCH 0/3] ofono fixes Jukka Rissanen
2013-07-26 12:35 ` [PATCH 1/3] ofono: Add systemd support Jukka Rissanen
2013-07-29 9:43 ` Muhammad Shakeel
2013-07-30 10:30 ` Jukka Rissanen [this message]
2013-07-30 14:37 ` Saul Wold
2013-07-26 12:35 ` [PATCH 2/3] ofono: Enable bluetooth automatically Jukka Rissanen
2013-07-26 12:35 ` [PATCH 3/3] ofono: Enable test scripts by default Jukka Rissanen
2013-07-26 18:52 ` Saul Wold
2013-07-29 6:51 ` Jukka Rissanen
2013-07-29 8:26 ` Burton, Ross
2013-07-26 15:43 ` [PATCH 0/3] ofono fixes Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F795A8.1060207@linux.intel.com \
--to=jukka.rissanen@linux.intel.com \
--cc=muhammad_shakeel@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox