Enabling x264 support in gstreamer

Enabling x264 support in gstreamer

[Gary Thomas]

I see that some of the gstreamer recipes have changed so that x264
is now a PACKAGECONFIG option.  However, I don't see anything that
enables this option anywhere.

How do I get x264 support back - it was working with Poky/Yocto
just a few weeks back...

Note: I have imported meta-oe/recipes-multimedia/x264 from meta-openembedded
into my layers for this [library] package.

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: Enabling x264 support in gstreamer

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

On Tue, Aug 13, 2013 at 11:29:10AM -0600, Gary Thomas wrote:
> I see that some of the gstreamer recipes have changed so that x264
> is now a PACKAGECONFIG option.  However, I don't see anything that
> enables this option anywhere.
> 
> How do I get x264 support back - it was working with Poky/Yocto
> just a few weeks back...
> 
> Note: I have imported meta-oe/recipes-multimedia/x264 from meta-openembedded
> into my layers for this [library] package.

Add x264 to PACKAGECONFIG in your .bbappend or distro config as
PACKAGECONFIG_append_pn-gst-foo = " x264"

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: Enabling x264 support in gstreamer

[Gary Thomas]

On 2013-08-13 11:36, Martin Jansa wrote:
> On Tue, Aug 13, 2013 at 11:29:10AM -0600, Gary Thomas wrote:
>> I see that some of the gstreamer recipes have changed so that x264
>> is now a PACKAGECONFIG option.  However, I don't see anything that
>> enables this option anywhere.
>>
>> How do I get x264 support back - it was working with Poky/Yocto
>> just a few weeks back...
>>
>> Note: I have imported meta-oe/recipes-multimedia/x264 from meta-openembedded
>> into my layers for this [library] package.
>
> Add x264 to PACKAGECONFIG in your .bbappend or distro config as
> PACKAGECONFIG_append_pn-gst-foo = " x264"

Thanks, although this seems very cumbersome to me.  Is this the only
(or at least expected) way for this to work?

I didn't find the section in the manual that discusses this to be very
enlightening.  It tells me *how* to use PACKAGECONFIG in a recipe but
not really *why* nor how to control it in a build/image/distro.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: Enabling x264 support in gstreamer

[Phil Blundell]

On Tue, 2013-08-13 at 13:26 -0600, Gary Thomas wrote:
> On 2013-08-13 11:36, Martin Jansa wrote:
> > On Tue, Aug 13, 2013 at 11:29:10AM -0600, Gary Thomas wrote:
> >> I see that some of the gstreamer recipes have changed so that x264
> >> is now a PACKAGECONFIG option.  However, I don't see anything that
> >> enables this option anywhere.
> >>
> >> How do I get x264 support back - it was working with Poky/Yocto
> >> just a few weeks back...
> >>
> >> Note: I have imported meta-oe/recipes-multimedia/x264 from meta-openembedded
> >> into my layers for this [library] package.
> >
> > Add x264 to PACKAGECONFIG in your .bbappend or distro config as
> > PACKAGECONFIG_append_pn-gst-foo = " x264"
> 
> Thanks, although this seems very cumbersome to me.  Is this the only
> (or at least expected) way for this to work?

Well, if it's in a .bbappend (rather than distro.conf) then you don't
need the _append_pn-gst-foo bit, you can just write

PACKAGECONFIG += "x264"

which is probably a bit neater and more intuitive.  But if you don't
already have a .bbappend for that recipe then you might not want to add
one just for that, it's just a matter of taste which you prefer.

Other than that, yes, this is basically how PACKAGECONFIG is intended to
be used.  Some recipes set a default PACKAGECONFIG based on
DISTRO_FEATURES, but in the general case it's just a variable that you
need to set appropriately.

The thing that's a bit unsatisfactory about this approach is that we
don't have any equivalent to DISTRO_FEATURES_BACKFILL for recipe-local
PACKAGECONFIG options, which means that introducing new switches for
things that were previously default-on tends to cause unexpected
breakage of the sort that you've observed.  It would be good to figure
out a better way of dealing with that.

p.

Re: Enabling x264 support in gstreamer

[Paul Eggleton]

On Tuesday 13 August 2013 20:36:09 Phil Blundell wrote:
> On Tue, 2013-08-13 at 13:26 -0600, Gary Thomas wrote:
> > On 2013-08-13 11:36, Martin Jansa wrote:
> > > On Tue, Aug 13, 2013 at 11:29:10AM -0600, Gary Thomas wrote:
> > >> I see that some of the gstreamer recipes have changed so that x264
> > >> is now a PACKAGECONFIG option.  However, I don't see anything that
> > >> enables this option anywhere.
> > >> 
> > >> How do I get x264 support back - it was working with Poky/Yocto
> > >> just a few weeks back...
> > >> 
> > >> Note: I have imported meta-oe/recipes-multimedia/x264 from
> > >> meta-openembedded into my layers for this [library] package.
> > > 
> > > Add x264 to PACKAGECONFIG in your .bbappend or distro config as
> > > PACKAGECONFIG_append_pn-gst-foo = " x264"
> > 
> > Thanks, although this seems very cumbersome to me.  Is this the only
> > (or at least expected) way for this to work?
> 
> Well, if it's in a .bbappend (rather than distro.conf) then you don't
> need the _append_pn-gst-foo bit, you can just write
> 
> PACKAGECONFIG += "x264"
> 
> which is probably a bit neater and more intuitive.  But if you don't
> already have a .bbappend for that recipe then you might not want to add
> one just for that, it's just a matter of taste which you prefer.
> 
> Other than that, yes, this is basically how PACKAGECONFIG is intended to
> be used.  Some recipes set a default PACKAGECONFIG based on
> DISTRO_FEATURES, but in the general case it's just a variable that you
> need to set appropriately.
> 
> The thing that's a bit unsatisfactory about this approach is that we
> don't have any equivalent to DISTRO_FEATURES_BACKFILL for recipe-local
> PACKAGECONFIG options, which means that introducing new switches for
> things that were previously default-on tends to cause unexpected
> breakage of the sort that you've observed.  It would be good to figure
> out a better way of dealing with that.

The thing is for the option in question wasn't default-on before, it was 
silently on or off depending on the availability of x264. Since x264 was 
unavailable to most users of OE-Core alone the correct thing to do was to 
default it to off, so backfilling couldn't have helped here.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: Enabling x264 support in gstreamer

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]

On Tue, Aug 13, 2013 at 08:36:09PM +0100, Phil Blundell wrote:
> On Tue, 2013-08-13 at 13:26 -0600, Gary Thomas wrote:
> > On 2013-08-13 11:36, Martin Jansa wrote:
> > > On Tue, Aug 13, 2013 at 11:29:10AM -0600, Gary Thomas wrote:
> > >> I see that some of the gstreamer recipes have changed so that x264
> > >> is now a PACKAGECONFIG option.  However, I don't see anything that
> > >> enables this option anywhere.
> > >>
> > >> How do I get x264 support back - it was working with Poky/Yocto
> > >> just a few weeks back...
> > >>
> > >> Note: I have imported meta-oe/recipes-multimedia/x264 from meta-openembedded
> > >> into my layers for this [library] package.
> > >
> > > Add x264 to PACKAGECONFIG in your .bbappend or distro config as
> > > PACKAGECONFIG_append_pn-gst-foo = " x264"
> > 
> > Thanks, although this seems very cumbersome to me.  Is this the only
> > (or at least expected) way for this to work?
> 
> Well, if it's in a .bbappend (rather than distro.conf) then you don't
> need the _append_pn-gst-foo bit, you can just write
> 
> PACKAGECONFIG += "x264"
> 
> which is probably a bit neater and more intuitive.  But if you don't
> already have a .bbappend for that recipe then you might not want to add
> one just for that, it's just a matter of taste which you prefer.
> 
> Other than that, yes, this is basically how PACKAGECONFIG is intended to
> be used.  Some recipes set a default PACKAGECONFIG based on
> DISTRO_FEATURES, but in the general case it's just a variable that you
> need to set appropriately.
> 
> The thing that's a bit unsatisfactory about this approach is that we
> don't have any equivalent to DISTRO_FEATURES_BACKFILL for recipe-local
> PACKAGECONFIG options, which means that introducing new switches for
> things that were previously default-on tends to cause unexpected
> breakage of the sort that you've observed.  It would be good to figure
> out a better way of dealing with that.

Well on this case x264 cannot be enabled in gst-* recipe in oe-core,
because x264 is in different layer.

The old behavior Gary was depending on wasn't deterministic as x264 was
enabled only when he built x264 before gst-*.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: Enabling x264 support in gstreamer

[Mark Hatle]

On 8/13/13 12:29 PM, Gary Thomas wrote:
> I see that some of the gstreamer recipes have changed so that x264
> is now a PACKAGECONFIG option.  However, I don't see anything that
> enables this option anywhere.
>
> How do I get x264 support back - it was working with Poky/Yocto
> just a few weeks back...
>
> Note: I have imported meta-oe/recipes-multimedia/x264 from meta-openembedded
> into my layers for this [library] package.

I havn't worked with this myself, but my guess is.  In your distribution.conf 
file (or your local.conf):

PACKAGECONFIG_gst-plugins-ugly = "x264"

or

PACKAGECONFIG_gstreamer1.0-plugins-ugly = "a52dec lame mad mpeg2dec x264"

> Thanks
>

Re: Enabling x264 support in gstreamer

[Paul Eggleton]

On Tuesday 13 August 2013 12:37:19 Mark Hatle wrote:
> On 8/13/13 12:29 PM, Gary Thomas wrote:
> > I see that some of the gstreamer recipes have changed so that x264
> > is now a PACKAGECONFIG option.  However, I don't see anything that
> > enables this option anywhere.
> > 
> > How do I get x264 support back - it was working with Poky/Yocto
> > just a few weeks back...
> > 
> > Note: I have imported meta-oe/recipes-multimedia/x264 from
> > meta-openembedded into my layers for this [library] package.
> 
> I havn't worked with this myself, but my guess is.  In your
> distribution.conf file (or your local.conf):
> 
> PACKAGECONFIG_gst-plugins-ugly = "x264"
> 
> or
> 
> PACKAGECONFIG_gstreamer1.0-plugins-ugly = "a52dec lame mad mpeg2dec x264"

You missed out the "pn-" which is necessary for such per-recipe overrides to 
work. The correct examples would be:

PACKAGECONFIG_pn-gst-plugins-ugly = "x264"
 
or

PACKAGECONFIG_pn-gstreamer1.0-plugins-ugly = "a52dec lame mad mpeg2dec x264"

If preferred you could use ..._append_pn-... = " x264" to add to the existing 
options rather than setting them outright.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre