* [PATCH 1/1] coreutils: allow for acl support
@ 2013-08-13 21:20 Joe Slater
2013-08-13 21:47 ` Saul Wold
0 siblings, 1 reply; 4+ messages in thread
From: Joe Slater @ 2013-08-13 21:20 UTC (permalink / raw)
To: openembedded-core
CQID: 430353
Define PACKAGECONFIG info for acl assuming it
might be a DISTRO_FEATURE.
Signed-off-by: Joe Slater <jslater@windriver.com>
---
meta/recipes-core/coreutils/coreutils_8.21.bb | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-core/coreutils/coreutils_8.21.bb b/meta/recipes-core/coreutils/coreutils_8.21.bb
index 26ada48..e784329 100644
--- a/meta/recipes-core/coreutils/coreutils_8.21.bb
+++ b/meta/recipes-core/coreutils/coreutils_8.21.bb
@@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
LICENSE = "GPLv3+"
LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
-PR = "r0"
+PR = "r1"
DEPENDS = "gmp libcap"
DEPENDS_class-native = ""
@@ -22,8 +22,16 @@ SRC_URI = "${GNU_MIRROR}/coreutils/${BP}.tar.xz \
SRC_URI[md5sum] = "065ba41828644eca5dd8163446de5d64"
SRC_URI[sha256sum] = "adaa44bdab3fa5eb352e80d8a31fdbf957b78653d0c2cd30d63e161444288e18"
-EXTRA_OECONF = "--disable-acl"
-EXTRA_OECONF_class-native = "--disable-acl --without-gmp"
+EXTRA_OECONF_class-native = "--without-gmp"
+
+# acl is not a default feature
+#
+PACKAGECONFIG_class-target ??= "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
+PACKAGECONFIG_class-native ??= ""
+
+# with, without, depends, rdepends
+#
+PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
# [ df mktemp base64 gets a special treatment and is not included in this
bindir_progs = "basename chcon cksum comm csplit cut dir dircolors dirname du \
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] coreutils: allow for acl support
2013-08-13 21:20 [PATCH 1/1] coreutils: allow for acl support Joe Slater
@ 2013-08-13 21:47 ` Saul Wold
2013-08-14 2:12 ` Slater, Joseph
2013-08-15 6:00 ` Saul Wold
0 siblings, 2 replies; 4+ messages in thread
From: Saul Wold @ 2013-08-13 21:47 UTC (permalink / raw)
To: Joe Slater; +Cc: openembedded-core
On 08/13/2013 02:20 PM, Joe Slater wrote:
> CQID: 430353
>
> Define PACKAGECONFIG info for acl assuming it
> might be a DISTRO_FEATURE.
>
Thanks for the Patch!
Will you be doing the same for the GPLv2 version?
I guess this means we should be expecting a set of patches to enable
other recipes that have --disable-acl by default?
Thanks
Sau!
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
> meta/recipes-core/coreutils/coreutils_8.21.bb | 14 +++++++++++---
> 1 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/coreutils/coreutils_8.21.bb b/meta/recipes-core/coreutils/coreutils_8.21.bb
> index 26ada48..e784329 100644
> --- a/meta/recipes-core/coreutils/coreutils_8.21.bb
> +++ b/meta/recipes-core/coreutils/coreutils_8.21.bb
> @@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
> LICENSE = "GPLv3+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
> file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
> -PR = "r0"
> +PR = "r1"
> DEPENDS = "gmp libcap"
> DEPENDS_class-native = ""
>
> @@ -22,8 +22,16 @@ SRC_URI = "${GNU_MIRROR}/coreutils/${BP}.tar.xz \
> SRC_URI[md5sum] = "065ba41828644eca5dd8163446de5d64"
> SRC_URI[sha256sum] = "adaa44bdab3fa5eb352e80d8a31fdbf957b78653d0c2cd30d63e161444288e18"
>
> -EXTRA_OECONF = "--disable-acl"
> -EXTRA_OECONF_class-native = "--disable-acl --without-gmp"
> +EXTRA_OECONF_class-native = "--without-gmp"
> +
> +# acl is not a default feature
> +#
> +PACKAGECONFIG_class-target ??= "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
> +PACKAGECONFIG_class-native ??= ""
> +
> +# with, without, depends, rdepends
> +#
> +PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
>
> # [ df mktemp base64 gets a special treatment and is not included in this
> bindir_progs = "basename chcon cksum comm csplit cut dir dircolors dirname du \
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] coreutils: allow for acl support
2013-08-13 21:47 ` Saul Wold
@ 2013-08-14 2:12 ` Slater, Joseph
2013-08-15 6:00 ` Saul Wold
1 sibling, 0 replies; 4+ messages in thread
From: Slater, Joseph @ 2013-08-14 2:12 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core@lists.openembedded.org
> -----Original Message-----
> From: Saul Wold [mailto:sgw@linux.intel.com]
> Sent: Tuesday, August 13, 2013 2:48 PM
> To: Slater, Joseph
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/1] coreutils: allow for acl support
>
> On 08/13/2013 02:20 PM, Joe Slater wrote:
> > CQID: 430353
> >
> > Define PACKAGECONFIG info for acl assuming it
> > might be a DISTRO_FEATURE.
> >
>
> Thanks for the Patch!
>
> Will you be doing the same for the GPLv2 version?
I guess I should.
>
> I guess this means we should be expecting a set of patches to enable
> other recipes that have --disable-acl by default?
Yeah, but I might not know whether some recipes really never, ever,
want acl support enabled.
Joe
>
>
> Thanks
> Sau!
> > Signed-off-by: Joe Slater <jslater@windriver.com>
> > ---
> > meta/recipes-core/coreutils/coreutils_8.21.bb | 14 +++++++++++---
> > 1 files changed, 11 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/recipes-core/coreutils/coreutils_8.21.bb b/meta/recipes-
> core/coreutils/coreutils_8.21.bb
> > index 26ada48..e784329 100644
> > --- a/meta/recipes-core/coreutils/coreutils_8.21.bb
> > +++ b/meta/recipes-core/coreutils/coreutils_8.21.bb
> > @@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
> > LICENSE = "GPLv3+"
> > LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
> >
> file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
> > -PR = "r0"
> > +PR = "r1"
> > DEPENDS = "gmp libcap"
> > DEPENDS_class-native = ""
> >
> > @@ -22,8 +22,16 @@ SRC_URI = "${GNU_MIRROR}/coreutils/${BP}.tar.xz \
> > SRC_URI[md5sum] = "065ba41828644eca5dd8163446de5d64"
> > SRC_URI[sha256sum] =
> "adaa44bdab3fa5eb352e80d8a31fdbf957b78653d0c2cd30d63e161444288e18"
> >
> > -EXTRA_OECONF = "--disable-acl"
> > -EXTRA_OECONF_class-native = "--disable-acl --without-gmp"
> > +EXTRA_OECONF_class-native = "--without-gmp"
> > +
> > +# acl is not a default feature
> > +#
> > +PACKAGECONFIG_class-target ??= "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '',
> d)}"
> > +PACKAGECONFIG_class-native ??= ""
> > +
> > +# with, without, depends, rdepends
> > +#
> > +PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
> >
> > # [ df mktemp base64 gets a special treatment and is not included in this
> > bindir_progs = "basename chcon cksum comm csplit cut dir dircolors dirname du \
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] coreutils: allow for acl support
2013-08-13 21:47 ` Saul Wold
2013-08-14 2:12 ` Slater, Joseph
@ 2013-08-15 6:00 ` Saul Wold
1 sibling, 0 replies; 4+ messages in thread
From: Saul Wold @ 2013-08-15 6:00 UTC (permalink / raw)
Cc: Joe Slater, openembedded-core
On 08/13/2013 02:47 PM, Saul Wold wrote:
> On 08/13/2013 02:20 PM, Joe Slater wrote:
>> CQID: 430353
>>
>> Define PACKAGECONFIG info for acl assuming it
>> might be a DISTRO_FEATURE.
>>
>
> Thanks for the Patch!
>
> Will you be doing the same for the GPLv2 version?
>
> I guess this means we should be expecting a set of patches to enable
> other recipes that have --disable-acl by default?
>
>
> Thanks
> Sau!
>> Signed-off-by: Joe Slater <jslater@windriver.com>
>> ---
>> meta/recipes-core/coreutils/coreutils_8.21.bb | 14 +++++++++++---
>> 1 files changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/recipes-core/coreutils/coreutils_8.21.bb
>> b/meta/recipes-core/coreutils/coreutils_8.21.bb
>> index 26ada48..e784329 100644
>> --- a/meta/recipes-core/coreutils/coreutils_8.21.bb
>> +++ b/meta/recipes-core/coreutils/coreutils_8.21.bb
>> @@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
>> LICENSE = "GPLv3+"
>> LIC_FILES_CHKSUM =
>> "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
>>
>> file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
>>
>> -PR = "r0"
>> +PR = "r1"
I missed noticing this on the first round, please drop the PR Update
Thanks
Sau!
>> DEPENDS = "gmp libcap"
>> DEPENDS_class-native = ""
>>
>> @@ -22,8 +22,16 @@ SRC_URI = "${GNU_MIRROR}/coreutils/${BP}.tar.xz \
>> SRC_URI[md5sum] = "065ba41828644eca5dd8163446de5d64"
>> SRC_URI[sha256sum] =
>> "adaa44bdab3fa5eb352e80d8a31fdbf957b78653d0c2cd30d63e161444288e18"
>>
>> -EXTRA_OECONF = "--disable-acl"
>> -EXTRA_OECONF_class-native = "--disable-acl --without-gmp"
>> +EXTRA_OECONF_class-native = "--without-gmp"
>> +
>> +# acl is not a default feature
>> +#
>> +PACKAGECONFIG_class-target ??= "${@base_contains('DISTRO_FEATURES',
>> 'acl', 'acl', '', d)}"
>> +PACKAGECONFIG_class-native ??= ""
>> +
>> +# with, without, depends, rdepends
>> +#
>> +PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
>>
>> # [ df mktemp base64 gets a special treatment and is not included in
>> this
>> bindir_progs = "basename chcon cksum comm csplit cut dir dircolors
>> dirname du \
>>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-15 6:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-13 21:20 [PATCH 1/1] coreutils: allow for acl support Joe Slater
2013-08-13 21:47 ` Saul Wold
2013-08-14 2:12 ` Slater, Joseph
2013-08-15 6:00 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox