Re: [PATCH 1/4] [v3] openssh: Add systemd support

[Muhammad Shakeel <muhammad_shakeel@mentor.com>]

On 08/20/2013 02:00 AM, Saul Wold wrote:
> On 08/18/2013 11:40 PM, Khem Raj wrote:
>> On Sun, Aug 18, 2013 at 11:18 PM, Muhammad Shakeel
>> <muhammad_shakeel@mentor.com> wrote:
>>> /usr/sbin/ is being sed'ed with ${sbindir} in do_install_append of the
>>> respective recipe file. /usr/bin/ and /bin/ is also taken care of.
>>
>> i see, thats better. however I do see a need to have  a generalized
>> way of specifying service files and a generic
>> processing engine which then takes care of it. Otherwise we have the
>> same code replicated in multiple recipes
>
> Agreed, I think there should be a generalized solution here, 
> implemented in the systemd.bbclass.
This is not required for all of the systemd unit files. Packages which 
have upstream systemd support, e.g. avahi, ofono they install service 
file theirselves.
I have already discussed to move this 'sed' part into systemd.bbclass 
but Ross Burton had other ideas. 
http://patches.openembedded.org/patch/53489/

So what is your final recommendation here?

> It also appears that this set is also creating a /lib dir that should 
> not be there for non-systemd builds.
>
>> ERROR: Task 25 
>> (/home/sgw/yocto/poky/meta/recipes-extended/lighttpd/lighttpd_1.4.32.bb, 
>> do_package) failed with exit code '1'
>> ERROR: QA Issue: nfs-utils: Files/directories were installed but not 
>> shipped
>>   /lib
>> ERROR: QA run found fatal errors. Please consider fixing them.
>> ERROR: Function failed: do_package_qa
>> ERROR: Logfile of failure stored in: 
>> /home/sgw/yocto/builds/world/tmp/work/x86_64-poky-linux/nfs-utils/1.2.8-r0/temp/log.do_package.17558
Sorry about this error, I will fix this in next version.

Regards
--Shakeel