Re: [PATCH 1/4] [v3] openssh: Add systemd support

[Muhammad Shakeel <muhammad_shakeel@mentor.com>]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

On 08/16/2013 10:47 PM, Khem Raj wrote:
>
>
>
> On Fri, Aug 16, 2013 at 10:27 AM, Shakeel, Muhammad 
> <muhammad_shakeel@mentor.com <mailto:muhammad_shakeel@mentor.com>> wrote:
>
>     From: Muhammad Shakeel <muhammad_shakeel@mentor.com
>     <mailto:muhammad_shakeel@mentor.com>>
>
>     -Remove dependency on meta-systemd
>
>     +[Service]
>     +ExecStart=-/usr/sbin/sshd -i
>
>
>
> it would be nice if it was using libdir/bindir instead of hardcoded paths
> coudld be achieved by generating the unit files from some sort of .in 
> files at build time so it could benefit
> the distros which dont use /usr e.g.
> ​​
>
>     +       sed -i 's,/bin/,${base_bindir}/,g'
>     ${D}${systemd_unitdir}/system/sshd.socket
>     ${D}${systemd_unitdir}/system/sshd@.service
>     +       sed -i 's,/usr/sbin/,${sbindir}/,g'
>     ${D}${systemd_unitdir}/system/sshd@.service
>     +       sed -i 's,/usr/bin/,${bindir}/,g'
>     ${D}${systemd_unitdir}/system/sshdgenkeys.service
>
>
/usr/sbin/ is being sed'ed with ${sbindir} in do_install_append of the 
respective recipe file. /usr/bin/ and /bin/ is also taken care of.

Regards

[-- Attachment #2: Type: text/html, Size: 3361 bytes --]