From: Saul Wold <sgw@linux.intel.com>
To: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] grep-2.5.1a: fix grep for LSB compliance
Date: Mon, 26 Aug 2013 23:52:45 -0700 [thread overview]
Message-ID: <521C4CBD.3070506@linux.intel.com> (raw)
In-Reply-To: <521C2BDB.3020503@cn.fujitsu.com>
On 08/26/2013 09:32 PM, Li Zhijian wrote:
> ...skip... at 2013-8-27 9:00, Saul Wold wrote:
>>> diff --git a/meta/recipes-extended/grep/grep_2.5.1a.bb
>>> b/meta/recipes-extended/grep/grep_2.5.1a.bb index
>>> 088959c..d964d84 100644 ---
>>> a/meta/recipes-extended/grep/grep_2.5.1a.bb +++
>>> b/meta/recipes-extended/grep/grep_2.5.1a.bb @@ -5,7 +5,7 @@
>>> SECTION = "console/utils" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>>>
>>> -PR = "r2" +PR = "r3"
>>>
>>> SRC_URI = "${GNU_MIRROR}/grep/grep-${PV}.tar.bz2 \
>>> file://uclibc-fix.patch \ @@ -13,8 +13,25 @@ SRC_URI =
>>> "${GNU_MIRROR}/grep/grep-${PV}.tar.bz2 \ file://gettext.patch \
>>> file://fix64-int-to-pointer.patch \ file://Makevars \ -
>>> file://grep-CVE-2012-5667.patch \
>>
>> Why are you removing this patch?
>>
>> Will an update to 2.5.3 accomplish the same thing as these
>> patches?
>>
>> Also all of your patches above are missing Upstream-Status and
>> Signed-off-by:
>>
>> See the Patch Guildlines on OE-Core:
>> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
>>
>> Thanks
>>
>> Sau!
>>
>>
> ...skip...
>>> + file://grep-CVE-2012-5667.patch \
> ...skip...
>
> Thank a lots for your comments.
>
> This patch is not removed ,it is here ↑
>
> I don't know what's fixed bettwen 2.5.1a an 2.5.3, but grep-2.5.3
> LICENSE is GPLv3+ differed from 2.5.1a(GPLv2)
>
> The Guildlines is very helpful for me. But those patch is come from
> grep-2.5.1-55.el5.src.rpm and I have not research this patch's
> Upstream-Status and Signed-off-by So I am sorry about that
>
Please review the recipes and licenesing, since it seems the we might
have multiple versions and the license fields are incorrect for both.
If there are both v2 and v3 versions, we need to ensure which is correct.
Thanks
Sau!
> Thanks Li,
>
>
>
next prev parent reply other threads:[~2013-08-27 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 9:43 [PATCH] grep-2.5.1a: fix grep for LSB compliance Li Zhijian
2013-08-27 1:00 ` Saul Wold
2013-08-27 4:32 ` Li Zhijian
2013-08-27 6:52 ` Saul Wold [this message]
2013-08-28 6:16 ` Li Zhijian
2013-08-27 10:43 ` Phil Blundell
2013-08-28 5:47 ` Li Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521C4CBD.3070506@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox