From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Sean Nyekjaer <sean@geanix.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 2/2] zlib: minizip: add recipe
Date: Mon, 11 Jul 2022 09:46:58 +0100 [thread overview]
Message-ID: <5227282d05b0791d57457c44f63859a97001c6ab.camel@linuxfoundation.org> (raw)
In-Reply-To: <20220711083309.1749253-2-sean@geanix.com>
On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote:
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb
I can see what this does, but why? Who would want this and why? There
is no detail in the commit messages. Also no maintainers entry which
will break QA checks.
Cheers,
Richard
next prev parent reply other threads:[~2022-07-11 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 8:33 [OE-core] [PATCH 1/2] zlib: split src_uri into inc file Sean Nyekjaer
2022-07-11 8:33 ` [OE-core] [PATCH 2/2] zlib: minizip: add recipe Sean Nyekjaer
2022-07-11 8:46 ` Richard Purdie [this message]
2022-07-11 8:53 ` Sean Nyekjaer
2022-07-11 8:58 ` Richard Purdie
2022-07-11 19:29 ` Sean Nyekjaer
2022-07-11 18:07 ` [OE-core] [PATCH 1/2] zlib: split src_uri into inc file Khem Raj
2022-07-11 19:27 ` Sean Nyekjaer
2022-07-11 19:29 ` Khem Raj
2022-07-11 19:36 ` Sean Nyekjaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5227282d05b0791d57457c44f63859a97001c6ab.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox