Re: [OE-core] [PATCH 2/2] zlib: minizip: add recipe

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2022-07-11 at 10:53 +0200, Sean Nyekjaer wrote:
> On Mon, Jul 11, 2022 at 09:46:58AM +0100, Richard Purdie wrote:
> > On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote:
> > > Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> > > ---
> > >  meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++
> > >  1 file changed, 15 insertions(+)
> > >  create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb
> > 
> > I can see what this does, but why? Who would want this and why? There
> > is no detail in the commit messages. Also no maintainers entry which
> > will break QA checks.
> > 
> > Cheers,
> > 
> > Richard
> > 
> > 
> 
> Hi Richard,
> 
> We have some software that depends on minizip.
> I don't know if an extra package zlib-minizip or this was the prefered
> way to add it?

I think an extra package on the existing recipe may be simpler and
easier maintenance.

Commit messages do need a bit more information in them too, it isn't
enough to say what something does, it needs to say why.

Cheers,

Richard