[OE-core] [PATCH 1/2] zlib: split src_uri into inc file

[OE-core] [PATCH 1/2] zlib: split src_uri into inc file

[Sean Nyekjaer]

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 meta/recipes-core/zlib/zlib.inc       |  4 ++++
 meta/recipes-core/zlib/zlib_1.2.12.bb | 18 +++++++++---------
 2 files changed, 13 insertions(+), 9 deletions(-)
 create mode 100644 meta/recipes-core/zlib/zlib.inc

diff --git a/meta/recipes-core/zlib/zlib.inc b/meta/recipes-core/zlib/zlib.inc
new file mode 100644
index 0000000000..2bcc32071a
--- /dev/null
+++ b/meta/recipes-core/zlib/zlib.inc
@@ -0,0 +1,4 @@
+SRC_URI = "https://zlib.net/${BP}.tar.xz"
+UPSTREAM_CHECK_URI = "http://zlib.net/"
+
+SRC_URI[sha256sum] = "7db46b8d7726232a621befaab4a1c870f00a90805511c0e0090441dac57def18"
diff --git a/meta/recipes-core/zlib/zlib_1.2.12.bb b/meta/recipes-core/zlib/zlib_1.2.12.bb
index e921703137..ba986d8cf2 100644
--- a/meta/recipes-core/zlib/zlib_1.2.12.bb
+++ b/meta/recipes-core/zlib/zlib_1.2.12.bb
@@ -6,16 +6,16 @@ SECTION = "libs"
 LICENSE = "Zlib"
 LIC_FILES_CHKSUM = "file://zlib.h;beginline=6;endline=23;md5=5377232268e952e9ef63bc555f7aa6c0"
 
-SRC_URI = "https://zlib.net/${BP}.tar.xz \
-           file://cc.patch \
-           file://ldflags-tests.patch \
-           file://0001-configure-Pass-LDFLAGS-to-link-tests.patch \
-           file://run-ptest \
-           file://0001-Correct-incorrect-inputs-provided-to-the-CRC-functio.patch \
-           "
-UPSTREAM_CHECK_URI = "http://zlib.net/"
+include zlib.inc
+
+SRC_URI += "file://cc.patch \
+            file://ldflags-tests.patch \
+            file://0001-configure-Pass-LDFLAGS-to-link-tests.patch \
+            file://run-ptest \
+            file://0001-Correct-incorrect-inputs-provided-to-the-CRC-functio.patch \
+"
 
-SRC_URI[sha256sum] = "7db46b8d7726232a621befaab4a1c870f00a90805511c0e0090441dac57def18"
+UPSTREAM_CHECK_URI = "http://zlib.net/"
 
 CFLAGS += "-D_REENTRANT"
 
-- 
2.36.1

[OE-core] [PATCH 2/2] zlib: minizip: add recipe

[Sean Nyekjaer]

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb

diff --git a/meta/recipes-core/zlib/minizip_1.2.12.bb b/meta/recipes-core/zlib/minizip_1.2.12.bb
new file mode 100644
index 0000000000..548bb8c62b
--- /dev/null
+++ b/meta/recipes-core/zlib/minizip_1.2.12.bb
@@ -0,0 +1,15 @@
+SUMMARY = "Minimal zip library using deflate from zlib"
+HOMEPAGE = "http://zlib.net/"
+SECTION = "libs"
+LICENSE = "Zlib"
+LIC_FILES_CHKSUM = "file://MiniZip64_info.txt;beginline=53;endline=73;md5=02090b3a3511ed8a910b77dae6906cea"
+
+include zlib.inc
+
+inherit autotools
+
+DEPENDS = "zlib"
+
+S = "${WORKDIR}/zlib-${PV}/contrib/minizip"
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.36.1

Re: [OE-core] [PATCH 2/2] zlib: minizip: add recipe

[Richard Purdie]

On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote:
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
>  meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb

I can see what this does, but why? Who would want this and why? There
is no detail in the commit messages. Also no maintainers entry which
will break QA checks.

Cheers,

Richard

Re: [OE-core] [PATCH 2/2] zlib: minizip: add recipe

[Sean Nyekjaer]

On Mon, Jul 11, 2022 at 09:46:58AM +0100, Richard Purdie wrote:
> On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote:
> > Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> > ---
> >  meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb
> 
> I can see what this does, but why? Who would want this and why? There
> is no detail in the commit messages. Also no maintainers entry which
> will break QA checks.
> 
> Cheers,
> 
> Richard
> 
> 

Hi Richard,

We have some software that depends on minizip.
I don't know if an extra package zlib-minizip or this was the prefered
way to add it?

/Sean

Re: [OE-core] [PATCH 2/2] zlib: minizip: add recipe

[Richard Purdie]

On Mon, 2022-07-11 at 10:53 +0200, Sean Nyekjaer wrote:
> On Mon, Jul 11, 2022 at 09:46:58AM +0100, Richard Purdie wrote:
> > On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote:
> > > Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> > > ---
> > >  meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++
> > >  1 file changed, 15 insertions(+)
> > >  create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb
> > 
> > I can see what this does, but why? Who would want this and why? There
> > is no detail in the commit messages. Also no maintainers entry which
> > will break QA checks.
> > 
> > Cheers,
> > 
> > Richard
> > 
> > 
> 
> Hi Richard,
> 
> We have some software that depends on minizip.
> I don't know if an extra package zlib-minizip or this was the prefered
> way to add it?

I think an extra package on the existing recipe may be simpler and
easier maintenance.

Commit messages do need a bit more information in them too, it isn't
enough to say what something does, it needs to say why.

Cheers,

Richard

Re: [OE-core] [PATCH 1/2] zlib: split src_uri into inc file

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2501 bytes --]

We are in process of merging the inc files can you cite reasons why we want
to split it

On Mon, Jul 11, 2022 at 9:33 AM Sean Nyekjaer <sean@geanix.com> wrote:

> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
>  meta/recipes-core/zlib/zlib.inc       |  4 ++++
>  meta/recipes-core/zlib/zlib_1.2.12.bb | 18 +++++++++---------
>  2 files changed, 13 insertions(+), 9 deletions(-)
>  create mode 100644 meta/recipes-core/zlib/zlib.inc
>
> diff --git a/meta/recipes-core/zlib/zlib.inc
> b/meta/recipes-core/zlib/zlib.inc
> new file mode 100644
> index 0000000000..2bcc32071a
> --- /dev/null
> +++ b/meta/recipes-core/zlib/zlib.inc
> @@ -0,0 +1,4 @@
> +SRC_URI = "https://zlib.net/${BP}.tar.xz"
> +UPSTREAM_CHECK_URI = "http://zlib.net/"
> +
> +SRC_URI[sha256sum] =
> "7db46b8d7726232a621befaab4a1c870f00a90805511c0e0090441dac57def18"
> diff --git a/meta/recipes-core/zlib/zlib_1.2.12.bb
> b/meta/recipes-core/zlib/zlib_1.2.12.bb
> index e921703137..ba986d8cf2 100644
> --- a/meta/recipes-core/zlib/zlib_1.2.12.bb
> +++ b/meta/recipes-core/zlib/zlib_1.2.12.bb
> @@ -6,16 +6,16 @@ SECTION = "libs"
>  LICENSE = "Zlib"
>  LIC_FILES_CHKSUM =
> "file://zlib.h;beginline=6;endline=23;md5=5377232268e952e9ef63bc555f7aa6c0"
>
> -SRC_URI = "https://zlib.net/${BP}.tar.xz \
> -           file://cc.patch \
> -           file://ldflags-tests.patch \
> -           file://0001-configure-Pass-LDFLAGS-to-link-tests.patch \
> -           file://run-ptest \
> -
>  file://0001-Correct-incorrect-inputs-provided-to-the-CRC-functio.patch \
> -           "
> -UPSTREAM_CHECK_URI = "http://zlib.net/"
> +include zlib.inc
> +
> +SRC_URI += "file://cc.patch \
> +            file://ldflags-tests.patch \
> +            file://0001-configure-Pass-LDFLAGS-to-link-tests.patch \
> +            file://run-ptest \
> +
> file://0001-Correct-incorrect-inputs-provided-to-the-CRC-functio.patch \
> +"
>
> -SRC_URI[sha256sum] =
> "7db46b8d7726232a621befaab4a1c870f00a90805511c0e0090441dac57def18"
> +UPSTREAM_CHECK_URI = "http://zlib.net/"
>
>  CFLAGS += "-D_REENTRANT"
>
> --
> 2.36.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#167861):
> https://lists.openembedded.org/g/openembedded-core/message/167861
> Mute This Topic: https://lists.openembedded.org/mt/92305639/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 4363 bytes --]

Re: [OE-core] [PATCH 1/2] zlib: split src_uri into inc file

[Sean Nyekjaer]

On Mon, Jul 11, 2022 at 07:07:38PM +0100, Khem Raj wrote:
> We are in process of merging the inc files can you cite reasons why we want
> to split it
> 

@Khem:
Inside the zlib artifact resides a contrib directory that contains more
libs, one of them minizip are we using in our project.

/Sean

Re: [OE-core] [PATCH 1/2] zlib: split src_uri into inc file

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

On Mon, Jul 11, 2022 at 8:27 PM Sean Nyekjaer <sean@geanix.com> wrote:

> On Mon, Jul 11, 2022 at 07:07:38PM +0100, Khem Raj wrote:
> > We are in process of merging the inc files can you cite reasons why we
> want
> > to split it
> >
>
> @Khem:
> Inside the zlib artifact resides a contrib directory that contains more
> libs, one of them minizip are we using in our project.
>

Is it possible to use packageconfig for enabling this


> /Sean
>

[-- Attachment #2: Type: text/html, Size: 933 bytes --]

Re: [OE-core] [PATCH 2/2] zlib: minizip: add recipe

[Sean Nyekjaer]

On Mon, Jul 11, 2022 at 09:58:38AM +0100, Richard Purdie wrote:
> On Mon, 2022-07-11 at 10:53 +0200, Sean Nyekjaer wrote:
> > On Mon, Jul 11, 2022 at 09:46:58AM +0100, Richard Purdie wrote:
> > > On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote:
> > > > Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> > > > ---
> > > >  meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++
> > > >  1 file changed, 15 insertions(+)
> > > >  create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb
> > > 
> > > I can see what this does, but why? Who would want this and why? There
> > > is no detail in the commit messages. Also no maintainers entry which
> > > will break QA checks.
> > > 
> > > Cheers,
> > > 
> > > Richard
> > > 
> > > 
> > 
> > Hi Richard,
> > 
> > We have some software that depends on minizip.
> > I don't know if an extra package zlib-minizip or this was the prefered
> > way to add it?
> 
> I think an extra package on the existing recipe may be simpler and
> easier maintenance.
> 
> Commit messages do need a bit more information in them too, it isn't
> enough to say what something does, it needs to say why.
> 
> Cheers,
> 
> Richard

I think it will be quite hacky to do it as one recipe, as zlib and
minizip is to seperate autotools projects and zlib isn't even compatible
with the autotools class.
I could something with addtask but I don't think it will be very
readable.

Any ideas?

/Sean

Re: [OE-core] [PATCH 1/2] zlib: split src_uri into inc file

[Sean Nyekjaer]

On Mon, Jul 11, 2022 at 08:29:24PM +0100, Khem Raj wrote:
> On Mon, Jul 11, 2022 at 8:27 PM Sean Nyekjaer <sean@geanix.com> wrote:
> 
> > On Mon, Jul 11, 2022 at 07:07:38PM +0100, Khem Raj wrote:
> > > We are in process of merging the inc files can you cite reasons why we
> > want
> > > to split it
> > >
> >
> > @Khem:
> > Inside the zlib artifact resides a contrib directory that contains more
> > libs, one of them minizip are we using in our project.
> >
> 
> Is it possible to use packageconfig for enabling this
> 
> 

No it doesn't look like it :(