From: Saul Wold <sgw@linux.intel.com>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] python: fix failures of LSB python-runtime tests
Date: Sun, 15 Sep 2013 20:05:10 -0700 [thread overview]
Message-ID: <52367566.6060504@linux.intel.com> (raw)
In-Reply-To: <52365FE7.6000102@windriver.com>
On 09/15/2013 06:33 PM, Hongxu Jia wrote:
> On 09/16/2013 04:52 AM, Saul Wold wrote:
>> On 09/13/2013 09:31 PM, Hongxu Jia wrote:
>>> It has been fixed in:
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e261c1760d8a660c13cd00039a4812d51f47f3df
>>>
>>>
>>> But there is a typo in:
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
>>>
>>> It missed to remove an extra "--with-wctype-functions" in EXTRA_OECONF
>>>
>>> [YOCTO #5154]
>>>
>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>> ---
>>> meta/recipes-devtools/python/python.inc | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/python/python.inc
>>> b/meta/recipes-devtools/python/python.inc
>>> index 80609a8..fcfeda5 100644
>>> --- a/meta/recipes-devtools/python/python.inc
>>> +++ b/meta/recipes-devtools/python/python.inc
>>> @@ -25,7 +25,6 @@ EXTRA_OECONF = "\
>>> --with-cyclic-gc \
>>> --without-cxx \
>>> --with-signal-module \
>>> - --with-wctype-functions \
>> I think this needs to be protected with a linuxstdbase check.
>>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
> has done this, but missing to remove the extra ' --with-wctype-functions'
>
Sorry, I rushed the review of this and did not look at the big picture.
Your patch seems correct.
Sau!
> inherit autotools
>
> +PYTHONLSBOPTS = "--with-wctype-functions"
> +PYTHONLSBOPTS_linuxstdbase = "ac_cv_sizeof_off_t=8"
> +
> EXTRA_OECONF = "\
> --with-threads \
> --with-pymalloc \
> @@ -24,14 +27,5 @@ EXTRA_OECONF = "\
> --with-signal-module \
> --with-wctype-functions \
> --enable-shared \
> -"
> -
> -EXTRA_OECONF_linuxstdbase = "\
> - --with-threads \
> - --with-pymalloc \
> - --with-cyclic-gc \
> - --without-cxx \
> - --with-signal-module \
> - --enable-shared \
> - ac_cv_sizeof_off_t=8 \
> + ${PYTHONLSBOPTS} \
> "
>
> //Hongxu
>
>
>
>> Sau!
>>
>>> --enable-shared \
>>> --enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6', 'yes',
>>> 'no', d)} \
>>> ${PYTHONLSBOPTS} \
>>>
>
prev parent reply other threads:[~2013-09-16 3:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 4:31 [PATCH 0/1] python: fix failures of LSB python-runtime tests Hongxu Jia
2013-09-14 4:31 ` [PATCH 1/1] " Hongxu Jia
2013-09-15 20:52 ` Saul Wold
2013-09-16 1:33 ` Hongxu Jia
2013-09-16 3:05 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52367566.6060504@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=hongxu.jia@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox