* [PATCH 0/1] python: fix failures of LSB python-runtime tests
@ 2013-09-14 4:31 Hongxu Jia
2013-09-14 4:31 ` [PATCH 1/1] " Hongxu Jia
0 siblings, 1 reply; 5+ messages in thread
From: Hongxu Jia @ 2013-09-14 4:31 UTC (permalink / raw)
To: openembedded-core
The following changes since commit dd36930f3f37b2e0e1258de28ac1b1fa99cf196f:
bitbake: data_smart: Account for changes in append/prepend/remove in the config hash (2013-09-12 17:03:17 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib hongxu/fix-lsb-python
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-lsb-python
Hongxu Jia (1):
python: fix failures of LSB python-runtime tests
meta/recipes-devtools/python/python.inc | 1 -
1 file changed, 1 deletion(-)
--
1.8.1.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] python: fix failures of LSB python-runtime tests
2013-09-14 4:31 [PATCH 0/1] python: fix failures of LSB python-runtime tests Hongxu Jia
@ 2013-09-14 4:31 ` Hongxu Jia
2013-09-15 20:52 ` Saul Wold
0 siblings, 1 reply; 5+ messages in thread
From: Hongxu Jia @ 2013-09-14 4:31 UTC (permalink / raw)
To: openembedded-core
It has been fixed in:
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e261c1760d8a660c13cd00039a4812d51f47f3df
But there is a typo in:
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
It missed to remove an extra "--with-wctype-functions" in EXTRA_OECONF
[YOCTO #5154]
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
meta/recipes-devtools/python/python.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/recipes-devtools/python/python.inc b/meta/recipes-devtools/python/python.inc
index 80609a8..fcfeda5 100644
--- a/meta/recipes-devtools/python/python.inc
+++ b/meta/recipes-devtools/python/python.inc
@@ -25,7 +25,6 @@ EXTRA_OECONF = "\
--with-cyclic-gc \
--without-cxx \
--with-signal-module \
- --with-wctype-functions \
--enable-shared \
--enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6', 'yes', 'no', d)} \
${PYTHONLSBOPTS} \
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] python: fix failures of LSB python-runtime tests
2013-09-14 4:31 ` [PATCH 1/1] " Hongxu Jia
@ 2013-09-15 20:52 ` Saul Wold
2013-09-16 1:33 ` Hongxu Jia
0 siblings, 1 reply; 5+ messages in thread
From: Saul Wold @ 2013-09-15 20:52 UTC (permalink / raw)
To: Hongxu Jia; +Cc: openembedded-core
On 09/13/2013 09:31 PM, Hongxu Jia wrote:
> It has been fixed in:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e261c1760d8a660c13cd00039a4812d51f47f3df
>
> But there is a typo in:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
> It missed to remove an extra "--with-wctype-functions" in EXTRA_OECONF
>
> [YOCTO #5154]
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
> meta/recipes-devtools/python/python.inc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/python/python.inc b/meta/recipes-devtools/python/python.inc
> index 80609a8..fcfeda5 100644
> --- a/meta/recipes-devtools/python/python.inc
> +++ b/meta/recipes-devtools/python/python.inc
> @@ -25,7 +25,6 @@ EXTRA_OECONF = "\
> --with-cyclic-gc \
> --without-cxx \
> --with-signal-module \
> - --with-wctype-functions \
I think this needs to be protected with a linuxstdbase check.
Sau!
> --enable-shared \
> --enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6', 'yes', 'no', d)} \
> ${PYTHONLSBOPTS} \
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] python: fix failures of LSB python-runtime tests
2013-09-15 20:52 ` Saul Wold
@ 2013-09-16 1:33 ` Hongxu Jia
2013-09-16 3:05 ` Saul Wold
0 siblings, 1 reply; 5+ messages in thread
From: Hongxu Jia @ 2013-09-16 1:33 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1975 bytes --]
On 09/16/2013 04:52 AM, Saul Wold wrote:
> On 09/13/2013 09:31 PM, Hongxu Jia wrote:
>> It has been fixed in:
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e261c1760d8a660c13cd00039a4812d51f47f3df
>>
>>
>> But there is a typo in:
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
>>
>> It missed to remove an extra "--with-wctype-functions" in EXTRA_OECONF
>>
>> [YOCTO #5154]
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>> ---
>> meta/recipes-devtools/python/python.inc | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/python/python.inc
>> b/meta/recipes-devtools/python/python.inc
>> index 80609a8..fcfeda5 100644
>> --- a/meta/recipes-devtools/python/python.inc
>> +++ b/meta/recipes-devtools/python/python.inc
>> @@ -25,7 +25,6 @@ EXTRA_OECONF = "\
>> --with-cyclic-gc \
>> --without-cxx \
>> --with-signal-module \
>> - --with-wctype-functions \
> I think this needs to be protected with a linuxstdbase check.
>
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
has done this, but missing to remove the extra ' --with-wctype-functions'
inherit autotools
+PYTHONLSBOPTS = "--with-wctype-functions"
+PYTHONLSBOPTS_linuxstdbase = "ac_cv_sizeof_off_t=8"
+
EXTRA_OECONF = "\
--with-threads \
--with-pymalloc \
@@ -24,14 +27,5 @@ EXTRA_OECONF = "\
--with-signal-module \
--with-wctype-functions \
--enable-shared \
-"
-
-EXTRA_OECONF_linuxstdbase = "\
- --with-threads \
- --with-pymalloc \
- --with-cyclic-gc \
- --without-cxx \
- --with-signal-module \
- --enable-shared \
- ac_cv_sizeof_off_t=8 \
+ ${PYTHONLSBOPTS} \
"
//Hongxu
> Sau!
>
>> --enable-shared \
>> --enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6', 'yes',
>> 'no', d)} \
>> ${PYTHONLSBOPTS} \
>>
[-- Attachment #2: Type: text/html, Size: 4239 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] python: fix failures of LSB python-runtime tests
2013-09-16 1:33 ` Hongxu Jia
@ 2013-09-16 3:05 ` Saul Wold
0 siblings, 0 replies; 5+ messages in thread
From: Saul Wold @ 2013-09-16 3:05 UTC (permalink / raw)
To: Hongxu Jia; +Cc: openembedded-core
On 09/15/2013 06:33 PM, Hongxu Jia wrote:
> On 09/16/2013 04:52 AM, Saul Wold wrote:
>> On 09/13/2013 09:31 PM, Hongxu Jia wrote:
>>> It has been fixed in:
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e261c1760d8a660c13cd00039a4812d51f47f3df
>>>
>>>
>>> But there is a typo in:
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
>>>
>>> It missed to remove an extra "--with-wctype-functions" in EXTRA_OECONF
>>>
>>> [YOCTO #5154]
>>>
>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>> ---
>>> meta/recipes-devtools/python/python.inc | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/python/python.inc
>>> b/meta/recipes-devtools/python/python.inc
>>> index 80609a8..fcfeda5 100644
>>> --- a/meta/recipes-devtools/python/python.inc
>>> +++ b/meta/recipes-devtools/python/python.inc
>>> @@ -25,7 +25,6 @@ EXTRA_OECONF = "\
>>> --with-cyclic-gc \
>>> --without-cxx \
>>> --with-signal-module \
>>> - --with-wctype-functions \
>> I think this needs to be protected with a linuxstdbase check.
>>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
> has done this, but missing to remove the extra ' --with-wctype-functions'
>
Sorry, I rushed the review of this and did not look at the big picture.
Your patch seems correct.
Sau!
> inherit autotools
>
> +PYTHONLSBOPTS = "--with-wctype-functions"
> +PYTHONLSBOPTS_linuxstdbase = "ac_cv_sizeof_off_t=8"
> +
> EXTRA_OECONF = "\
> --with-threads \
> --with-pymalloc \
> @@ -24,14 +27,5 @@ EXTRA_OECONF = "\
> --with-signal-module \
> --with-wctype-functions \
> --enable-shared \
> -"
> -
> -EXTRA_OECONF_linuxstdbase = "\
> - --with-threads \
> - --with-pymalloc \
> - --with-cyclic-gc \
> - --without-cxx \
> - --with-signal-module \
> - --enable-shared \
> - ac_cv_sizeof_off_t=8 \
> + ${PYTHONLSBOPTS} \
> "
>
> //Hongxu
>
>
>
>> Sau!
>>
>>> --enable-shared \
>>> --enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6', 'yes',
>>> 'no', d)} \
>>> ${PYTHONLSBOPTS} \
>>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-16 3:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-14 4:31 [PATCH 0/1] python: fix failures of LSB python-runtime tests Hongxu Jia
2013-09-14 4:31 ` [PATCH 1/1] " Hongxu Jia
2013-09-15 20:52 ` Saul Wold
2013-09-16 1:33 ` Hongxu Jia
2013-09-16 3:05 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox