Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Rongqing Li <rongqing.li@windriver.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] connman: ignore the networking device which nfs for rootfs is working on
Date: Wed, 16 Oct 2013 08:46:12 +0800	[thread overview]
Message-ID: <525DE1D4.40109@windriver.com> (raw)
In-Reply-To: <E0C668BE-B0FA-4BE0-91E9-BB779A8ABDC3@dominion.thruhere.net>



On 10/15/2013 06:10 PM, Koen Kooi wrote:
>
> Op 15 okt. 2013, om 10:12 heeft rongqing.li@windriver.com het volgende geschreven:
>
>> From: Roy Li <rongqing.li@windriver.com>
>>
>> Otherwise system will hang since nfs is not disconnected
>>
>> and remove the judgement of initscript DISTRO_FEATURE when install init
>> script connman, because inherit systemd will remove init script
>
>> Signed-off-by: Roy Li <rongqing.li@windriver.com>
>> ---
>
> [..]
>
>> diff --git a/meta/recipes-connectivity/connman/connman/connman-nfs.service b/meta/recipes-connectivity/connman/connman/connman-nfs.service
>> new file mode 100644
>> index 0000000..9f9b690
>> --- /dev/null
>> +++ b/meta/recipes-connectivity/connman/connman/connman-nfs.service
>> @@ -0,0 +1,14 @@
>> +[Unit]
>> +Description=Connection service
>> +After=syslog.target
>> +
>> +[Service]
>> +Type=dbus
>> +BusName=net.connman
>> +Restart=on-failure
>> +ExecStartPre=-/usr/lib64/connman/wired-setup
>> +ExecStart=/usr/bin/connman-nfs
>
> Those hardcoded paths aren't going to work. And isn't:
>

Thanks, I will fix it.

> ConditionKernelCommandLine!=root=/dev/nfs
>

What is your meaning?

-Roy


> A lot cleaner to use in systemd?
>

-- 
Best Reagrds,
Roy | RongQing Li


  reply	other threads:[~2013-10-16  0:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15  8:12 [PATCH] connman: ignore the networking device which nfs for rootfs is working on rongqing.li
2013-10-15 10:10 ` Koen Kooi
2013-10-16  0:46   ` Rongqing Li [this message]
2013-10-16  8:54     ` Koen Kooi
2013-10-16  9:10       ` Rongqing Li
2013-10-16  9:13         ` Koen Kooi
2013-10-16 10:08         ` Enrico Scholz
2013-10-17  3:29           ` Rongqing Li
2013-10-17 10:34             ` Enrico Scholz
  -- strict thread matches above, loose matches on Subject: below --
2013-10-17  8:12 rongqing.li
2013-10-17  8:24 ` Rongqing Li
2013-10-17 10:14 ` Koen Kooi
2013-10-18  9:20 rongqing.li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525DE1D4.40109@windriver.com \
    --to=rongqing.li@windriver.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox