From: Rongqing Li <rongqing.li@windriver.com>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] connman: ignore the networking device which nfs for rootfs is working on
Date: Thu, 17 Oct 2013 11:29:17 +0800 [thread overview]
Message-ID: <525F598D.2010106@windriver.com> (raw)
In-Reply-To: <lyppr5plyp.fsf@ensc-virt.intern.sigma-chemnitz.de>
On 10/16/2013 06:08 PM, Enrico Scholz wrote:
> Rongqing Li <rongqing.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
> writes:
>
>>>>> ConditionKernelCommandLine!=root=/dev/nfs
>>>>>>>
>>>>>
>>>>> What is your meaning?
>>> That's you are creating a huge script that does something built into systemd.
>>>
>>
>>
>> Yes, I can not find a way to avoid to that,
>>
>> Do you have any advice?
>
> I would split the cmdline generation into a dedicated one-shot service;
> e.g. modify the original connman.service to have something like
>
> [Service]
> EnvironmentFile = -/run/connmand.env
> ExecStart=/usr/sbin/connmand -n ${CONNMAND_OPTS}
>
>
> The '/run/connmand.env' is created by a service with
>
> [Unit]
> Before = connman.service
> ConditionKernelCommandLine!=root=/dev/nfs
>
> [Service]
> Type = oneshot
> ExecStart = /usr/sbin/create-run-connmand.env
>
> [Install]
> WantedBy = connman.service
>
>
>
I test your method, but failed to start connmand,
it always report "hand over timeout", I think
it is caused by which the script run slow.
But I will follow your method, create two service.
the connman.service is run only when
ConditionKernelCommandLine!=root=/dev/nfs
other connman-nfs.service, which will start the
script to compute the ignored interface, is run
when ConditionKernelCommandLine=root=/dev/nfs
-Roy
> Enrico
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
--
Best Reagrds,
Roy | RongQing Li
next prev parent reply other threads:[~2013-10-17 3:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 8:12 [PATCH] connman: ignore the networking device which nfs for rootfs is working on rongqing.li
2013-10-15 10:10 ` Koen Kooi
2013-10-16 0:46 ` Rongqing Li
2013-10-16 8:54 ` Koen Kooi
2013-10-16 9:10 ` Rongqing Li
2013-10-16 9:13 ` Koen Kooi
2013-10-16 10:08 ` Enrico Scholz
2013-10-17 3:29 ` Rongqing Li [this message]
2013-10-17 10:34 ` Enrico Scholz
-- strict thread matches above, loose matches on Subject: below --
2013-10-17 8:12 rongqing.li
2013-10-17 8:24 ` Rongqing Li
2013-10-17 10:14 ` Koen Kooi
2013-10-18 9:20 rongqing.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525F598D.2010106@windriver.com \
--to=rongqing.li@windriver.com \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox