From: Saul Wold <sgw@linux.intel.com>
To: Ming Liu <ming.liu@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] screen: add pkg_postinst to register entry to /etc/shells
Date: Wed, 16 Oct 2013 11:33:19 -0700 [thread overview]
Message-ID: <525EDBEF.6060108@linux.intel.com> (raw)
In-Reply-To: <1381917496-28055-2-git-send-email-ming.liu@windriver.com>
On 10/16/2013 02:58 AM, Ming Liu wrote:
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
> meta/recipes-extended/screen/screen_4.0.3.bb | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-extended/screen/screen_4.0.3.bb b/meta/recipes-extended/screen/screen_4.0.3.bb
> index 1a7eb20..456f970 100644
> --- a/meta/recipes-extended/screen/screen_4.0.3.bb
> +++ b/meta/recipes-extended/screen/screen_4.0.3.bb
> @@ -41,3 +41,8 @@ do_install_append () {
> fi
> done
> }
> +
> +pkg_postinst_${PN} () {
> + touch $D${sysconfdir}/shells
> + grep -q "usr/bin/screen" $D${sysconfdir}/shells || echo /usr/bin/screen >> $D${sysconfdir}/shells
> +}
>
should you be using ${bindir} here instead of usr/bin? since it's
possible to have different ${prefix}.
Sau!
next prev parent reply other threads:[~2013-10-16 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 9:58 [PATCH 1/2] base-files: move shells generating process to pkg_postinst Ming Liu
2013-10-16 9:58 ` [PATCH 2/2] screen: add pkg_postinst to register entry to /etc/shells Ming Liu
2013-10-16 18:33 ` Saul Wold [this message]
2013-10-17 1:20 ` Ming Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525EDBEF.6060108@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=ming.liu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox