From: Ming Liu <ming.liu@windriver.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] screen: add pkg_postinst to register entry to /etc/shells
Date: Thu, 17 Oct 2013 09:20:34 +0800 [thread overview]
Message-ID: <525F3B62.3080305@windriver.com> (raw)
In-Reply-To: <525EDBEF.6060108@linux.intel.com>
On 10/17/2013 02:33 AM, Saul Wold wrote:
> On 10/16/2013 02:58 AM, Ming Liu wrote:
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>> meta/recipes-extended/screen/screen_4.0.3.bb | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/meta/recipes-extended/screen/screen_4.0.3.bb
>> b/meta/recipes-extended/screen/screen_4.0.3.bb
>> index 1a7eb20..456f970 100644
>> --- a/meta/recipes-extended/screen/screen_4.0.3.bb
>> +++ b/meta/recipes-extended/screen/screen_4.0.3.bb
>> @@ -41,3 +41,8 @@ do_install_append () {
>> fi
>> done
>> }
>> +
>> +pkg_postinst_${PN} () {
>> + touch $D${sysconfdir}/shells
>> + grep -q "usr/bin/screen" $D${sysconfdir}/shells || echo
>> /usr/bin/screen >> $D${sysconfdir}/shells
>> +}
>>
> should you be using ${bindir} here instead of usr/bin? since it's
> possible to have different ${prefix}.
Yes, you are correct, I will send the V1.
//Ming
>
> Sau!
>
>
>
prev parent reply other threads:[~2013-10-17 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 9:58 [PATCH 1/2] base-files: move shells generating process to pkg_postinst Ming Liu
2013-10-16 9:58 ` [PATCH 2/2] screen: add pkg_postinst to register entry to /etc/shells Ming Liu
2013-10-16 18:33 ` Saul Wold
2013-10-17 1:20 ` Ming Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525F3B62.3080305@windriver.com \
--to=ming.liu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox