Re: [PATCH] core-image-basic.bb: Allow user extensions

[Gary Thomas <gary@mlbassoc.com>]

On 2013-10-30 09:33, Paul Eggleton wrote:
> On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
>> On 2013-10-30 08:47, Paul Eggleton wrote:
>>> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
>>>> Allow the user to provide additional packages to this image.
>>>> This lets core-image-basic behave like all other core-image*
>>>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
>>>> as match the documentation which suggests this as the mode to
>>>> extend any core-image* image.
>>>>
>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>>>> ---
>>>>
>>>>     meta/recipes-extended/images/core-image-basic.bb |    3 +++
>>>>     1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/meta/recipes-extended/images/core-image-basic.bb
>>>> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
>>>> 100644
>>>> --- a/meta/recipes-extended/images/core-image-basic.bb
>>>> +++ b/meta/recipes-extended/images/core-image-basic.bb
>>>> @@ -3,9 +3,12 @@ functionality installed."
>>>>
>>>>      IMAGE_FEATURES += "splash ssh-server-openssh"
>>>>
>>>>     +CORE_IMAGE_EXTRA_INSTALL ?= ""
>>>>
>>>> +
>>>
>>> Not sure if it's my mail client but the above looks slightly mangled; in
>>> any case the above addition shouldn't be needed because
>>> core-image.bbclass already does this.
>>
>> Are you sure it counts?  core-image.bbclass is included after this would be
>> evaluated, or does that not matter?
>
> It doesn't matter in most cases, because the value won't actually be expanded
> until later. Values aren't expanded unless you use immediate expansion (the :=
> operator) or you d.getVar("SOMEVAR", True) is called from python code to
> return the expanded value.

Understood, thanks.

Should I send another patch with that line removed?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------