Re: [PATCH V2 1/1] sysvinit: fix missing of boot log

[ChenQi <Qi.Chen@windriver.com>]

On 11/01/2013 06:44 PM, Richard Purdie wrote:
> On Tue, 2013-10-29 at 20:33 +0800, ChenQi wrote:
>> ping
>>
>> Any comment on this one?
> Yes, shouldn't the boot ordering be tweaked to ensure the tmpfs is
> available rather than force mounting it within this init script? This
> looks like a hack around the problem rather than fixing a real issue.

Agree.

Currently in our project, the mountall.sh (mounting the local 
filesystem) starts really late at boot time. It's started after `udev', 
`checkroot.sh', `modutils.sh', `bootlogd' and even `urandom'.
I think we should make it start before udev. In this way, the same hack 
in the udev's init script could also be removed.
The hack was there in udev's init script because the udev's automount 
rule might need to write to the /tmp directory.

I will send out a new patchset.

Best Regards,
Chen Qi

> The -c part is ok so please resend without the mount.
>
> Cheers,
>
> Richard
>
>
>> Best Regards,
>> Chen Qi
>>
>> On 09/26/2013 06:02 PM, Qi.Chen@windriver.com wrote:
>>> From: Chen Qi <Qi.Chen@windriver.com>
>>>
>>> Previously, our system had no boot log even if the bootlogd daemon was
>>> started correctly. The root cause is that the log file doesn't exist
>>> when starting the bootlogd.
>>>
>>> Add '-c' option to bootlogd so that it will create the boot log if
>>> it doesn't exist.
>>>
>>> Besides, we need to make sure that tmpfs has been mounted. Otherwise,
>>> the boot log will still be missing.
>>>
>>> [YOCTO #5273]
>>>
>>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>>> ---
>>>    meta/recipes-core/sysvinit/sysvinit/bootlogd.init |    5 +++--
>>>    1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init
>>> index 7b87827..3a10a3c 100755
>>> --- a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init
>>> +++ b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init
>>> @@ -42,14 +42,15 @@ esac
>>>    
>>>    case "$ACTION" in
>>>    	start)
>>> +		mount -a -t tmpfs 2>/dev/null
>>>    		echo -n "Starting $DESC: "
>>>    		if [ -d /proc/1/. ]
>>>    		then
>>>    			umask 027
>>>    			start-stop-daemon --start --quiet \
>>> -				--exec $DAEMON -- -r
>>> +				--exec $DAEMON -- -r -c
>>>    		else
>>> -			$DAEMON -r
>>> +			$DAEMON -r -c
>>>    		fi
>>>    		echo "$NAME."
>>>    		;;
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>