From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: ChenQi <Qi.Chen@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2 1/1] sysvinit: fix missing of boot log
Date: Fri, 01 Nov 2013 10:44:52 +0000 [thread overview]
Message-ID: <1383302692.25877.135.camel@ted> (raw)
In-Reply-To: <526FAB30.9070600@windriver.com>
On Tue, 2013-10-29 at 20:33 +0800, ChenQi wrote:
> ping
>
> Any comment on this one?
Yes, shouldn't the boot ordering be tweaked to ensure the tmpfs is
available rather than force mounting it within this init script? This
looks like a hack around the problem rather than fixing a real issue.
The -c part is ok so please resend without the mount.
Cheers,
Richard
> Best Regards,
> Chen Qi
>
> On 09/26/2013 06:02 PM, Qi.Chen@windriver.com wrote:
> > From: Chen Qi <Qi.Chen@windriver.com>
> >
> > Previously, our system had no boot log even if the bootlogd daemon was
> > started correctly. The root cause is that the log file doesn't exist
> > when starting the bootlogd.
> >
> > Add '-c' option to bootlogd so that it will create the boot log if
> > it doesn't exist.
> >
> > Besides, we need to make sure that tmpfs has been mounted. Otherwise,
> > the boot log will still be missing.
> >
> > [YOCTO #5273]
> >
> > Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> > ---
> > meta/recipes-core/sysvinit/sysvinit/bootlogd.init | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init
> > index 7b87827..3a10a3c 100755
> > --- a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init
> > +++ b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init
> > @@ -42,14 +42,15 @@ esac
> >
> > case "$ACTION" in
> > start)
> > + mount -a -t tmpfs 2>/dev/null
> > echo -n "Starting $DESC: "
> > if [ -d /proc/1/. ]
> > then
> > umask 027
> > start-stop-daemon --start --quiet \
> > - --exec $DAEMON -- -r
> > + --exec $DAEMON -- -r -c
> > else
> > - $DAEMON -r
> > + $DAEMON -r -c
> > fi
> > echo "$NAME."
> > ;;
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2013-11-01 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 10:02 [PATCH V2 0/1] sysvinit: fix missing of boot log Qi.Chen
2013-09-26 10:02 ` [PATCH V2 1/1] " Qi.Chen
2013-09-26 10:50 ` Enrico Scholz
2013-09-27 2:20 ` ChenQi
2013-10-08 1:51 ` ChenQi
2013-10-29 12:33 ` ChenQi
2013-11-01 10:44 ` Richard Purdie [this message]
2013-11-02 3:24 ` ChenQi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383302692.25877.135.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox