* [PATCH V2 0/1] sysvinit: fix missing of boot log @ 2013-09-26 10:02 Qi.Chen 2013-09-26 10:02 ` [PATCH V2 1/1] " Qi.Chen 0 siblings, 1 reply; 8+ messages in thread From: Qi.Chen @ 2013-09-26 10:02 UTC (permalink / raw) To: openembedded-core From: Chen Qi <Qi.Chen@windriver.com> The following changes since commit 4d8ab87d25ea6e59dc88375813ef88ee0ac813d0: build-appliance: Update SRCREV (2013-09-24 18:09:12 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib ChenQi/bootlogd http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/bootlogd Chen Qi (1): sysvinit: fix missing of boot log meta/recipes-core/sysvinit/sysvinit/bootlogd.init | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2 1/1] sysvinit: fix missing of boot log 2013-09-26 10:02 [PATCH V2 0/1] sysvinit: fix missing of boot log Qi.Chen @ 2013-09-26 10:02 ` Qi.Chen 2013-09-26 10:50 ` Enrico Scholz ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Qi.Chen @ 2013-09-26 10:02 UTC (permalink / raw) To: openembedded-core From: Chen Qi <Qi.Chen@windriver.com> Previously, our system had no boot log even if the bootlogd daemon was started correctly. The root cause is that the log file doesn't exist when starting the bootlogd. Add '-c' option to bootlogd so that it will create the boot log if it doesn't exist. Besides, we need to make sure that tmpfs has been mounted. Otherwise, the boot log will still be missing. [YOCTO #5273] Signed-off-by: Chen Qi <Qi.Chen@windriver.com> --- meta/recipes-core/sysvinit/sysvinit/bootlogd.init | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init index 7b87827..3a10a3c 100755 --- a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init +++ b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init @@ -42,14 +42,15 @@ esac case "$ACTION" in start) + mount -a -t tmpfs 2>/dev/null echo -n "Starting $DESC: " if [ -d /proc/1/. ] then umask 027 start-stop-daemon --start --quiet \ - --exec $DAEMON -- -r + --exec $DAEMON -- -r -c else - $DAEMON -r + $DAEMON -r -c fi echo "$NAME." ;; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/1] sysvinit: fix missing of boot log 2013-09-26 10:02 ` [PATCH V2 1/1] " Qi.Chen @ 2013-09-26 10:50 ` Enrico Scholz 2013-09-27 2:20 ` ChenQi 2013-10-08 1:51 ` ChenQi 2013-10-29 12:33 ` ChenQi 2 siblings, 1 reply; 8+ messages in thread From: Enrico Scholz @ 2013-09-26 10:50 UTC (permalink / raw) To: openembedded-core <Qi.Chen-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> writes: > Besides, we need to make sure that tmpfs has been mounted. Otherwise, > the boot log will still be missing. > ... > case "$ACTION" in > start) > + mount -a -t tmpfs 2>/dev/null This will mount filesystems out-of-order. E.g. it will break an /etc/fstab with | /dev/mmcblk0p1 /srv/www ext4 default 1 1 | none /srv/www/tmp tmpfs default 0 0 Enrico ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/1] sysvinit: fix missing of boot log 2013-09-26 10:50 ` Enrico Scholz @ 2013-09-27 2:20 ` ChenQi 0 siblings, 0 replies; 8+ messages in thread From: ChenQi @ 2013-09-27 2:20 UTC (permalink / raw) To: openembedded-core On 09/26/2013 06:50 PM, Enrico Scholz wrote: > <Qi.Chen-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> writes: > >> Besides, we need to make sure that tmpfs has been mounted. Otherwise, >> the boot log will still be missing. >> ... >> case "$ACTION" in >> start) >> + mount -a -t tmpfs 2>/dev/null > This will mount filesystems out-of-order. E.g. it will break an /etc/fstab > with > > | /dev/mmcblk0p1 /srv/www ext4 default 1 1 > | none /srv/www/tmp tmpfs default 0 0 > > > Enrico Hi Enrico, I tested with this situation just now, and everything worked out well for me. My fstab has: /dev/hdb /media ext2 defaults 0 0 tmpfs /media/tmp tmpfs defaults 0 0 Note that udev's init script also tries to mount tmpfs. So if you used such fstab, you have already verified it yourself. So I think we might be OK here. Best Regards, Chen Qi > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/1] sysvinit: fix missing of boot log 2013-09-26 10:02 ` [PATCH V2 1/1] " Qi.Chen 2013-09-26 10:50 ` Enrico Scholz @ 2013-10-08 1:51 ` ChenQi 2013-10-29 12:33 ` ChenQi 2 siblings, 0 replies; 8+ messages in thread From: ChenQi @ 2013-10-08 1:51 UTC (permalink / raw) To: openembedded-core ping On 09/26/2013 06:02 PM, Qi.Chen@windriver.com wrote: > From: Chen Qi <Qi.Chen@windriver.com> > > Previously, our system had no boot log even if the bootlogd daemon was > started correctly. The root cause is that the log file doesn't exist > when starting the bootlogd. > > Add '-c' option to bootlogd so that it will create the boot log if > it doesn't exist. > > Besides, we need to make sure that tmpfs has been mounted. Otherwise, > the boot log will still be missing. > > [YOCTO #5273] > > Signed-off-by: Chen Qi <Qi.Chen@windriver.com> > --- > meta/recipes-core/sysvinit/sysvinit/bootlogd.init | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init > index 7b87827..3a10a3c 100755 > --- a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init > +++ b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init > @@ -42,14 +42,15 @@ esac > > case "$ACTION" in > start) > + mount -a -t tmpfs 2>/dev/null > echo -n "Starting $DESC: " > if [ -d /proc/1/. ] > then > umask 027 > start-stop-daemon --start --quiet \ > - --exec $DAEMON -- -r > + --exec $DAEMON -- -r -c > else > - $DAEMON -r > + $DAEMON -r -c > fi > echo "$NAME." > ;; ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/1] sysvinit: fix missing of boot log 2013-09-26 10:02 ` [PATCH V2 1/1] " Qi.Chen 2013-09-26 10:50 ` Enrico Scholz 2013-10-08 1:51 ` ChenQi @ 2013-10-29 12:33 ` ChenQi 2013-11-01 10:44 ` Richard Purdie 2 siblings, 1 reply; 8+ messages in thread From: ChenQi @ 2013-10-29 12:33 UTC (permalink / raw) To: openembedded-core ping Any comment on this one? Best Regards, Chen Qi On 09/26/2013 06:02 PM, Qi.Chen@windriver.com wrote: > From: Chen Qi <Qi.Chen@windriver.com> > > Previously, our system had no boot log even if the bootlogd daemon was > started correctly. The root cause is that the log file doesn't exist > when starting the bootlogd. > > Add '-c' option to bootlogd so that it will create the boot log if > it doesn't exist. > > Besides, we need to make sure that tmpfs has been mounted. Otherwise, > the boot log will still be missing. > > [YOCTO #5273] > > Signed-off-by: Chen Qi <Qi.Chen@windriver.com> > --- > meta/recipes-core/sysvinit/sysvinit/bootlogd.init | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init > index 7b87827..3a10a3c 100755 > --- a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init > +++ b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init > @@ -42,14 +42,15 @@ esac > > case "$ACTION" in > start) > + mount -a -t tmpfs 2>/dev/null > echo -n "Starting $DESC: " > if [ -d /proc/1/. ] > then > umask 027 > start-stop-daemon --start --quiet \ > - --exec $DAEMON -- -r > + --exec $DAEMON -- -r -c > else > - $DAEMON -r > + $DAEMON -r -c > fi > echo "$NAME." > ;; ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/1] sysvinit: fix missing of boot log 2013-10-29 12:33 ` ChenQi @ 2013-11-01 10:44 ` Richard Purdie 2013-11-02 3:24 ` ChenQi 0 siblings, 1 reply; 8+ messages in thread From: Richard Purdie @ 2013-11-01 10:44 UTC (permalink / raw) To: ChenQi; +Cc: openembedded-core On Tue, 2013-10-29 at 20:33 +0800, ChenQi wrote: > ping > > Any comment on this one? Yes, shouldn't the boot ordering be tweaked to ensure the tmpfs is available rather than force mounting it within this init script? This looks like a hack around the problem rather than fixing a real issue. The -c part is ok so please resend without the mount. Cheers, Richard > Best Regards, > Chen Qi > > On 09/26/2013 06:02 PM, Qi.Chen@windriver.com wrote: > > From: Chen Qi <Qi.Chen@windriver.com> > > > > Previously, our system had no boot log even if the bootlogd daemon was > > started correctly. The root cause is that the log file doesn't exist > > when starting the bootlogd. > > > > Add '-c' option to bootlogd so that it will create the boot log if > > it doesn't exist. > > > > Besides, we need to make sure that tmpfs has been mounted. Otherwise, > > the boot log will still be missing. > > > > [YOCTO #5273] > > > > Signed-off-by: Chen Qi <Qi.Chen@windriver.com> > > --- > > meta/recipes-core/sysvinit/sysvinit/bootlogd.init | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init > > index 7b87827..3a10a3c 100755 > > --- a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init > > +++ b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init > > @@ -42,14 +42,15 @@ esac > > > > case "$ACTION" in > > start) > > + mount -a -t tmpfs 2>/dev/null > > echo -n "Starting $DESC: " > > if [ -d /proc/1/. ] > > then > > umask 027 > > start-stop-daemon --start --quiet \ > > - --exec $DAEMON -- -r > > + --exec $DAEMON -- -r -c > > else > > - $DAEMON -r > > + $DAEMON -r -c > > fi > > echo "$NAME." > > ;; > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/1] sysvinit: fix missing of boot log 2013-11-01 10:44 ` Richard Purdie @ 2013-11-02 3:24 ` ChenQi 0 siblings, 0 replies; 8+ messages in thread From: ChenQi @ 2013-11-02 3:24 UTC (permalink / raw) To: Richard Purdie; +Cc: openembedded-core On 11/01/2013 06:44 PM, Richard Purdie wrote: > On Tue, 2013-10-29 at 20:33 +0800, ChenQi wrote: >> ping >> >> Any comment on this one? > Yes, shouldn't the boot ordering be tweaked to ensure the tmpfs is > available rather than force mounting it within this init script? This > looks like a hack around the problem rather than fixing a real issue. Agree. Currently in our project, the mountall.sh (mounting the local filesystem) starts really late at boot time. It's started after `udev', `checkroot.sh', `modutils.sh', `bootlogd' and even `urandom'. I think we should make it start before udev. In this way, the same hack in the udev's init script could also be removed. The hack was there in udev's init script because the udev's automount rule might need to write to the /tmp directory. I will send out a new patchset. Best Regards, Chen Qi > The -c part is ok so please resend without the mount. > > Cheers, > > Richard > > >> Best Regards, >> Chen Qi >> >> On 09/26/2013 06:02 PM, Qi.Chen@windriver.com wrote: >>> From: Chen Qi <Qi.Chen@windriver.com> >>> >>> Previously, our system had no boot log even if the bootlogd daemon was >>> started correctly. The root cause is that the log file doesn't exist >>> when starting the bootlogd. >>> >>> Add '-c' option to bootlogd so that it will create the boot log if >>> it doesn't exist. >>> >>> Besides, we need to make sure that tmpfs has been mounted. Otherwise, >>> the boot log will still be missing. >>> >>> [YOCTO #5273] >>> >>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com> >>> --- >>> meta/recipes-core/sysvinit/sysvinit/bootlogd.init | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init >>> index 7b87827..3a10a3c 100755 >>> --- a/meta/recipes-core/sysvinit/sysvinit/bootlogd.init >>> +++ b/meta/recipes-core/sysvinit/sysvinit/bootlogd.init >>> @@ -42,14 +42,15 @@ esac >>> >>> case "$ACTION" in >>> start) >>> + mount -a -t tmpfs 2>/dev/null >>> echo -n "Starting $DESC: " >>> if [ -d /proc/1/. ] >>> then >>> umask 027 >>> start-stop-daemon --start --quiet \ >>> - --exec $DAEMON -- -r >>> + --exec $DAEMON -- -r -c >>> else >>> - $DAEMON -r >>> + $DAEMON -r -c >>> fi >>> echo "$NAME." >>> ;; >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-11-02 3:23 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-09-26 10:02 [PATCH V2 0/1] sysvinit: fix missing of boot log Qi.Chen 2013-09-26 10:02 ` [PATCH V2 1/1] " Qi.Chen 2013-09-26 10:50 ` Enrico Scholz 2013-09-27 2:20 ` ChenQi 2013-10-08 1:51 ` ChenQi 2013-10-29 12:33 ` ChenQi 2013-11-01 10:44 ` Richard Purdie 2013-11-02 3:24 ` ChenQi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox