From: Mark Hatle <mark.hatle@windriver.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/6] gcc: Use alternatives for the *-symlinks packages.
Date: Tue, 12 Nov 2013 20:27:02 -0600 [thread overview]
Message-ID: <5282E376.5060109@windriver.com> (raw)
In-Reply-To: <CAP9ODKpK=eqk_UCR+RQB0N4u+qv8iGTit5S2iHCeu2LJgjhrUQ@mail.gmail.com>
On 11/12/13, 8:24 PM, Otavio Salvador wrote:
> On Tue, Nov 12, 2013 at 11:23 PM, Mark Hatle <mark.hatle@windriver.com> wrote:
>> The various gcc related symlinks should be provided as alternatives instead
>> of hard coded symlinks. This will permit multiple toolchains on a system.
>>
>> Multiple toolchains could come from multilib configurations or alternative
>> open source or commerical sources.
>>
>> Note, gccbug was skipped since it doesn't seem to be generated anymore.
>>
>> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
>
> Wouldn't be better to squash patches 1 and 2 so it makes a real 'logic
> change'? You add code to remove in patch 2, I think the end patch
> would be easier to review, no?
>
It was done this way to match how binutils was implemented. These are actually
two logically separate patches. The first switches from hard coded symlinks to
using update-alternatives. The second patch says that a separate -symlinks
package is no longer needed.
See binutils:
1395aefcaeac94dd0e6ed3a718b7e58dd43b355e
24093e26f246f222c385dc37a2f8cf8b0f183175
(The second of the patches can be reverted -- if ever needed -- and the update
alternatives functionality will still work properly.)
--Mark
next prev parent reply other threads:[~2013-11-13 2:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 1:23 [PATCH 0/6] Misc changes relating to toolchain and image gen Mark Hatle
2013-11-13 1:23 ` [PATCH 1/6] gcc: Use alternatives for the *-symlinks packages Mark Hatle
2013-11-13 2:24 ` Otavio Salvador
2013-11-13 2:27 ` Mark Hatle [this message]
2013-11-13 2:28 ` Otavio Salvador
2013-11-13 1:23 ` [PATCH 2/6] gcc: Drop *-symlinks Mark Hatle
2013-11-13 1:23 ` [PATCH 3/6] binutils: Ensure old -symlinks packages get removed Mark Hatle
2013-11-13 8:12 ` Martin Jansa
2013-11-13 11:14 ` Phil Blundell
2013-11-13 13:39 ` Mark Hatle
2013-11-13 13:44 ` Phil Blundell
2013-11-13 1:23 ` [PATCH 4/6] packagegroups: Remove toolchain *-symlinks packages Mark Hatle
2013-11-13 1:23 ` [PATCH 5/6] packagegroup-self-hosted: Use packagegroup-core-buildessentials Mark Hatle
2013-11-13 1:23 ` [PATCH 6/6] package_rpm: Allow translation of requirement to package name Mark Hatle
2013-11-13 1:33 ` [PATCH 0/6] Misc changes relating to toolchain and image gen Otavio Salvador
2013-11-13 2:01 ` Mark Hatle
2013-11-13 3:42 ` Mark Hatle
2013-11-13 1:59 ` [PATCH 5/6 v2] packagegroup-self-hosted: Use packagegroup-core-buildessential Mark Hatle
2013-11-13 1:59 ` [PATCH 6/6 v2] package_rpm: Allow translation of requirement to package name Mark Hatle
2013-11-13 10:33 ` Paul Eggleton
2013-11-13 12:31 ` Otavio Salvador
2013-11-13 13:12 ` Mark Hatle
2013-11-15 14:02 ` Richard Purdie
2013-11-15 17:15 ` Mark Hatle
2013-11-13 14:19 ` [PATCH 2/6 v3] gcc: Drop *-symlinks Mark Hatle
2013-11-13 14:19 ` [PATCH 3/6 v3] binutils: Ensure old -symlinks packages get removed Mark Hatle
2013-11-19 0:40 ` [PATCH 0/6] Misc changes relating to toolchain and image gen Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5282E376.5060109@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox