From: Tobias Henkel <tobias.henkel@oss.bmw-carit.de>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/9] icecc: Remove output on stderr when calling which
Date: Wed, 13 Nov 2013 07:11:45 +0100 [thread overview]
Message-ID: <52831821.2020400@oss.bmw-carit.de> (raw)
In-Reply-To: <lyd2m5ubhs.fsf@ensc-virt.intern.sigma-chemnitz.de>
On 11/12/2013 12:04 PM, Enrico Scholz wrote:
> - return d.getVar('ICECC_PATH') or os.popen("which icecc").read()[:-1]
> + return d.getVar('ICECC_PATH') or os.popen("which icecc 2> /dev/null").read()[:-1]
> ~~~~~~~~~~~~~~~~~~~~~~
>
> I think, this can/should be replaced by
>
> bb.utils.which(os.getenv("PATH"), "icecc")
>
> Ditto the other locations.
Thank you for this point. I'll post this as a new patch as the other
patches of this patch series already seem to be in master.
Best regards
Tobias
next prev parent reply other threads:[~2013-11-13 6:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 8:33 [PATCH 0/9] icecc.bbclass: Fix some issues Tobias Henkel
2013-11-12 8:33 ` [PATCH 1/9] icecc: Log reason in error cases Tobias Henkel
2013-11-12 8:33 ` [PATCH 2/9] icecc: Remove output on stderr when calling which Tobias Henkel
2013-11-12 11:04 ` Enrico Scholz
2013-11-13 6:11 ` Tobias Henkel [this message]
2013-11-12 8:33 ` [PATCH 3/9] icecc: Reduce verbosity with empty PARALLEL_MAKE Tobias Henkel
2013-11-12 8:33 ` [PATCH 4/9] icecc: Add blacklist vars to BB_HASHBASE_WHITELIST Tobias Henkel
2013-11-12 8:33 ` [PATCH 5/9] icecc: Add dummy python version of set_icecc_env Tobias Henkel
2013-11-12 8:34 ` [PATCH 6/9] icecc: Enable icecc also for install step Tobias Henkel
2013-11-12 8:34 ` [PATCH 7/9] icecc: Support shell evaluation of KERNEL_CC Tobias Henkel
2013-11-12 8:34 ` [PATCH 8/9] icecc: Add package whitelist Tobias Henkel
2013-11-12 8:34 ` [PATCH 9/9] icecc: Fix race condition when packaging toolchain Tobias Henkel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52831821.2020400@oss.bmw-carit.de \
--to=tobias.henkel@oss.bmw-carit.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox