Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
To: openembedded-core@lists.openembedded.org
Cc: Tobias Henkel <tobias.henkel-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
Subject: Re: [PATCH 2/9] icecc: Remove output on stderr when calling which
Date: Tue, 12 Nov 2013 12:04:47 +0100	[thread overview]
Message-ID: <lyd2m5ubhs.fsf@ensc-virt.intern.sigma-chemnitz.de> (raw)
In-Reply-To: <1384245243-20247-3-git-send-email-tobias.henkel@oss.bmw-carit.de> (Tobias Henkel's message of "Tue, 12 Nov 2013 09:33:56 +0100")

Tobias Henkel <tobias.henkel-Y0tyK2LzuKvpgbXj0Ix11Q@public.gmane.org>
writes:

> -    return d.getVar('ICECC_PATH') or os.popen("which icecc").read()[:-1]
> +    return d.getVar('ICECC_PATH') or os.popen("which icecc 2> /dev/null").read()[:-1]
                                        ~~~~~~~~~~~~~~~~~~~~~~

I think, this can/should be replaced by

  bb.utils.which(os.getenv("PATH"), "icecc")

Ditto the other locations.


Enrico


  reply	other threads:[~2013-11-12 11:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12  8:33 [PATCH 0/9] icecc.bbclass: Fix some issues Tobias Henkel
2013-11-12  8:33 ` [PATCH 1/9] icecc: Log reason in error cases Tobias Henkel
2013-11-12  8:33 ` [PATCH 2/9] icecc: Remove output on stderr when calling which Tobias Henkel
2013-11-12 11:04   ` Enrico Scholz [this message]
2013-11-13  6:11     ` Tobias Henkel
2013-11-12  8:33 ` [PATCH 3/9] icecc: Reduce verbosity with empty PARALLEL_MAKE Tobias Henkel
2013-11-12  8:33 ` [PATCH 4/9] icecc: Add blacklist vars to BB_HASHBASE_WHITELIST Tobias Henkel
2013-11-12  8:33 ` [PATCH 5/9] icecc: Add dummy python version of set_icecc_env Tobias Henkel
2013-11-12  8:34 ` [PATCH 6/9] icecc: Enable icecc also for install step Tobias Henkel
2013-11-12  8:34 ` [PATCH 7/9] icecc: Support shell evaluation of KERNEL_CC Tobias Henkel
2013-11-12  8:34 ` [PATCH 8/9] icecc: Add package whitelist Tobias Henkel
2013-11-12  8:34 ` [PATCH 9/9] icecc: Fix race condition when packaging toolchain Tobias Henkel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lyd2m5ubhs.fsf@ensc-virt.intern.sigma-chemnitz.de \
    --to=enrico.scholz@sigma-chemnitz.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=tobias.henkel-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox