[PATCH 0/2] bluez4: Install and fix simpe-agent

[PATCH 0/2] bluez4: Install and fix simpe-agent

[Zhong Hongbo]

Zhong Hongbo (2):
  bluez4: Install simple-agent utility for pairing bluetooth devices
  bluez4: Fix no moudle named gi.repository and GObject for
    simpel-agent

 ...x-no-module-name-GObject-for-simple-agent.patch |   25 ++++++++++++++++++++
 meta/recipes-connectivity/bluez/bluez4_4.101.bb    |    3 +++
 2 files changed, 28 insertions(+)
 create mode 100644 meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch

[PATCH 1/2] bluez4: Install simple-agent utility for pairing bluetooth devices

[Zhong Hongbo]

From: Zhong Hongbo <hongbo.zhong@windriver.com>

Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
---
 meta/recipes-connectivity/bluez/bluez4_4.101.bb |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/bluez/bluez4_4.101.bb b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
index d6c3e26..c3444ab 100644
--- a/meta/recipes-connectivity/bluez/bluez4_4.101.bb
+++ b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
@@ -18,6 +18,8 @@ do_install_append() {
 	install -m 0644 ${S}/audio/audio.conf ${D}/${sysconfdir}/bluetooth/
 	install -m 0644 ${S}/network/network.conf ${D}/${sysconfdir}/bluetooth/
 	install -m 0644 ${S}/input/input.conf ${D}/${sysconfdir}/bluetooth/
+	install -m 0755 ${S}/test/simple-agent ${D}/${bindir}/simple-agent
+
 	# at_console doesn't really work with the current state of OE, so punch some more holes so people can actually use BT
 	install -m 0644 ${WORKDIR}/bluetooth.conf ${D}/${sysconfdir}/dbus-1/system.d/
 }
-- 
1.7.9.5

[PATCH 2/2] bluez4: Fix no moudle named gi.repository and GObject for simpel-agent

[Zhong Hongbo]

From: Zhong Hongbo <hongbo.zhong@windriver.com>

Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
---
 ...x-no-module-name-GObject-for-simple-agent.patch |   25 ++++++++++++++++++++
 meta/recipes-connectivity/bluez/bluez4_4.101.bb    |    1 +
 2 files changed, 26 insertions(+)
 create mode 100644 meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch

diff --git a/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
new file mode 100644
index 0000000..245250c
--- /dev/null
+++ b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
@@ -0,0 +1,25 @@
+Fix No module name gi.repository and GObject for simple-agent
+
+Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
+---
+diff -Nurd bluez-4.101.orig/test/simple-agent bluez-4.101/test/simple-agent
+--- bluez-4.101.orig/test/simple-agent	2013-11-13 17:14:08.138118159 +0800
++++ bluez-4.101/test/simple-agent	2013-11-13 17:14:29.034118107 +0800
+@@ -2,7 +2,7 @@
+ 
+ from __future__ import absolute_import, print_function, unicode_literals
+ 
+-from gi.repository import GObject
++import gobject
+ 
+ import sys
+ import dbus
+@@ -122,7 +122,7 @@
+ 	path = "/test/agent"
+ 	agent = Agent(bus, path)
+ 
+-	mainloop = GObject.MainLoop()
++	mainloop = gobject.MainLoop()
+ 
+ 	if len(args) > 1:
+ 		if len(args) > 2:
diff --git a/meta/recipes-connectivity/bluez/bluez4_4.101.bb b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
index c3444ab..03e0964 100644
--- a/meta/recipes-connectivity/bluez/bluez4_4.101.bb
+++ b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
@@ -7,6 +7,7 @@ SRC_URI += "file://bluetooth.conf \
             file://fix-udev-paths.patch \
             file://obsolete_automake_macros.patch \
             file://network-fix-network-Connect-method-parameters.patch \
+            file://fix-no-module-name-GObject-for-simple-agent.patch \
 "
 
 SRC_URI[md5sum] = "fb42cb7038c380eb0e2fa208987c96ad"
-- 
1.7.9.5

Re: [PATCH 1/2] bluez4: Install simple-agent utility for pairing bluetooth devices

[Phil Blundell]

On Wed, 2013-11-13 at 18:08 +0800, Zhong Hongbo wrote:
> From: Zhong Hongbo <hongbo.zhong@windriver.com>
> 
> Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
[...]
>  	install -m 0644 ${S}/input/input.conf ${D}/${sysconfdir}/bluetooth/
> +	install -m 0755 ${S}/test/simple-agent ${D}/${bindir}/simple-agent

What does simple-agent actually do?  Is it generally enough useful that
it should be installed unconditionally?

p.

Re: [PATCH 2/2] bluez4: Fix no moudle named gi.repository and GObject for simpel-agent

[Burton, Ross]

On 13 November 2013 10:08, Zhong Hongbo <hongbo.zhong@windriver.com> wrote:
> +++ b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
> @@ -0,0 +1,25 @@
> +Fix No module name gi.repository and GObject for simple-agent
> +
> +Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>

Patch needs an Upstream-Status ("Inappropriate [revert]" would be
suitable), and please rename the patch/comment to something more
accurate along the lines of "use legacy pygobject instead of
gobject-introspection".

Ross

Re: [PATCH 1/2] bluez4: Install simple-agent utility for pairing bluetooth devices

[Burton, Ross]

On 13 November 2013 11:38, Phil Blundell <pb@pbcl.net> wrote:
> On Wed, 2013-11-13 at 18:08 +0800, Zhong Hongbo wrote:
>> From: Zhong Hongbo <hongbo.zhong@windriver.com>
>>
>> Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
> [...]
>>       install -m 0644 ${S}/input/input.conf ${D}/${sysconfdir}/bluetooth/
>> +     install -m 0755 ${S}/test/simple-agent ${D}/${bindir}/simple-agent
>
> What does simple-agent actually do?  Is it generally enough useful that
> it should be installed unconditionally?

It's a dumb agent for responding to incoming pairing requests, as it
works interactively from a terminal it's purely for testing purposes.
I'd prefer to see it (and probably more utilities) installed in
bluez4-tests as it's not generally useful.

Ross

Re: [PATCH 1/2] bluez4: Install simple-agent utility for pairing bluetooth devices

[Philip Balister]

On 11/13/2013 07:34 AM, Burton, Ross wrote:
> On 13 November 2013 11:38, Phil Blundell <pb@pbcl.net> wrote:
>> On Wed, 2013-11-13 at 18:08 +0800, Zhong Hongbo wrote:
>>> From: Zhong Hongbo <hongbo.zhong@windriver.com>
>>>
>>> Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
>> [...]
>>>       install -m 0644 ${S}/input/input.conf ${D}/${sysconfdir}/bluetooth/
>>> +     install -m 0755 ${S}/test/simple-agent ${D}/${bindir}/simple-agent
>>
>> What does simple-agent actually do?  Is it generally enough useful that
>> it should be installed unconditionally?
> 
> It's a dumb agent for responding to incoming pairing requests, as it
> works interactively from a terminal it's purely for testing purposes.
> I'd prefer to see it (and probably more utilities) installed in
> bluez4-tests as it's not generally useful.

I think it is also useful for console only devices.

Philip

> 
> Ross
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 

Re: [PATCH 1/2] bluez4: Install simple-agent utility for pairing bluetooth devices

[Burton, Ross]

On 13 November 2013 13:24, Philip Balister <philip@balister.org> wrote:
> On 11/13/2013 07:34 AM, Burton, Ross wrote:
>> On 13 November 2013 11:38, Phil Blundell <pb@pbcl.net> wrote:
>>> On Wed, 2013-11-13 at 18:08 +0800, Zhong Hongbo wrote:
>>>> From: Zhong Hongbo <hongbo.zhong@windriver.com>
>>>>
>>>> Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
>>> [...]
>>>>       install -m 0644 ${S}/input/input.conf ${D}/${sysconfdir}/bluetooth/
>>>> +     install -m 0755 ${S}/test/simple-agent ${D}/${bindir}/simple-agent
>>>
>>> What does simple-agent actually do?  Is it generally enough useful that
>>> it should be installed unconditionally?
>>
>> It's a dumb agent for responding to incoming pairing requests, as it
>> works interactively from a terminal it's purely for testing purposes.
>> I'd prefer to see it (and probably more utilities) installed in
>> bluez4-tests as it's not generally useful.
>
> I think it is also useful for console only devices.

Again, only for interactive use where the user is sitting at a shell
and has started the agent themselves.  You'd never use it in a
production environment.

Ross

Re: [PATCH 1/2] bluez4: Install simple-agent utility for pairing bluetooth devices

[Zhong Hongbo]

On 11/13/2013 08:34 PM, Burton, Ross wrote:
> On 13 November 2013 11:38, Phil Blundell <pb@pbcl.net> wrote:
>> On Wed, 2013-11-13 at 18:08 +0800, Zhong Hongbo wrote:
>>> From: Zhong Hongbo <hongbo.zhong@windriver.com>
>>>
>>> Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
>> [...]
>>>        install -m 0644 ${S}/input/input.conf ${D}/${sysconfdir}/bluetooth/
>>> +     install -m 0755 ${S}/test/simple-agent ${D}/${bindir}/simple-agent
>> What does simple-agent actually do?  Is it generally enough useful that
>> it should be installed unconditionally?
> It's a dumb agent for responding to incoming pairing requests, as it
> works interactively from a terminal it's purely for testing purposes.
> I'd prefer to see it (and probably more utilities) installed in
> bluez4-tests as it's not generally useful.
Agree.

But a issue is: How do place this test file?  On the /usr/bin directory? 
or /usb/bin/bluez? or others?

The below place the test to /usr/bin. as the following:

FILES_${PN}-test += "\
   ${bindir}/test-* \
   ${bindir}/simple-* \
   ${bindir}/agent \
   ${bindir}/attest \
   ${bindir}/avtest \
   ${bindir}/bdaddr \
   ${bindir}/btiotest \
   ${bindir}/gaptest \
   ${bindir}/hsmicro \
   ${bindir}/hsplay \
   ${bindir}/hstest \
   ${bindir}/ipctest \
   ${bindir}/l2test \
   ${bindir}/list-devices \
   ${bindir}/lmptest \
   ${bindir}/monitor-bluetooth \
   ${bindir}/mpris-player \
   ${bindir}/rctest \
   ${bindir}/scotest \
   ${bindir}/sdptest \
   ${bindir}/uuidtest \
"

Thanks,
Hongbo
>
> Ross
>
>

Re: [PATCH 2/2] bluez4: Fix no moudle named gi.repository and GObject for simpel-agent

[Zhong Hongbo]

On 11/13/2013 08:30 PM, Burton, Ross wrote:
> On 13 November 2013 10:08, Zhong Hongbo <hongbo.zhong@windriver.com> wrote:
>> +++ b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
>> @@ -0,0 +1,25 @@
>> +Fix No module name gi.repository and GObject for simple-agent
>> +
>> +Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
> Patch needs an Upstream-Status ("Inappropriate [revert]" would be
> suitable), and please rename the patch/comment to something more
> accurate along the lines of "use legacy pygobject instead of
> gobject-introspection".
Sorry, This is my first RR. I will do it in the next RR.

Thanks,
Hongbo
>
> Ross
>
>

Re: [PATCH 2/2] bluez4: Fix no moudle named gi.repository and GObject for simpel-agent

[Zhong Hongbo]

On 11/13/2013 08:30 PM, Burton, Ross wrote:
> On 13 November 2013 10:08, Zhong Hongbo <hongbo.zhong@windriver.com> wrote:
>> +++ b/meta/recipes-connectivity/bluez/bluez4-4.101/fix-no-module-name-GObject-for-simple-agent.patch
>> @@ -0,0 +1,25 @@
>> +Fix No module name gi.repository and GObject for simple-agent
>> +
>> +Signed-off-by: Zhong Hongbo <hongbo.zhong@windriver.com>
> Patch needs an Upstream-Status ("Inappropriate [revert]" would be
> suitable), and please rename the patch/comment to something more
> accurate along the lines of "use legacy pygobject instead of
> gobject-introspection".
This patch do not in upstream. I do the change  and test it in my x86_64 
platform.
What status should fill in Upstream-Status.

Thanks,
Hongbo
>
> Ross
>
>

Re: [PATCH 2/2] bluez4: Fix no moudle named gi.repository and GObject for simpel-agent

[Burton, Ross]

On 14 November 2013 10:47, Zhong Hongbo <hongbo.zhong@windriver.com> wrote:
> What status should fill in Upstream-Status.

As I said, "Inappropriate" is suitable here.

Ross