Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Yue Tao <Yue.Tao@windriver.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] Avoid starting rpcbind daemon twice during boot
Date: Fri, 15 Nov 2013 07:15:05 -0800	[thread overview]
Message-ID: <52863A79.3010006@linux.intel.com> (raw)
In-Reply-To: <1384497286-19011-1-git-send-email-Yue.Tao@windriver.com>

On 11/14/2013 10:34 PM, Yue Tao wrote:
> Check whether rpcbind daemon already run before starting it.
>
Please review the commit guidelines for both of your patches and correct 
the short summary (subject) to be in the form of:

initscripts: Avoid ...

Thanks
	SaU!

> Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
> ---
>   .../initscripts/initscripts-1.0/mountnfs.sh        |    9 ++++++---
>   1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh b/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh
> index 4fffe4e..a03070d 100755
> --- a/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh
> +++ b/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh
> @@ -69,9 +69,12 @@ if test "$rpcbind" = yes
>   then
>   	if test -x /usr/sbin/rpcbind
>   	then
> -		echo -n "Starting rpcbind... "
> -		start-stop-daemon --start --quiet --exec /usr/sbin/rpcbind
> -		sleep 2
> +		service rpcbind status > /dev/null
> +		if [ $? != 0 ]; then
> +			echo -n "Starting rpcbind..."
> +			start-stop-daemon --start --quiet --exec /usr/sbin/rpcbind
> +			sleep 2
> +		fi
>   	fi
>   fi
>
>


      parent reply	other threads:[~2013-11-15 15:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15  6:34 [PATCH 1/2] Avoid starting rpcbind daemon twice during boot Yue Tao
2013-11-15  6:34 ` [PATCH 2/2] Add e2fsprogs-mke2fs and e2fsprogs-e2fsck as recommend packages Yue Tao
2013-11-15  9:08   ` Hans Beckérus
2013-11-15 15:15 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52863A79.3010006@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=Yue.Tao@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox