[PATCH 1/2] Avoid starting rpcbind daemon twice during boot

[PATCH 1/2] Avoid starting rpcbind daemon twice during boot

[Yue Tao]

Check whether rpcbind daemon already run before starting it.

Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
---
 .../initscripts/initscripts-1.0/mountnfs.sh        |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh b/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh
index 4fffe4e..a03070d 100755
--- a/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh
+++ b/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh
@@ -69,9 +69,12 @@ if test "$rpcbind" = yes
 then
 	if test -x /usr/sbin/rpcbind
 	then
-		echo -n "Starting rpcbind... "
-		start-stop-daemon --start --quiet --exec /usr/sbin/rpcbind
-		sleep 2
+		service rpcbind status > /dev/null
+		if [ $? != 0 ]; then
+			echo -n "Starting rpcbind..."
+			start-stop-daemon --start --quiet --exec /usr/sbin/rpcbind
+			sleep 2
+		fi
 	fi
 fi
 
-- 
1.7.5.4

[PATCH 2/2] Add e2fsprogs-mke2fs and e2fsprogs-e2fsck as recommend packages

[Yue Tao]

The mke2fs and e2fsck commands are regular tools of e2fsprogs, so they
should be installed.

Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
---
 .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb
index 63c0057..5c78c82 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb
@@ -59,6 +59,7 @@ do_install_append () {
 }
 
 RDEPENDS_e2fsprogs = "e2fsprogs-badblocks"
+RRECOMMENDS_e2fsprogs = "e2fsprogs-mke2fs e2fsprogs-e2fsck"
 
 PACKAGES =+ "e2fsprogs-e2fsck e2fsprogs-mke2fs e2fsprogs-tune2fs e2fsprogs-badblocks"
 PACKAGES =+ "libcomerr libss libe2p libext2fs"
-- 
1.7.5.4

Re: [PATCH 2/2] Add e2fsprogs-mke2fs and e2fsprogs-e2fsck as recommend packages

[Hans Beckérus]

On Fri, Nov 15, 2013 at 7:34 AM, Yue Tao <Yue.Tao@windriver.com> wrote:
> The mke2fs and e2fsck commands are regular tools of e2fsprogs, so they
> should be installed.
>

Could the enforcement of mke2fs conflict with the busybox default install?

Thanks.
Hans

> Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
> ---
>  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb
> index 63c0057..5c78c82 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb
> @@ -59,6 +59,7 @@ do_install_append () {
>  }
>
>  RDEPENDS_e2fsprogs = "e2fsprogs-badblocks"
> +RRECOMMENDS_e2fsprogs = "e2fsprogs-mke2fs e2fsprogs-e2fsck"
>
>  PACKAGES =+ "e2fsprogs-e2fsck e2fsprogs-mke2fs e2fsprogs-tune2fs e2fsprogs-badblocks"
>  PACKAGES =+ "libcomerr libss libe2p libext2fs"
> --
> 1.7.5.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 1/2] Avoid starting rpcbind daemon twice during boot

[Saul Wold]

On 11/14/2013 10:34 PM, Yue Tao wrote:
> Check whether rpcbind daemon already run before starting it.
>
Please review the commit guidelines for both of your patches and correct 
the short summary (subject) to be in the form of:

initscripts: Avoid ...

Thanks
	SaU!

> Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
> ---
>   .../initscripts/initscripts-1.0/mountnfs.sh        |    9 ++++++---
>   1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh b/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh
> index 4fffe4e..a03070d 100755
> --- a/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh
> +++ b/meta/recipes-core/initscripts/initscripts-1.0/mountnfs.sh
> @@ -69,9 +69,12 @@ if test "$rpcbind" = yes
>   then
>   	if test -x /usr/sbin/rpcbind
>   	then
> -		echo -n "Starting rpcbind... "
> -		start-stop-daemon --start --quiet --exec /usr/sbin/rpcbind
> -		sleep 2
> +		service rpcbind status > /dev/null
> +		if [ $? != 0 ]; then
> +			echo -n "Starting rpcbind..."
> +			start-stop-daemon --start --quiet --exec /usr/sbin/rpcbind
> +			sleep 2
> +		fi
>   	fi
>   fi
>
>