* [PATCH V2 2/3] lttng-ust: Using toolchain to compile examples
2013-12-05 6:14 [PATCH V2 1/3] lttng-ust: update commit to fix compiling issues Chong.Lu
@ 2013-12-05 6:14 ` Chong.Lu
2013-12-05 6:14 ` [PATCH V2 3/3] lttng-ust: fix python interpret path Chong.Lu
2013-12-05 19:11 ` [PATCH V2 1/3] lttng-ust: update commit to fix compiling issues Saul Wold
2 siblings, 0 replies; 4+ messages in thread
From: Chong.Lu @ 2013-12-05 6:14 UTC (permalink / raw)
To: openembedded-core
From: Chong Lu <Chong.Lu@windriver.com>
1. Some head files wouldn't be found when compiled with host gcc.
So, We should use cross compile toolchain to build examples.
2. Because the .o file couldn't be generated through lttng-gen-tp in
cross-compiling environment. Implement the .o file generation
manually instead of lttng-gen-tp.
Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
.../lttng-ust/0001-lttng-ust-several-fixes.patch | 97 ++++++++++++++++++++
meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb | 1 +
2 files changed, 98 insertions(+)
create mode 100644 meta/recipes-kernel/lttng/lttng-ust/0001-lttng-ust-several-fixes.patch
diff --git a/meta/recipes-kernel/lttng/lttng-ust/0001-lttng-ust-several-fixes.patch b/meta/recipes-kernel/lttng/lttng-ust/0001-lttng-ust-several-fixes.patch
new file mode 100644
index 0000000..a51d0e5
--- /dev/null
+++ b/meta/recipes-kernel/lttng/lttng-ust/0001-lttng-ust-several-fixes.patch
@@ -0,0 +1,97 @@
+From ea7d68aba7723633dcc3944a58f0b30191ea782b Mon Sep 17 00:00:00 2001
+From: Chong Lu <Chong.Lu@windriver.com>
+Date: Fri, 22 Nov 2013 16:11:53 +0800
+Subject: [PATCH] lttng-ust: several fixes
+
+This patch fixes below issues:
+
+1. Using cross compile toolchain to build examples.
+2. Implement the .o file generation manually instead of lttng-gen-tp.
+
+Upstream-Status: Pending
+
+Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
+---
+ doc/examples/demo/Makefile | 1 -
+ doc/examples/easy-ust/Makefile | 1 -
+ doc/examples/gen-tp/Makefile | 17 ++++++++---------
+ doc/examples/hello-static-lib/Makefile | 1 -
+ 4 files changed, 8 insertions(+), 12 deletions(-)
+
+diff --git a/doc/examples/demo/Makefile b/doc/examples/demo/Makefile
+index 27e4146..d0d83e5 100644
+--- a/doc/examples/demo/Makefile
++++ b/doc/examples/demo/Makefile
+@@ -14,7 +14,6 @@
+ #
+ # This makefile is purposefully kept simple to support GNU and BSD make.
+
+-CC = gcc
+ LIBS = -ldl # On Linux
+ #LIBS = -lc # On BSD
+ LOCAL_CPPFLAGS += -I.
+diff --git a/doc/examples/easy-ust/Makefile b/doc/examples/easy-ust/Makefile
+index 966c474..0cfeec4 100644
+--- a/doc/examples/easy-ust/Makefile
++++ b/doc/examples/easy-ust/Makefile
+@@ -16,7 +16,6 @@
+ #
+ # This makefile is purposefully kept simple to support GNU and BSD make.
+
+-CC = gcc
+ LIBS = -ldl -llttng-ust # On Linux
+ #LIBS = -lc -llttng-ust # On BSD
+ LOCAL_CPPFLAGS += -I.
+diff --git a/doc/examples/gen-tp/Makefile b/doc/examples/gen-tp/Makefile
+index bc979d9..b9fe757 100644
+--- a/doc/examples/gen-tp/Makefile
++++ b/doc/examples/gen-tp/Makefile
+@@ -17,7 +17,6 @@
+ #
+ # This makefile is purposefully kept simple to support GNU and BSD make.
+
+-CC = gcc
+
+ LIBS = -ldl -llttng-ust #On Linux
+ #LIBS = -lc -llttng-ust #On BSD
+@@ -33,17 +32,17 @@ sample.o: sample.c sample_tracepoint.h
+ -c -o $@ $<
+
+ # Use this command to compile the .c manually
+-#sample_tracepoint.o: sample_tracepoint.c sample_tracepoint.h
+-# $(CC) $(CPPFLAGS) $(CFLAGS) $(AM_CPPFLAGS) $(AM_CFLAGS) \
+-# -I. -c -o $@ $<
++sample_tracepoint.o: sample_tracepoint.c sample_tracepoint.h
++ $(CC) $(CPPFLAGS) $(CFLAGS) $(AM_CPPFLAGS) $(AM_CFLAGS) \
++ -I. -c -o $@ $<
+
+ # This rule generate .o only and depends on rules for generating
+ # the .h and .c
+-%.o: %.tp %.c %.h
+- CPPFLAGS="$(CPPFLAGS) $(AM_CPPFLAGS)" \
+- CFLAGS="$(CFLAGS) $(AM_CFLAGS)" \
+- LDFLAGS="$(LDFLAGS) $(AM_LDFLAGS)" \
+- $(LTTNG_GEN_TP_PATH)lttng-gen-tp -o $@ $<
++#%.o: %.tp %.c %.h
++# CPPFLAGS="$(CPPFLAGS) $(AM_CPPFLAGS)" \
++# CFLAGS="$(CFLAGS) $(AM_CFLAGS)" \
++# LDFLAGS="$(LDFLAGS) $(AM_LDFLAGS)" \
++# $(LTTNG_GEN_TP_PATH)lttng-gen-tp -o $@ $<
+
+ # The following rule can be used to generate all files instead of having one
+ # for each file type. Note that the sample.o has a dependency on the
+diff --git a/doc/examples/hello-static-lib/Makefile b/doc/examples/hello-static-lib/Makefile
+index 9a079ec..4ed5dcf 100644
+--- a/doc/examples/hello-static-lib/Makefile
++++ b/doc/examples/hello-static-lib/Makefile
+@@ -14,7 +14,6 @@
+ #
+ # This makefile is purposefully kept simple to support GNU and BSD make.
+
+-CC = gcc
+ LOCAL_CPPFLAGS += -I.
+ LIBS = -ldl -llttng-ust # On Linux
+ #LIBS = -lc -llttng-ust # On BSD
+--
+1.7.9.5
+
diff --git a/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb b/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb
index f3a6b05..cdc834c 100644
--- a/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb
+++ b/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb
@@ -23,6 +23,7 @@ PV = "2.3.0"
PE = "2"
SRC_URI = "git://git.lttng.org/lttng-ust.git \
+ file://0001-lttng-ust-several-fixes.patch \
"
S = "${WORKDIR}/git"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH V2 3/3] lttng-ust: fix python interpret path
2013-12-05 6:14 [PATCH V2 1/3] lttng-ust: update commit to fix compiling issues Chong.Lu
2013-12-05 6:14 ` [PATCH V2 2/3] lttng-ust: Using toolchain to compile examples Chong.Lu
@ 2013-12-05 6:14 ` Chong.Lu
2013-12-05 19:11 ` [PATCH V2 1/3] lttng-ust: update commit to fix compiling issues Saul Wold
2 siblings, 0 replies; 4+ messages in thread
From: Chong.Lu @ 2013-12-05 6:14 UTC (permalink / raw)
To: openembedded-core
From: Chong Lu <Chong.Lu@windriver.com>
Change python interpreter path to avoid syntax errors on CentOS 5.10
which has Python 2.4.x.
Add dependency for python-native.
Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
.../0001-lttng-ust-fix-python-interpret-path.patch | 26 ++++++++++++++++++++
meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb | 3 ++-
2 files changed, 28 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-kernel/lttng/lttng-ust/0001-lttng-ust-fix-python-interpret-path.patch
diff --git a/meta/recipes-kernel/lttng/lttng-ust/0001-lttng-ust-fix-python-interpret-path.patch b/meta/recipes-kernel/lttng/lttng-ust/0001-lttng-ust-fix-python-interpret-path.patch
new file mode 100644
index 0000000..1760244
--- /dev/null
+++ b/meta/recipes-kernel/lttng/lttng-ust/0001-lttng-ust-fix-python-interpret-path.patch
@@ -0,0 +1,26 @@
+From 5099ea7a497c719924f59a782ebf23ef8b698de3 Mon Sep 17 00:00:00 2001
+From: Chong Lu <Chong.Lu@windriver.com>
+Date: Thu, 5 Dec 2013 13:24:56 +0800
+Subject: [PATCH] lttng-ust: fix python interpret path
+
+Change python interpreter path to avoid syntax errors on CentOS 5.10
+which has Python 2.4.x.
+
+Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
+---
+ tools/lttng-gen-tp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tools/lttng-gen-tp b/tools/lttng-gen-tp
+index 0f6f0b5..dca2e28 100755
+--- a/tools/lttng-gen-tp
++++ b/tools/lttng-gen-tp
+@@ -1,4 +1,4 @@
+-#!/usr/bin/python
++#!/usr/bin/env python
+ #
+ # Copyright (c) 2012 Yannick Brosseau <yannick.brosseau@gmail.com>
+ #
+--
+1.7.9.5
+
diff --git a/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb b/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb
index cdc834c..39d5049 100644
--- a/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb
+++ b/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb
@@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c963eb366b781252b0bf0fdf1624d9e9 \
inherit autotools
-DEPENDS = "liburcu util-linux"
+DEPENDS = "liburcu util-linux python-native"
RDEPENDS_${PN} = "python"
# For backwards compatibility after rename
@@ -24,6 +24,7 @@ PE = "2"
SRC_URI = "git://git.lttng.org/lttng-ust.git \
file://0001-lttng-ust-several-fixes.patch \
+ file://0001-lttng-ust-fix-python-interpret-path.patch \
"
S = "${WORKDIR}/git"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V2 1/3] lttng-ust: update commit to fix compiling issues
2013-12-05 6:14 [PATCH V2 1/3] lttng-ust: update commit to fix compiling issues Chong.Lu
2013-12-05 6:14 ` [PATCH V2 2/3] lttng-ust: Using toolchain to compile examples Chong.Lu
2013-12-05 6:14 ` [PATCH V2 3/3] lttng-ust: fix python interpret path Chong.Lu
@ 2013-12-05 19:11 ` Saul Wold
2 siblings, 0 replies; 4+ messages in thread
From: Saul Wold @ 2013-12-05 19:11 UTC (permalink / raw)
To: Chong.Lu, openembedded-core
On 12/04/2013 10:14 PM, Chong.Lu@windriver.com wrote:
> From: Chong Lu <Chong.Lu@windriver.com>
>
> Update commit in order to add patches like below:
>
> doc/examples: error out when a subdir make fails
> fix: lttng-gen-tp: add missing spaces around flags
>
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
> meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb b/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb
> index fed572a..f3a6b05 100644
> --- a/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb
> +++ b/meta/recipes-kernel/lttng/lttng-ust_2.3.0.bb
> @@ -18,7 +18,7 @@ RPROVIDES_${PN} = "lttng2-ust"
> RREPLACES_${PN} = "lttng2-ust"
> RCONFLICTS_${PN} = "lttng2-ust"
>
> -SRCREV = "9f00ce32b103eed13524c876757b6611c5922382"
> +SRCREV = "e6a8d841217f651e86c8e133e0edbbb667c11055"
> PV = "2.3.0"
> PE = "2"
>
>
lttng-ust was updated to 2.3.1, can you update your patches accordingly
please.
Thanks
Sau!
^ permalink raw reply [flat|nested] 4+ messages in thread