Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Kai Kang <kai.kang@windriver.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] lsb: update directory of install_initd and remove_initd
Date: Tue, 10 Dec 2013 11:40:54 -0800	[thread overview]
Message-ID: <52A76E46.2010008@linux.intel.com> (raw)
In-Reply-To: <bb068bc66bcdbf96dd84e5cd18e1765b9a32f2cc.1384331128.git.kai.kang@windriver.com>

On 11/13/2013 12:27 AM, Kai Kang wrote:
> According to LSB specification:
>
> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/installinitd.html
> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/removeinitd.html
>
> commands install_initd and remove_initd should under directory /usr/lib/lsb/.
>
> lsb recipe creates these commands under directory ${libdir} which may
> expand to /usr/lib64 when multilib is enabled on qemux86-64. That will
> cause LSB command check for install_initd and remove_initd fail. So
> correct it.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   meta/recipes-extended/lsb/lsb_4.1.bb | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
> index c80ff59..8105e59 100644
> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -79,8 +79,8 @@ do_install_append(){
>
>          # creat links for LSB test
>          install -d ${D}/${libdir}/lsb
> -       ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/install_initd
> -       ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/remove_initd
> +       ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/install_initd
> +       ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/remove_initd
It's arguable that this should be ${prefix}/lib since there is a 
possibly case of libdir not being /usr/lib or /usr/lib64.  It also goes 
to LSB explictly requires /usr/lib/lsb so for an LSB machine /usr/lib 
will aways exist.

I will put this in the next C-Pull.

Sau!

>          ln -sf ${sbindir}/sendmail ${D}/${libdir}/sendmail
>
>          if [ "${TARGET_ARCH}" = "x86_64" ];then
>


  parent reply	other threads:[~2013-12-10 19:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13  8:27 [PATCH 0/1] Correct lsb commands install_initd/remove_initd install directory Kai Kang
2013-11-13  8:27 ` [PATCH 1/1] lsb: update directory of install_initd and remove_initd Kai Kang
2013-11-18  5:26   ` Kang Kai
2013-12-10 19:40   ` Saul Wold [this message]
2013-12-11  1:54     ` Kang Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A76E46.2010008@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=kai.kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox