From: Kang Kai <Kai.Kang@windriver.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] lsb: update directory of install_initd and remove_initd
Date: Wed, 11 Dec 2013 09:54:19 +0800 [thread overview]
Message-ID: <52A7C5CB.8060406@windriver.com> (raw)
In-Reply-To: <52A76E46.2010008@linux.intel.com>
On 2013年12月11日 03:40, Saul Wold wrote:
> On 11/13/2013 12:27 AM, Kai Kang wrote:
>> According to LSB specification:
>>
>> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/installinitd.html
>>
>> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/removeinitd.html
>>
>>
>> commands install_initd and remove_initd should under directory
>> /usr/lib/lsb/.
>>
>> lsb recipe creates these commands under directory ${libdir} which may
>> expand to /usr/lib64 when multilib is enabled on qemux86-64. That will
>> cause LSB command check for install_initd and remove_initd fail. So
>> correct it.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>> meta/recipes-extended/lsb/lsb_4.1.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb
>> b/meta/recipes-extended/lsb/lsb_4.1.bb
>> index c80ff59..8105e59 100644
>> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
>> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
>> @@ -79,8 +79,8 @@ do_install_append(){
>>
>> # creat links for LSB test
>> install -d ${D}/${libdir}/lsb
>> - ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/install_initd
>> - ln -sf ${sbindir}/chkconfig ${D}/${libdir}/lsb/remove_initd
>> + ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/install_initd
>> + ln -sf ${sbindir}/chkconfig ${D}/usr/lib/lsb/remove_initd
> It's arguable that this should be ${prefix}/lib since there is a
> possibly case of libdir not being /usr/lib or /usr/lib64. It also goes
> to LSB explictly requires /usr/lib/lsb so for an LSB machine /usr/lib
> will aways exist.
>
> I will put this in the next C-Pull.
Hi Saul,
Sorry, please drop it for now and there is something wrong with this patch.
I intended to send a V2 version and with other changes for lsbtest.
Thanks,
Kai
>
> Sau!
>
>> ln -sf ${sbindir}/sendmail ${D}/${libdir}/sendmail
>>
>> if [ "${TARGET_ARCH}" = "x86_64" ];then
>>
>
>
--
Regards,
Neil | Kai Kang
prev parent reply other threads:[~2013-12-11 1:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 8:27 [PATCH 0/1] Correct lsb commands install_initd/remove_initd install directory Kai Kang
2013-11-13 8:27 ` [PATCH 1/1] lsb: update directory of install_initd and remove_initd Kai Kang
2013-11-18 5:26 ` Kang Kai
2013-12-10 19:40 ` Saul Wold
2013-12-11 1:54 ` Kang Kai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A7C5CB.8060406@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox