[PATCH] Adding irssi 0.8.16-rc1 recipe

[PATCH] Adding irssi 0.8.16-rc1 recipe

[krzysztof.m.sywula]

From: Krzysztof Sywula <krzysztof.m.sywula@intel.com>

---
 meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb

diff --git a/meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb b/meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb
new file mode 100644
index 0000000..478db18
--- /dev/null
+++ b/meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb
@@ -0,0 +1,11 @@
+DESCRIPTION = "Irssi is ncurses IRC client"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=55fdc1113306167d6ea2561404ce02f8"
+
+SRC_URI = "http://irssi.org/files/irssi-0.8.16-rc1.tar.gz"
+
+SRC_URI[md5sum] = "769fec4df8e633c583c411ccd2cd563a"
+SRC_URI[sha256sum] = "bb6c0125db30b697f80837941c17372b7484c64d57a6920b8bfa7ee3def92de3"
+
+DEPENDS = "glib-2.0 ncurses"
+inherit autotools
-- 
1.7.12.2

Re: [PATCH] Adding irssi 0.8.16-rc1 recipe

[Saul Wold]

On 12/27/2013 09:30 AM, krzysztof.m.sywula@intel.com wrote:
> From: Krzysztof Sywula <krzysztof.m.sywula@intel.com>
>
This should really go to meta-openembedded and the 
openembedded-devel@list.openembedded.org mailing list.

You should also include a "Signed-off-by:" tag in your commit message

Sau!

> ---
>   meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>   create mode 100644 meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb
>
> diff --git a/meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb b/meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb
> new file mode 100644
> index 0000000..478db18
> --- /dev/null
> +++ b/meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb
> @@ -0,0 +1,11 @@
> +DESCRIPTION = "Irssi is ncurses IRC client"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=55fdc1113306167d6ea2561404ce02f8"
> +
> +SRC_URI = "http://irssi.org/files/irssi-0.8.16-rc1.tar.gz"
> +
> +SRC_URI[md5sum] = "769fec4df8e633c583c411ccd2cd563a"
> +SRC_URI[sha256sum] = "bb6c0125db30b697f80837941c17372b7484c64d57a6920b8bfa7ee3def92de3"
> +
> +DEPENDS = "glib-2.0 ncurses"
> +inherit autotools
>

Re: [PATCH] Adding irssi 0.8.16-rc1 recipe

[Paul Eggleton]

On Friday 27 December 2013 09:54:00 Saul Wold wrote:
> On 12/27/2013 09:30 AM, krzysztof.m.sywula@intel.com wrote:
> > From: Krzysztof Sywula <krzysztof.m.sywula@intel.com>
> 
> This should really go to meta-openembedded and the
> openembedded-devel@list.openembedded.org mailing list.
> 
> You should also include a "Signed-off-by:" tag in your commit message

A couple of other things:

1) the shortlog (first line of the commit message) should start with the recipe 
name and then a colon i.e. "irssi: ..."

2) When setting a short description, set the SUMMARY variable rather than 
DESCRIPTION

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH] Adding irssi 0.8.16-rc1 recipe

[Koen Kooi]

Op 27 dec. 2013, om 18:30 heeft krzysztof.m.sywula@intel.com het volgende geschreven:

> From: Krzysztof Sywula <krzysztof.m.sywula@intel.com>
> 
> ---
> meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb | 11 +++++++++++

that should be 0.8.15+0.8.16-rc1 to conform to the versioning policy

Re: [PATCH] Adding irssi 0.8.16-rc1 recipe

[Sywula, Krzysztof M]

Hi, why would it be '0.8.15'? Recipe points to 0.8.16-rc1 tarball and that's the only one that can be built. 

Thanks,
Krzysztof Sywula

-----Original Message-----
From: Koen Kooi [mailto:koen@dominion.thruhere.net] 
Sent: Tuesday, December 31, 2013 12:19 PM
To: Sywula, Krzysztof M
Cc: Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH] Adding irssi 0.8.16-rc1 recipe


Op 27 dec. 2013, om 18:30 heeft krzysztof.m.sywula@intel.com het volgende geschreven:

> From: Krzysztof Sywula <krzysztof.m.sywula@intel.com>
> 
> ---
> meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb | 11 +++++++++++

that should be 0.8.15+0.8.16-rc1 to conform to the versioning policy
-------------------------------------------------------------
Intel Ireland Limited (Branch)
Collinstown Industrial Park, Leixlip, County Kildare, Ireland
Registered Number: E902934

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [PATCH] Adding irssi 0.8.16-rc1 recipe

[Philip Balister]

On 01/03/2014 10:20 AM, Sywula, Krzysztof M wrote:
> Hi, why would it be '0.8.15'? Recipe points to 0.8.16-rc1 tarball and that's the only one that can be built. 

> that should be 0.8.15+0.8.16-rc1 to conform to the versioning policy

So that when you have the final 0.8.16 package, the version sorts higher
and updates happen. That is why the "base" version is 0.8.15, even
though the package is for a 0.8.16-rcX version.

Philip

> 
> Thanks,
> Krzysztof Sywula
> 
> -----Original Message-----
> From: Koen Kooi [mailto:koen@dominion.thruhere.net] 
> Sent: Tuesday, December 31, 2013 12:19 PM
> To: Sywula, Krzysztof M
> Cc: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH] Adding irssi 0.8.16-rc1 recipe
> 
> 
> Op 27 dec. 2013, om 18:30 heeft krzysztof.m.sywula@intel.com het volgende geschreven:
> 
>> From: Krzysztof Sywula <krzysztof.m.sywula@intel.com>
>>
>> ---
>> meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb | 11 +++++++++++
> 
> that should be 0.8.15+0.8.16-rc1 to conform to the versioning policy
> -------------------------------------------------------------
> Intel Ireland Limited (Branch)
> Collinstown Industrial Park, Leixlip, County Kildare, Ireland
> Registered Number: E902934
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 

Re: [PATCH] Adding irssi 0.8.16-rc1 recipe

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

On Fri, Jan 03, 2014 at 03:20:31PM +0000, Sywula, Krzysztof M wrote:
> Hi, why would it be '0.8.15'? Recipe points to 0.8.16-rc1 tarball and that's the only one that can be built. 

because
0.8.15+0.8.16-rc1 < 0.8.16
but
0.8.16-rc1 > 0.8.16

> Thanks,
> Krzysztof Sywula
> 
> -----Original Message-----
> From: Koen Kooi [mailto:koen@dominion.thruhere.net] 
> Sent: Tuesday, December 31, 2013 12:19 PM
> To: Sywula, Krzysztof M
> Cc: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH] Adding irssi 0.8.16-rc1 recipe
> 
> 
> Op 27 dec. 2013, om 18:30 heeft krzysztof.m.sywula@intel.com het volgende geschreven:
> 
> > From: Krzysztof Sywula <krzysztof.m.sywula@intel.com>
> > 
> > ---
> > meta/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb | 11 +++++++++++
> 
> that should be 0.8.15+0.8.16-rc1 to conform to the versioning policy
> -------------------------------------------------------------
> Intel Ireland Limited (Branch)
> Collinstown Industrial Park, Leixlip, County Kildare, Ireland
> Registered Number: E902934
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]