* [PATCH] guile: fix the depends for target recipes
@ 2014-01-03 9:37 jackie.huang
2014-01-03 10:15 ` Martin Jansa
0 siblings, 1 reply; 3+ messages in thread
From: jackie.huang @ 2014-01-03 9:37 UTC (permalink / raw)
To: openembedded-core
From: Jackie Huang <jackie.huang@windriver.com>
The depenency on guild-native and libatomics-ops is missing
in multilib build, fix the depends with class-target.
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
meta/recipes-devtools/guile/guile_2.0.9.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/guile/guile_2.0.9.bb b/meta/recipes-devtools/guile/guile_2.0.9.bb
index 4c3fe28..cb7c72e 100644
--- a/meta/recipes-devtools/guile/guile_2.0.9.bb
+++ b/meta/recipes-devtools/guile/guile_2.0.9.bb
@@ -33,7 +33,7 @@ BBCLASSEXTEND = "native"
DEPENDS = "libunistring bdwgc gmp libtool libffi"
# add guile-native only to the target recipe's DEPENDS
-DEPENDS += "${@['guile-native libatomics-ops', ''][d.getVar('PN', True) != 'guile']}"
+DEPENDS_append_class-target += "guile-native libatomics-ops"
RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] guile: fix the depends for target recipes
2014-01-03 9:37 [PATCH] guile: fix the depends for target recipes jackie.huang
@ 2014-01-03 10:15 ` Martin Jansa
2014-01-06 2:24 ` jhuang0
0 siblings, 1 reply; 3+ messages in thread
From: Martin Jansa @ 2014-01-03 10:15 UTC (permalink / raw)
To: jackie.huang; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
On Fri, Jan 03, 2014 at 05:37:32PM +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
>
> The depenency on guild-native and libatomics-ops is missing
> in multilib build, fix the depends with class-target.
>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
> meta/recipes-devtools/guile/guile_2.0.9.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/guile/guile_2.0.9.bb b/meta/recipes-devtools/guile/guile_2.0.9.bb
> index 4c3fe28..cb7c72e 100644
> --- a/meta/recipes-devtools/guile/guile_2.0.9.bb
> +++ b/meta/recipes-devtools/guile/guile_2.0.9.bb
> @@ -33,7 +33,7 @@ BBCLASSEXTEND = "native"
>
> DEPENDS = "libunistring bdwgc gmp libtool libffi"
> # add guile-native only to the target recipe's DEPENDS
> -DEPENDS += "${@['guile-native libatomics-ops', ''][d.getVar('PN', True) != 'guile']}"
> +DEPENDS_append_class-target += "guile-native libatomics-ops"
Don't use _append together with +=, just add space before guile-native.
>
> RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"
>
> --
> 1.7.9.5
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] guile: fix the depends for target recipes
2014-01-03 10:15 ` Martin Jansa
@ 2014-01-06 2:24 ` jhuang0
0 siblings, 0 replies; 3+ messages in thread
From: jhuang0 @ 2014-01-06 2:24 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core
On 1/3/2014 6:15 PM, Martin Jansa wrote:
> On Fri, Jan 03, 2014 at 05:37:32PM +0800, jackie.huang@windriver.com wrote:
>> From: Jackie Huang <jackie.huang@windriver.com>
>>
>> The depenency on guild-native and libatomics-ops is missing
>> in multilib build, fix the depends with class-target.
>>
>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> ---
>> meta/recipes-devtools/guile/guile_2.0.9.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/guile/guile_2.0.9.bb b/meta/recipes-devtools/guile/guile_2.0.9.bb
>> index 4c3fe28..cb7c72e 100644
>> --- a/meta/recipes-devtools/guile/guile_2.0.9.bb
>> +++ b/meta/recipes-devtools/guile/guile_2.0.9.bb
>> @@ -33,7 +33,7 @@ BBCLASSEXTEND = "native"
>>
>> DEPENDS = "libunistring bdwgc gmp libtool libffi"
>> # add guile-native only to the target recipe's DEPENDS
>> -DEPENDS += "${@['guile-native libatomics-ops', ''][d.getVar('PN', True) != 'guile']}"
>> +DEPENDS_append_class-target += "guile-native libatomics-ops"
>
> Don't use _append together with +=, just add space before guile-native.
Fixed and sent v2 for this, thanks!
Thanks,
Jackie
>
>>
>> RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"
>>
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
--
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-06 2:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-03 9:37 [PATCH] guile: fix the depends for target recipes jackie.huang
2014-01-03 10:15 ` Martin Jansa
2014-01-06 2:24 ` jhuang0
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox