[dora]Re: Failure in license.bbclass

[dora]Re: Failure in license.bbclass

[Hongxu Jia]

It seems dora has some patches of oe-pkgdata-util not
rebased from poky, such as:

commit 6ce287937e86a43d696e3615aa18d439928b7691
Author: Paul Eggleton <paul.eggleton@linux.intel.com>
Date:   Fri Oct 18 14:52:10 2013 +0100

     scripts/oe-pkgdata-util: add ability to find a recipe from a target 
package

//Hongxu


On 03/11/2014 04:48 PM, Jussi Laako wrote:
> Hi,
>
> Your recent (from November) change to license.bbclass in Yocto Dora 
> release completely breaks COPY_LIC_DIRS.
>
> Running the command manually for any package results in command line 
> syntax error:
> jussi@porkkala:/home/scratch/jussi/poky/build> oe-pkgdata-util 
> lookup-recipe 
> /home/scratch/jussi/poky/build/tmp/sysroots/cubox-i/pkgdata 
> alsa-conf-base
> syntax: oe-pkgdata-util glob [-d] <pkgdatadir> <vendor-os> <pkglist> 
> "<globs>"
>                      read-value [-d] <pkgdatadir> <vendor-os> 
> <value-name> "<package-name>_<package_architecture>"
>
>
> Best regards,
>
>     - Jussi

Re: [dora]Re: Failure in license.bbclass

[Paul Eggleton]

Hi Hongxu,

The person you need to CC is Robert Yang since he maintains the dora branch. 
FWIW I hadn't anticipated this patch being backported, but I guess if 
functionality now in dora relies upon it we have no choice :(

Cheers,
Paul


On Tuesday 11 March 2014 17:16:05 Hongxu Jia wrote:
> It seems dora has some patches of oe-pkgdata-util not
> rebased from poky, such as:
> 
> commit 6ce287937e86a43d696e3615aa18d439928b7691
> Author: Paul Eggleton <paul.eggleton@linux.intel.com>
> Date:   Fri Oct 18 14:52:10 2013 +0100
> 
>      scripts/oe-pkgdata-util: add ability to find a recipe from a target
> package
> 
> //Hongxu
> 
> On 03/11/2014 04:48 PM, Jussi Laako wrote:
> > Hi,
> > 
> > Your recent (from November) change to license.bbclass in Yocto Dora
> > release completely breaks COPY_LIC_DIRS.
> > 
> > Running the command manually for any package results in command line
> > syntax error:
> > jussi@porkkala:/home/scratch/jussi/poky/build> oe-pkgdata-util
> > lookup-recipe
> > /home/scratch/jussi/poky/build/tmp/sysroots/cubox-i/pkgdata
> > alsa-conf-base
> > syntax: oe-pkgdata-util glob [-d] <pkgdatadir> <vendor-os> <pkglist>
> > "<globs>"
> > 
> >                      read-value [-d] <pkgdatadir> <vendor-os>
> > 
> > <value-name> "<package-name>_<package_architecture>"
> > 
> > 
> > Best regards,
> > 
> >     - Jussi

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [dora]Re: Failure in license.bbclass

[Robert Yang]

On 03/11/2014 06:02 PM, Paul Eggleton wrote:
> Hi Hongxu,
>
> The person you need to CC is Robert Yang since he maintains the dora branch.
> FWIW I hadn't anticipated this patch being backported, but I guess if
> functionality now in dora relies upon it we have no choice :(
>

I'm sorry to say that it seems that we can't backport this patch since
we need at least the following patches, it is not a good idea to backport
it:

d69931d scripts/oe-pkgdata-util: fix global name 'debug' is not defined
6ce2879 scripts/oe-pkgdata-util: add ability to find a recipe from a target package
948a714 scripts/oe-pkgdata-util: add ability to look up runtime package names
48755f1 scripts/oe-pkgdata-util: add ability to search for a target path
4ec1f8c scripts/oe-pkgdata-util: check path arguments to ensure they exist
8b42409 scripts/oe-pkgdata-util: improve help text and command line parsing
9ce903b scripts/oe-pkgdata-util: remove remnants of former pkgdata structure

It is because I backported this commit: (I'm sorry about that)

commit e58a1499accd74d3e6fe4f899711d4c680ebc18f
Author: Hongxu Jia <hongxu.jia@windriver.com>
Date:   Wed Nov 20 18:35:39 2013 +0800

     license.bbclass: fix copying license directories failed

It is used for fixing this bug:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5572

Enalbe COPY_LIC_MANIFEST and COPY_LIC_DIRS: No kernel license is installed in image

But it used the "oe-pkgdata-util lookup-recipe" which is only on master branch,
I think that we'd better:

1) Revert this commit, then it works with minor problems.

Or

2) Fix the "oe-pkgdata-util lookup-recipe" on dora.

// Robert

> Cheers,
> Paul
>
>
> On Tuesday 11 March 2014 17:16:05 Hongxu Jia wrote:
>> It seems dora has some patches of oe-pkgdata-util not
>> rebased from poky, such as:
>>
>> commit 6ce287937e86a43d696e3615aa18d439928b7691
>> Author: Paul Eggleton <paul.eggleton@linux.intel.com>
>> Date:   Fri Oct 18 14:52:10 2013 +0100
>>
>>       scripts/oe-pkgdata-util: add ability to find a recipe from a target
>> package
>>
>> //Hongxu
>>
>> On 03/11/2014 04:48 PM, Jussi Laako wrote:
>>> Hi,
>>>
>>> Your recent (from November) change to license.bbclass in Yocto Dora
>>> release completely breaks COPY_LIC_DIRS.
>>>
>>> Running the command manually for any package results in command line
>>> syntax error:
>>> jussi@porkkala:/home/scratch/jussi/poky/build> oe-pkgdata-util
>>> lookup-recipe
>>> /home/scratch/jussi/poky/build/tmp/sysroots/cubox-i/pkgdata
>>> alsa-conf-base
>>> syntax: oe-pkgdata-util glob [-d] <pkgdatadir> <vendor-os> <pkglist>
>>> "<globs>"
>>>
>>>                       read-value [-d] <pkgdatadir> <vendor-os>
>>>
>>> <value-name> "<package-name>_<package_architecture>"
>>>
>>>
>>> Best regards,
>>>
>>>      - Jussi
>

Re: [dora]Re: Failure in license.bbclass

[Robert Yang]

On 03/13/2014 05:00 PM, Jussi Laako wrote:
> Hi,
>
> On 03/11/2014 12:40 PM, Robert Yang wrote:
>> It is used for fixing this bug:
>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=5572
>>
>> Enalbe COPY_LIC_MANIFEST and COPY_LIC_DIRS: No kernel license is
>> installed in image
>>
>> But it used the "oe-pkgdata-util lookup-recipe" which is only on master
>> branch,
>> I think that we'd better:
>>
>> 1) Revert this commit, then it works with minor problems.
>>
>> Or
>>
>> 2) Fix the "oe-pkgdata-util lookup-recipe" on dora.
>
> With core-image-minimal spiced up with couple of packages, there were quite many
> license directories left empty, so it requires fair amount of manual work to
> rectify the situation. So it is far more than just the kernel.
>
> For example any libraries coming from util-linux, plus any of the gcc runtimes
> (libgcc, etc). There are many packages where source name doesn't match with the
> produced packages.
>
> Since BSPs tend to lag behind release schedule, option (2) could possibly help
> quite many...
>

Thanks, I've talked Hongxu, he will fix it on dora without backport
the 7 commits, and we need revert this one on dora:

commit e58a1499accd74d3e6fe4f899711d4c680ebc18f
Author: Hongxu Jia <hongxu.jia@windriver.com>
Date:   Wed Nov 20 18:35:39 2013 +0800

     license.bbclass: fix copying license directories failed


Paul and RP, what's your opinion, please ?

// Robert


>
> Best regards,
>
>      - Jussi
>
>

Re: [dora]Re: Failure in license.bbclass

[Richard Purdie]

On Tue, 2014-03-25 at 17:09 +0800, Robert Yang wrote:
> 
> On 03/13/2014 05:00 PM, Jussi Laako wrote:
> > Hi,
> >
> > On 03/11/2014 12:40 PM, Robert Yang wrote:
> >> It is used for fixing this bug:
> >> https://bugzilla.yoctoproject.org/show_bug.cgi?id=5572
> >>
> >> Enalbe COPY_LIC_MANIFEST and COPY_LIC_DIRS: No kernel license is
> >> installed in image
> >>
> >> But it used the "oe-pkgdata-util lookup-recipe" which is only on master
> >> branch,
> >> I think that we'd better:
> >>
> >> 1) Revert this commit, then it works with minor problems.
> >>
> >> Or
> >>
> >> 2) Fix the "oe-pkgdata-util lookup-recipe" on dora.
> >
> > With core-image-minimal spiced up with couple of packages, there were quite many
> > license directories left empty, so it requires fair amount of manual work to
> > rectify the situation. So it is far more than just the kernel.
> >
> > For example any libraries coming from util-linux, plus any of the gcc runtimes
> > (libgcc, etc). There are many packages where source name doesn't match with the
> > produced packages.
> >
> > Since BSPs tend to lag behind release schedule, option (2) could possibly help
> > quite many...
> >
> 
> Thanks, I've talked Hongxu, he will fix it on dora without backport
> the 7 commits, and we need revert this one on dora:
> 
> commit e58a1499accd74d3e6fe4f899711d4c680ebc18f
> Author: Hongxu Jia <hongxu.jia@windriver.com>
> Date:   Wed Nov 20 18:35:39 2013 +0800
> 
>      license.bbclass: fix copying license directories failed
> 
> 
> Paul and RP, what's your opinion, please ?

Seems reasonable to me. We reverted that patch a while ago.

Cheers,

Richard