[PATCH 0/1]eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19

Openembedded Core Discussions
 help / color / mirror / Atom feed

* [PATCH 0/1]eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19
@ 2014-03-13  2:14 Hongxu Jia
  2014-03-13  2:14 ` [PATCH 1/1] eglibc: " Hongxu Jia
  2014-03-13  2:32 ` [PATCH 0/1]eglibc: " Khem Raj
  0 siblings, 2 replies; 4+ messages in thread
From: Hongxu Jia @ 2014-03-13  2:14 UTC (permalink / raw)
  To: openembedded-core; +Cc: msm, saul.wold

The following changes since commit 5f81d9d1fa537445d5da49e12de1e16300e94552:

  bitbake: runqueue: Use SIGCHLD instead of polling waitpid (2014-03-10 11:10:02 -0700)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib hongxu/fix-eglibc
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-eglibc

Hongxu Jia (1):
  eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19

 .../eglibc/eglibc-2.19/glibc.fix_sqrt2.patch       | 24 +++++++++++-----------
 1 file changed, 12 insertions(+), 12 deletions(-)

-- 
1.8.1.2



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19
  2014-03-13  2:14 [PATCH 0/1]eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19 Hongxu Jia
@ 2014-03-13  2:14 ` Hongxu Jia
  2014-03-13  2:32 ` [PATCH 0/1]eglibc: " Khem Raj
  1 sibling, 0 replies; 4+ messages in thread
From: Hongxu Jia @ 2014-03-13  2:14 UTC (permalink / raw)
  To: openembedded-core; +Cc: msm, saul.wold

While the type of powerpc32 cpu is 603e (In meta/conf/machine/
qemuppc.conf, require conf/machine/include/tune-ppc603e.inc),
there was a failure to build eglibc-2.19:
...
| ../sysdeps/powerpc/powerpc32/603e/fpu/e_sqrt.c: In function
'__slow_ieee754_sqrt':
| ../sysdeps/powerpc/powerpc32/603e/fpu/e_sqrt.c:122:15: error:
subscripted value is neither array nor pointer nor vector
|        if ((u.l[1] & FE_INVALID) == 0)
|                ^
| ../sysdeps/powerpc/powerpc32/603e/fpu/e_sqrt.c:121:20: warning:
variable 'u' set but not used [-Wunused-but-set-variable]
|        fenv_union_t u = { .fenv = fegetenv_register () };
...

In 'eglibc-2.19/libc/sysdeps/powerpc/fpu/fenv_libc.h', the above
struct fenv_union_t is defined as:
...
typedef union
{
  fenv_t fenv;
  unsigned long long l;
} fenv_union_t;
...

Rather than 'eglibc-2.16/libc/sysdeps/powerpc/fpu/fenv_libc.h':
...
typedef union
{
  fenv_t fenv;
  unsigned int l[2];
} fenv_union_t;
...

So we should update the glibc.fix_sqrt2.patch for eglibc-2.19.

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 .../eglibc/eglibc-2.19/glibc.fix_sqrt2.patch       | 24 +++++++++++-----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/meta/recipes-core/eglibc/eglibc-2.19/glibc.fix_sqrt2.patch b/meta/recipes-core/eglibc/eglibc-2.19/glibc.fix_sqrt2.patch
index a669729..0dcca7c 100644
--- a/meta/recipes-core/eglibc/eglibc-2.19/glibc.fix_sqrt2.patch
+++ b/meta/recipes-core/eglibc/eglibc-2.19/glibc.fix_sqrt2.patch
@@ -132,7 +132,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc32/603e/fpu/e_sqrt.c libc/sysdeps/pow
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -237,7 +237,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc32/603e/fpu/e_sqrtf.c libc/sysdeps/po
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -375,7 +375,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc32/e500mc/fpu/e_sqrt.c libc/sysdeps/p
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -480,7 +480,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc32/e500mc/fpu/e_sqrtf.c libc/sysdeps/
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -618,7 +618,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc32/e5500/fpu/e_sqrt.c libc/sysdeps/po
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -723,7 +723,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc32/e5500/fpu/e_sqrtf.c libc/sysdeps/p
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -861,7 +861,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc32/e6500/fpu/e_sqrt.c libc/sysdeps/po
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -966,7 +966,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc32/e6500/fpu/e_sqrtf.c libc/sysdeps/p
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -1104,7 +1104,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc64/e5500/fpu/e_sqrt.c libc/sysdeps/po
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -1209,7 +1209,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc64/e5500/fpu/e_sqrtf.c libc/sysdeps/p
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -1347,7 +1347,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc64/e6500/fpu/e_sqrt.c libc/sysdeps/po
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
@@ -1452,7 +1452,7 @@ diff -ruN libc-orig/sysdeps/powerpc/powerpc64/e6500/fpu/e_sqrtf.c libc/sysdeps/p
 +      feraiseexcept (FE_INVALID_SQRT);
 +
 +      fenv_union_t u = { .fenv = fegetenv_register () };
-+      if ((u.l[1] & FE_INVALID) == 0)
++      if ((u.l & FE_INVALID) == 0)
 +#endif
 +	feraiseexcept (FE_INVALID);
 +      b = a_nan.value;
-- 
1.8.1.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/1]eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19
  2014-03-13  2:14 [PATCH 0/1]eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19 Hongxu Jia
  2014-03-13  2:14 ` [PATCH 1/1] eglibc: " Hongxu Jia
@ 2014-03-13  2:32 ` Khem Raj
  2014-03-13  3:18   ` Hongxu Jia
  1 sibling, 1 reply; 4+ messages in thread
From: Khem Raj @ 2014-03-13  2:32 UTC (permalink / raw)
  To: Hongxu Jia; +Cc: msm, saul.wold, openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]


On Mar 12, 2014, at 7:14 PM, Hongxu Jia <hongxu.jia@windriver.com> wrote:

> The following changes since commit 5f81d9d1fa537445d5da49e12de1e16300e94552:
> 
>  bitbake: runqueue: Use SIGCHLD instead of polling waitpid (2014-03-10 11:10:02 -0700)
> 
> are available in the git repository at:
> 
>  git://git.pokylinux.org/poky-contrib hongxu/fix-eglibc
>  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-eglibc

Does this patch do anything in addition to

commit 6235cc3ccf98dce15ffe3313cf4e6cdf9c922bce
Author: Khem Raj <raj.khem@gmail.com>
Date:   Mon Mar 10 15:51:37 2014 +0000

    eglibc: Fix build for FSL ppc/fpu
    
    The patch needs to adapt to upstream changes
    should fix errors on e500mc+ based SOCs
    
    This should fix [YOCTO #5871]
    
    Signed-off-by: Khem Raj <raj.khem@gmail.com>
    Signed-off-by: Saul Wold <sgw@linux.intel.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>





> 
> Hongxu Jia (1):
>  eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19
> 
> .../eglibc/eglibc-2.19/glibc.fix_sqrt2.patch       | 24 +++++++++++-----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
> 
> -- 
> 1.8.1.2
> 


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/1]eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19
  2014-03-13  2:32 ` [PATCH 0/1]eglibc: " Khem Raj
@ 2014-03-13  3:18   ` Hongxu Jia
  0 siblings, 0 replies; 4+ messages in thread
From: Hongxu Jia @ 2014-03-13  3:18 UTC (permalink / raw)
  To: Khem Raj; +Cc: msm, saul.wold, openembedded-core

On 03/13/2014 10:32 AM, Khem Raj wrote:
> On Mar 12, 2014, at 7:14 PM, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>
>> The following changes since commit 5f81d9d1fa537445d5da49e12de1e16300e94552:
>>
>>   bitbake: runqueue: Use SIGCHLD instead of polling waitpid (2014-03-10 11:10:02 -0700)
>>
>> are available in the git repository at:
>>
>>   git://git.pokylinux.org/poky-contrib hongxu/fix-eglibc
>>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-eglibc
> Does this patch do anything in addition to

Oh, It seems I am not updating to the latest version,
you have fixed this issue, so please drop the duplicated
one.

//Hongxu

> commit 6235cc3ccf98dce15ffe3313cf4e6cdf9c922bce
> Author: Khem Raj <raj.khem@gmail.com>
> Date:   Mon Mar 10 15:51:37 2014 +0000
>
>      eglibc: Fix build for FSL ppc/fpu
>      
>      The patch needs to adapt to upstream changes
>      should fix errors on e500mc+ based SOCs
>      
>      This should fix [YOCTO #5871]
>      
>      Signed-off-by: Khem Raj <raj.khem@gmail.com>
>      Signed-off-by: Saul Wold <sgw@linux.intel.com>
>      Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
>
>
>
>
>> Hongxu Jia (1):
>>   eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19
>>
>> .../eglibc/eglibc-2.19/glibc.fix_sqrt2.patch       | 24 +++++++++++-----------
>> 1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> -- 
>> 1.8.1.2
>>



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-03-13  3:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-13  2:14 [PATCH 0/1]eglibc: tweak glibc.fix_sqrt2.patch for eglibc-2.19 Hongxu Jia
2014-03-13  2:14 ` [PATCH 1/1] eglibc: " Hongxu Jia
2014-03-13  2:32 ` [PATCH 0/1]eglibc: " Khem Raj
2014-03-13  3:18   ` Hongxu Jia

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox